Repository navigation
Drop the unused tile weight vignets (campaign boundary) - #932
Merged
Merged
Conversation
The first vignetmaker_runner in tile_vignets cut CLASSIC-mode tile weight stamps that nothing reads: ngmix takes weight_vignet from the multi-epoch run's output. With one vignetmaker_runner left, ShapePipe names its section and output directory without a _RUN_N suffix, so VIGNETMAKER_RUNNER_RUN_2 becomes VIGNETMAKER_RUNNER and vignetmaker_runner_run_2/output becomes vignetmaker_runner/output in the configs, completeness table, tile_shape guard, astra.yaml Values and params pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cailmdaley
marked this pull request as ready for review
October 25, 2026 23:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove the unused CLASSIC-mode tile-weight stamp extraction from
tile_vignets.Ngmix reads exposure-level weights from the multi-epoch extraction; the separate tile-weight stamps have no consumer.
The PSFEx, MCCD and image-simulation configuration chains retain PSF interpolation and the five multi-epoch stores: image, weight, flag, background and background RMS.
Configuration contract
A single invocation uses the section
VIGNETMAKER_RUNNERand output pathvignetmaker_runner/output, without a_run_Nsuffix.The ngmix input paths, tile-shape store guard, completeness table and ASTRA Values use that singleton name.
Completeness requires all five multi-epoch stores and no longer expects the unused tile-weight FITS output.
Config-parser tests cover both singleton sections and repeated modules, including refusal when a required section is missing.
Deploy at a campaign boundary.
The shared completeness helper and tile-shape prologue change workflow parameters and shell fingerprints, so resuming finished units can trigger reruns.
Separate params pins cover the default UberSeg treatment and explicit noisefill.
This changes extraction work and internal paths, not the weights ngmix fits or its scientific cuts.
— Codex on behalf of Cail.