Fix metadata server path resolution issues#294
Merged
DevOpsDave merged 9 commits intomasterfrom Jan 29, 2026
Merged
Conversation
Fixes three path resolution errors that prevented the metadata server from starting: 1. Corrected metadata-server.js path from '../lib/metadata-server.js' to '../metadata-server.js' 2. Fixed forever daemon root from '../' to '../../../../' to properly resolve to project root 3. Updated service file path from '../service' to '../../../../service' These changes ensure paths correctly resolve from the dist/src/lib/handlers/ directory context after TypeScript compilation. Resolves DE565327 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… for using artifactory.
…the op as deprecated.
Contributor
|
@samsolaimani I reviewed this and it looks good. At first I drilled into the deep relative paths thinking they made things brittle but after looking more into it I left it as is. Dealing with the deep literal paths would need more automation that I would rather not put into this PR. I really like the description for this PR. It was short and concise. Also the testing instructions were appreciated. I made some additional changes:
We should have someone else now give a final review. |
codykoelemay
approved these changes
Jan 28, 2026
Contributor
codykoelemay
left a comment
There was a problem hiding this comment.
Followed the testing instructions and looks like it worked. Returned credentials
I had to do a additional command alks server configure -a awscoxautolabs95 -r LabAdmin before the last step and then it returned credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three path resolution errors that prevented the metadata server from starting properly.
Changes
'../lib/metadata-server.js'to'../metadata-server.js''../'to'../../../../'to properly resolve to project root'../service'to'../../../../service'These paths must resolve correctly from the
dist/src/lib/handlers/directory context after TypeScript compilation.Additional changes by Dave:
Testing Instructions
npm run buildnode dist/src/bin/alks.js server startcurl http://169.254.169.254/latest/meta-data/iam/security-credentials/alkscurl http://169.254.169.254/latest/meta-data/iam/security-credentials/alksNote: Testing must use
169.254.169.254(not127.0.0.1:45000) as the pf rules redirect traffic.Related