Skip to content

Reject in-memory sorting on complex fields - #179

Merged
woksin merged 4 commits into
mainfrom
fix/174-complex-sorting-minimal
Oct 2, 2026
Merged

woksin merged 4 commits into
mainfrom
fix/174-complex-sorting-minimal

Conversation

@woksin

@woksin woksin commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Fixed

  • In-memory sorting on a complex field (object, array, map, or a concept over one) now answers 400 malformedRequest, or a validation-result frame once an observable stream has started, instead of returning an unreliable order. (Sorting on complex fields is silently ignored #174)

Deprecated

@woksin woksin added the patch Backward-compatible fixes label Oct 2, 2026
@woksin woksin self-assigned this Oct 2, 2026
@woksin

woksin commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes: this is the third design for #174. The first two (branch fix/174-complex-sorting, kept for reference) changed the MongoDB/Drizzle providers, paged results, error shapes and the order of client output and interception. Full reviews found regressions there, including a critical bypass of read-model interception. This version only adds a scalar check to Arc's existing in-memory sort rejection, and only marks complex-field sortBy helpers @deprecated.

Compared with main (cbb421a), the generated proxies are identical for the generator fixtures (9 files) and the Tasks/Library samples (12 files). The only differences are 8 deprecation comments in the ProxyComparison snapshot. So nothing in the generated public API is removed or renamed, and patch applies.

Follow-ups: #176 (raw concept/Date ordering), #177 (remove the deprecated helpers in the next major), #178 (type indirect and generic concept subclasses as their scalar).

Local: every root ci step passed (3,371 specs), plus yarn test:conformance (298 HTTP checks and the live proxy comparison). Full and quick cross-provider reviews ran; all confirmed findings are fixed.

@woksin
woksin merged commit 4f31114 into main Oct 2, 2026
@cratis-direct
cratis-direct Bot deleted the fix/174-complex-sorting-minimal branch October 2, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Backward-compatible fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant