Make the proxy activity timeout configurable and document streaming - #166
Merged
Merged
Conversation
…d globally The five-minute idle limit on proxied requests was hardcoded. It can now be set on the root, a service or one endpoint, with the most specific value winning, and invalid values fail at startup. Document how it applies to WebSocket and Server-Sent Events streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The idle limit AuthProxy applies to proxied requests, WebSocket sessions and Server-Sent Events streams is now configurable, and the documentation describes how streaming behaves through the proxy.
Added
ActivityTimeoutat the root (Cratis:AuthProxy:ActivityTimeout), per service underServicesand perBackend/Frontendendpoint; the most specific value wins and the default stays five minutes. Values must be between one millisecond and 2,147,483,647 milliseconds (about 24 days), inclusive; values outside this range stop AuthProxy at startup with a message naming the setting. (Make the proxy activity timeout configurable and document streaming (WebSocket, SSE) #153)Registration:ActivityTimeoutandActivityTimeoutonInvite:Lobbyor any of its endpoints. Remove these settings and configure the proxied service'sBackendorFrontendtimeout underServicesinstead. (Make the proxy activity timeout configurable and document streaming (WebSocket, SSE) #153)WithActivityTimeoutandWithServiceActivityTimeoutto set the limit from an app host. (Make the proxy activity timeout configurable and document streaming (WebSocket, SSE) #153)