Repository navigation
4.19.1: filter panels respect classic scrollbars and toolbar icons are centered - #363
Merged
Merged
Conversation
Key only the internal Arc subscriber by serialized arguments so the table and paginator keep their UI state. Show loading for uncached arguments and report cached results before paint.
Clamp against the layout viewport rather than including scrollbar space. Document the unsupported rotation and skew containing blocks.
Arc 22.16 retains subscriptions by arguments and does not resubscribe on page changes. Keep the snapshot page guard, but let observable tables show the current arguments' delivered page and matching paginator instead of remaining in Loading.
The keyed-subscriber approach kept surfacing edge cases, and the root cause is in Arc's query hooks, which keep previous results across argument changes and accept late responses for stale arguments. #354 moves to an Arc fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter panels stay out from under classic scrollbars, and toolbar icons are vertically centered.
Fixed
FilterPanelkeeps its panel inside the visible area when the page shows classic, non-overlay scrollbars. Before, a panel opened near the right or bottom edge could extend under the scrollbar. Fixed panels now follow the browser's layout viewport, the same way in every browser. Rotated or skewed overlay containers are not supported; translated and scaled ones are. (FilterPanel can extend under a classic scrollbar, and rotated containers are not positioned #356)ToolbarButtonicons are vertically centered for icon fonts and SVG icons, in regular and list mode, even under an inherited line height. An icon part hidden with thehiddenattribute throughpt.iconstays hidden. (ToolbarButton's icon is baseline-aligned, not centered, so it renders high in the button #321)Closes #356, closes #321.