Split DataTableCore into focused modules - #373
Merged
Merged
Conversation
DataTableCore keeps its props contract and composes useDataTableState, useDataTableMessages, useRowSelection, the search box, header cell, body and row. Internal components take the part attributes as parts, so the public pt inventory is unchanged, and the parts manifest lists their files as DataTableCore sources. Rendered markup is byte-identical to before across 29 prop combinations, server and client, and the API surface snapshot is unchanged (#372)
woksin
added
the
no-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataTableCoreis split into focused modules ahead of server mode for the bound tables (#178). Nothing a consumer can observe changes: rendered markup, parts, focus behavior, callbacks and the public API are the same, so this PR publishes nothing.Changed
DataTableCore.tsxshrinks from 892 lines to its props contract and the composition of:useDataTableState(controlled filter, search and sort);useDataTableMessages;useRowSelection;processRows(filter and sort, or rows as given);api-surface.jsonand the parts inventory are unchanged, and every spec and Storybook check passes.Closes #372.