Components 3: limit PrimeReact to 11.0-11.1 and publish maintenance releases under v3-lts - #381
Merged
Merged
Conversation
PrimeReact 11.2.0 renamed @primereact/styles/password to inputpassword, which Components 3 imports, so ^11.0.0 promised a version that fails to build. The PrimeReact peers are now >=11.0.0 <11.2.0. The support line also commits its lockfile so a maintenance release builds what was tested (#375)
publish.yml on support/3.x is dispatch-only. It validates that the version is a new 3.x version, builds and tests, publishes with --tag v3-lts, verifies that npm latest stayed on the current major, and pushes a plain git tag, since a GitHub release would become the release action's base version on main. publish-version refuses to run without a non-latest tag (#379)
publish-version skips packages already on the registry at the version, so a re-run after a partial publish continues instead of failing forever. Publishing, verification and tagging are separate jobs: the job that runs third-party code has read-only contents and no persisted credentials, verification waits up to ten minutes for the registry, and only the tag job can write. The 3.x pull-request CI keys its cache on the committed yarn.lock, no longer caches it, and installs with --immutable (#379)
The verify job's retries fit well inside its timeout, and a moved latest is reported before waiting on the registry (#379)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Components 3 no longer accepts PrimeReact versions it cannot build with, and 3.x maintenance releases can be published without moving npm
latestoff Components 4.Fixed
>=11.0.0 <11.2.0. PrimeReact 11.2.0 renamed@primereact/styles/password, which Components 3 imports, so^11.0.0promised a version that fails to build. (components 3.6.1 build breaks with primereact/@primereact/styles 11.2.0 (password renamed to inputpassword) #375)Changed
publish.ymlon this branch is dispatch-only. It publishes a new 3.x version under thev3-ltsdist-tag, verifies that npmlatestdid not move, and pushes a plain git tag without a GitHub release. Publishing skips packages already on the registry, so a re-run continues a partial release. The job that runs third-party code cannot write to the repository. (Add a safe release path for Components 3.x maintenance fixes #379)publish-versionrefuses to publish without a non-latestdist-tag. (Add a safe release path for Components 3.x maintenance fixes #379)yarn.lock, and its pull-request CI installs it with--immutable. (Add a safe release path for Components 3.x maintenance fixes #379)