Skip to content

Honor caller SDK pins in package updates #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woksin merged 1 commit into from
Oct 1, 2026
Merged

Honor caller SDK pins in package updates #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/scripts/tests/update-packages.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,13 @@ def shell(name):


class UpdatePackagesTests(unittest.TestCase):
def test_setup_installs_caller_sdk_pin_without_changing_selection_policy(self):
setup = STEPS["Setup .NET"]
self.assertIn("dotnet-version: ${{ env.DOTNET_VERSION }}", setup)
self.assertIn("global-json-file: ${{ hashFiles('global.json') != '' && 'global.json' || '' }}", setup)
self.assertIn("DOTNET_INSTALL_DIR:", setup)
self.assertNotRegex(SOURCE, r"(?:rm|mv|sed|jq) .*global[.]json")

def setUp(self):
self.temp = tempfile.TemporaryDirectory(prefix="update-packages-")
self.addCleanup(self.temp.cleanup)
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/update-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ jobs:
DOTNET_INSTALL_DIR: ${{ runner.environment == 'self-hosted' && format('{0}/dotnet', runner.temp) || '' }}
with:
dotnet-version: ${{ env.DOTNET_VERSION }}
# setup-dotnet installs both versions when both inputs are present. The
# latest SDK alone cannot satisfy an exact pin or an older feature band.
# Keep the caller's roll-forward policy; never rewrite global.json.
global-json-file: ${{ hashFiles('global.json') != '' && 'global.json' || '' }}

- name: Setup Node.js
if: steps.detect.outputs.update_npm == 'true'
Expand Down
Loading