Compute and use WGS84 height where appropriate#462
Open
Cybis320 wants to merge 13 commits intoprereleasefrom
Open
Compute and use WGS84 height where appropriate#462Cybis320 wants to merge 13 commits intoprereleasefrom
Cybis320 wants to merge 13 commits intoprereleasefrom
Conversation
Contributor
Author
|
@dvida, When you have a chance, can you take a look at this? It adds a config.height_wgs84 and a platepar.height_wgs84. |
Contributor
|
Is there any work to be done on this yet, is it good to merge? |
Contributor
Author
I haven't looked at this in a while. Let me do some fresh testing but It'd be nice to have for the work we are currently doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR computes and utilizes WGS84 height when necessary. It introduces a config.wgs84_height variable, which is calculated from config.elevation. Additionally, it updates the shower association to incorporate the WGS84 height. However, there’s still work to be done on precomputing the pp wgs84_ht.