Repository navigation
Require YAML CI validation in Copilot instructions - #10
Merged
Merged
Conversation
Co-authored-by: tormachris <1529569+tormachris@users.noreply.github.com>
Co-authored-by: tormachris <1529569+tormachris@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Copilot instructions to require running the same YAML validation steps used by CI after any YAML modifications, ensuring AI-assisted changes don’t skip lint parity.
Changes:
- Add a “Required YAML Validation” completion gate to
.github/copilot-instructions.mdwith the exact CI-parity commands and a requirement to fix/rerun until clean. - Normalize YAML document end markers (
...) in TACACS-related YAML files (no functional behavior change).
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tacacs.yaml | Normalizes YAML document end marker (...). |
| roles/tacacs/tasks/main.yaml | Normalizes YAML document end marker (...). |
| roles/tacacs/meta/main.yaml | Normalizes YAML document end marker (...). |
| roles/tacacs/handlers/main.yaml | Normalizes YAML document end marker (...). |
| roles/tacacs/defaults/main.yaml | Normalizes YAML document end marker (...). |
| .github/copilot-instructions.md | Adds required post-YAML-change validation commands and a completion guard to match CI expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI agents could complete YAML changes without verifying they pass CI. This adds an explicit completion gate to the Copilot instructions.