Skip to content

Require YAML CI validation in Copilot instructions - #10

Merged
tormachris merged 2 commits into
mainfrom
copilot/fix-ci-failures
Aug 23, 2026
Merged

tormachris merged 2 commits into
mainfrom
copilot/fix-ci-failures

Conversation

Copilot AI commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

AI agents could complete YAML changes without verifying they pass CI. This adds an explicit completion gate to the Copilot instructions.

  • CI parity
    • Require repository-wide validation after any YAML change:
      ansible-galaxy collection install -r requirements.yaml
      yamllint ./
      ansible-lint ./
  • Completion guard
    • Require agents to fix all findings and rerun both linters successfully before finishing.

Copilot AI and others added 2 commits August 23, 2026 08:48
Co-authored-by: tormachris <1529569+tormachris@users.noreply.github.com>
Co-authored-by: tormachris <1529569+tormachris@users.noreply.github.com>
@tormachris
tormachris marked this pull request as ready for review August 23, 2026 08:55
Copilot AI lite review requested due to automatic review settings August 23, 2026 08:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Copilot instructions to require running the same YAML validation steps used by CI after any YAML modifications, ensuring AI-assisted changes don’t skip lint parity.

Changes:

  • Add a “Required YAML Validation” completion gate to .github/copilot-instructions.md with the exact CI-parity commands and a requirement to fix/rerun until clean.
  • Normalize YAML document end markers (...) in TACACS-related YAML files (no functional behavior change).

Reviewed changes

Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tacacs.yaml Normalizes YAML document end marker (...).
roles/tacacs/tasks/main.yaml Normalizes YAML document end marker (...).
roles/tacacs/meta/main.yaml Normalizes YAML document end marker (...).
roles/tacacs/handlers/main.yaml Normalizes YAML document end marker (...).
roles/tacacs/defaults/main.yaml Normalizes YAML document end marker (...).
.github/copilot-instructions.md Adds required post-YAML-change validation commands and a completion guard to match CI expectations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tormachris
tormachris merged commit 40ee931 into main Aug 23, 2026
5 checks passed
@tormachris
tormachris deleted the copilot/fix-ci-failures branch August 23, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants