Fix potential NullPointerException in passenger packet sending and NoSuchElementException in location-drift command - #75
Open
Spagles wants to merge 2 commits into
Open
Fix potential NullPointerException in passenger packet sending and NoSuchElementException in location-drift command#75Spagles wants to merge 2 commits into
Spagles wants to merge 2 commits into
Conversation
…t element in location-drift command
|
|
Owner
|
This should really be 2 different PRs but I get that they're very small fixes so I'll ignore that. Can PacketEvents User ever be null without something being very broken? If it's a sign that something's gone catastrophically wrong, I'd rather not band-aid over it. Since you said |
Cubicake
reviewed
Aug 1, 2026
| PlayerData playerData = PlayerRegistry.getInstance().getPlayerData(player.getUniqueId()); | ||
| Entity closestEntity = player.getNearbyEntities(10,10,10).getFirst(); | ||
| if (closestEntity == null) return; | ||
| var nearbyEntities = player.getNearbyEntities(10,10,10); |
Cubicake
reviewed
Aug 1, 2026
| Entity closestEntity = player.getNearbyEntities(10,10,10).getFirst(); | ||
| if (closestEntity == null) return; | ||
| var nearbyEntities = player.getNearbyEntities(10,10,10); | ||
| if (nearbyEntities.isEmpty()) return; |
Owner
There was a problem hiding this comment.
Also, if this is going to be handled correctly instead of erroring, the player should be notified about why it failed
Cubicake
requested changes
Aug 2, 2026
Owner
|
Are you going to update this PR or should I close it? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoSuchElementExceptionwhen executing/raycastedantiesp test location-driftwithout any nearby entities present by checkingisEmpty()before callinggetFirst().NullPointerExceptioninsendEntityPassengerPacketwhen resolving a disconnected or null PacketEventsUserchannel, delegating packet writing toCOMMON.writeIfPresent.