Repository navigation
Conversation
Pin all third-party GitHub Actions to commit SHAs, add dependabot config to keep them updated, and sign build provenance attestations for container images. Also guard the release workflow so pre-releases and tags not merged into main cannot publish/overwrite the :latest image.
- Auth:AppRoleTableName lists, per tenant id, the roles that tenant may grant - Token roles count only when the table trusts the token's tid, and authorise without an allowedUsers row
- Setup wizard offers Restricted Multi-Tenant with a list of other tenant IDs - Multi-tenant apps with an allow-list set WEBSITE_AUTH_AAD_ALLOWED_TENANTS to the setup tenant plus that list - Setup:AllowedTenants now feeds the same list
Zacgoose
changed the title
JohnDuprey
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for Azure Entra app roles with per-tenant allow-lists, enhancing role-based authorization for multi-tenant scenarios. It also improves CI/CD security and traceability by pinning GitHub Actions to specific commit SHAs and adding build provenance attestations. Additionally, several configuration and code quality improvements are included.
Authorization and App Role Enhancements:
rolesclaims are now honored only if the issuing tenant is explicitly trusted via a new allow-list table (AppRoleTableName). This prevents unauthorized tenants from granting themselves roles. (Services/Auth/AuthService.cs,Services/Configuration/AuthSettings.cs,Services/Auth/EasyAuthPrincipal.cs,Services/Hosting/CraftAuthMiddleware.cs) [1] [2] [3] [4] [5] [6] [7] [8]EasyAuthClaimsto extract and carryTenantId(tid) andRolesfrom tokens, and updated the principal normalization flow to leverage these new claims for role resolution. (Services/Auth/EasyAuthPrincipal.cs,Services/Hosting/CraftAuthMiddleware.cs) [1] [2] [3] [4] [5]Configuration and Setup Improvements:
AppRoleTableNamesetting to configure the trusted tenants/roles table, and improved documentation forAllowedTenantsto clarify multi-tenant behavior. (Services/Configuration/AuthSettings.cs,Services/Configuration/SetupSettings.cs) [1] [2]CI/CD Security and Traceability:
.github/workflows/dev-container.yml,.github/workflows/release-container.yml) [1] [2] [3] [4] [5] [6].github/workflows/dev-container.yml,.github/workflows/release-container.yml) [1] [2]dependabot.ymlconfiguration to enable automated dependency update tracking for GitHub Actions. (.github/dependabot.yml)These changes collectively improve both the security posture and flexibility of the authentication and deployment pipelines.