Conversation
When analyzing a target interpreter, the path-detection subprocess honored parent PYTHON* variables (notably PYTHONPATH), so packages visible only to the caller could appear in the SBOM. Add opt-in --isolated, which probes the target with python -E (same pattern as existing -S). Default behavior is unchanged. Prefer -E over -I so user-site packages remain discoverable. The flag only applies when a target <python> is given. Signed-off-by: Julio César Suástegui <juliosuas@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ 0 (≤ 20 complexity) |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1045.
cyclonedx-py environment <python>discovers the target interpreter'ssys.pathvia a subprocess. That subprocess previously honored parentPYTHON*variables (notablyPYTHONPATH), so packages visible only to the caller could appear in the SBOM as if installed in the scanned environment.Maintainers confirmed that inheriting the parent environment is intentional for some workflows and asked for an opt-in flag rather than changing the default.
This change adds
--isolated, which probes the target interpreter withpython -E(same insertion pattern as existing-S) soPYTHON*variables are ignored by the documented interpreter mechanism. Default behavior is unchanged. The flag only applies when a target<python>is given.Regression covered by
TestCliEnvironment.test_isolated_ignores_parent_pythonpath.Resolves or fixes issue:
#1045AI Tool Disclosure
[Cursor agent][Cursor agent (model not recorded); drafting only; every line human-reviewed][Implement opt-in --isolated for environment path detection per issue #1045 and maintainer guidance (use python -E; keep default inheritance; add regression test and docs); human-reviewed before opening]Affirmation