removed force/check option for put_block#702
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
=======================================
Coverage 32.35% 32.35%
=======================================
Files 215 215
Lines 36363 36359 -4
Branches 14597 14593 -4
=======================================
Hits 11764 11764
+ Misses 22659 22655 -4
Partials 1940 1940 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This breaks Python API. I suggest deprecate the API first if we are not planning to release version 2. |
Since there is no use case for this (see #501), I do not think than this option was really used. If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated? |
The function signature is changed. If someone use it, their code will be broken.
You can refer how popular packages did or #672. |
Fixes #501