Copy the input slice in helper.SliceStringRemove()#8
Open
particleflux wants to merge 1 commit intoDBX12:masterfrom
Open
Copy the input slice in helper.SliceStringRemove()#8particleflux wants to merge 1 commit intoDBX12:masterfrom
helper.SliceStringRemove()#8particleflux wants to merge 1 commit intoDBX12:masterfrom
Conversation
The previous version did, while returning a separate slice as output, also modify the original input slice. Deleting an element there then led to empty strings in the "unload --all" loop, when the loop slice `args` was implicitly modified. Solved by copying the input slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version did, while returning a separate slice as output, also modify the original input slice. Deleting an element there then led to empty strings in the "unload --all" loop, when the loop slice
argswas implicitly modified.This, in the end, lead to errors on
unload --allwhen attempting to delete profiles named"".e.g.:
Solved by copying the input slice.