Skip to content

CYA summary labels should not consider the error description #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidjamesstone merged 2 commits into from
Jun 17, 2026
Merged

CYA summary labels should not consider the error description #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c64ea3
CYA summary labels should not coinsider the error description
davidjamesstone Jun 17, 2026
c6abbab
Use summaryLabel on the payment fields
davidjamesstone Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/server/plugins/engine/components/FormComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export class FormComponent extends ComponentBase {
type: FormComponentsDef['type']
hint: FormComponentsDef['hint']
label: string
summaryLabel: string

isFormComponent = true
isAppendageStateSingleObject = false
Expand All @@ -46,13 +47,18 @@ export class FormComponent extends ComponentBase {
this.hint = hint

this.label = this.getLabel(def)
this.summaryLabel = this.getSummaryLabel(def)
}

getLabel(def: FormComponentsDef) {
if ('errorDescription' in def && def.errorDescription) {
return def.errorDescription
}

return this.getSummaryLabel(def)
}

getSummaryLabel(def: FormComponentsDef) {
if ('shortDescription' in def && def.shortDescription) {
return def.shortDescription
}
Expand Down
4 changes: 2 additions & 2 deletions src/server/plugins/engine/models/SummaryViewModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ export function ItemField(
label: field.title,
title:
field.options.required === false
? `${field.label} (optional)`
: field.label,
? `${field.summaryLabel} (optional)`
: field.summaryLabel,
error: field.getFirstError(options.errors),
value: getAnswer(field, state),
href: getPageHref(page, options.path, {
Expand Down
2 changes: 1 addition & 1 deletion src/server/plugins/engine/pageControllers/SummaryPageController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ function getPaymentFieldItems(
name: field.name,
page,
title: field.title,
label: field.label,
label: field.summaryLabel,
field,
state: context.state,
href: page.href,
Expand Down
Loading