Conversation
|
@dk18q074 Do you know how to preview this PR so you can check whether this is the output you wanted? |
There was a problem hiding this comment.
Pull request overview
Updates the site layout and event presentation by removing the homepage sidebar, moving “Events” into the top navbar, and splitting the homepage Events listing into upcoming vs. past (collapsed by default) with a scheduled build to keep the split current.
Changes:
- Hide the sidebar on the homepage and add an “Events” link to the top navbar.
- Split Events into “upcoming” and “past” listings on the homepage (past hidden by default) using a Quarto
pre-renderPython script. - Add a daily GitHub Actions schedule to rebuild/publish the site so the event split stays up to date.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
index.qmd |
Disables sidebar on home; replaces single Events listing with upcoming + collapsible past listing. |
_quarto.yml |
Adds pre-render hook and moves Events link from sidebar to navbar. |
scripts/split-events.py |
New pre-render script to generate upcoming-events.yml and past-events.yml. |
pyproject.toml |
Adds pyyaml dependency for the pre-render script. |
uv.lock |
Locks updated Python dependencies (adds PyYAML). |
.gitignore |
Ignores generated upcoming-events.yml / past-events.yml. |
.github/workflows/quarto-publish.yml |
Adds scheduled daily run for publish workflow. |
content/events/im_dialog/2023-linked-open-data-in-dialogue/index.qmd |
Frontmatter/formatting adjustments to an event page. |
.github/copilot-instructions.md |
Adds repository-specific Copilot guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WalkthroughAdds a Quarto pre-render event splitter and generated YAML listings, updates the homepage to consume those listings, tweaks site/nav config, schedules CI runs, adds repository documentation, and introduces related gitignore and Python dependency changes. Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content/events/im_dialog/2023-linked-open-data-in-dialogue/index.qmd`:
- Around line 1-6: This event page's YAML frontmatter is missing the categories
field required by the pre-render split-events.py script so the page is skipped;
add a categories: [Event] entry to the existing frontmatter block (alongside
title, subtitle, date, lang) so the script can recognize it as an Event.
In `@scripts/split-events.py`:
- Around line 16-19: The frontmatter parsing block that checks if not
text.startswith("---") and then does end = text.index("---", 3) can raise
ValueError for malformed files; change it to safely detect a closing delimiter
(e.g., use text.find("---", 3) and check for -1) or wrap the index call in
try/except ValueError, and return None when the closing marker is missing so
yaml.safe_load(text[3:end]) is only called for well-formed frontmatter.
- Around line 51-53: The normalization of event_date using
date.fromisoformat(event_date) can raise ValueError for non-ISO strings (e.g.,
"2025.04.02"); wrap the conversion in a try/except around the existing
date.fromisoformat call (the event_date variable) and attempt fallback parsing
(e.g., try datetime.strptime(event_date, "%Y.%m.%d") and/or replace '.' with '-'
and retry date.fromisoformat) to produce a date object, and if all parses fail
log a warning and skip or set event_date to None so the script doesn't crash.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: be9e3ca6-ca3e-4d51-9d48-e4134e4fab52
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.github/copilot-instructions.md.github/workflows/quarto-publish.yml.gitignore_quarto.ymlcontent/events/im_dialog/2023-linked-open-data-in-dialogue/index.qmdindex.qmdpyproject.tomlscripts/split-events.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
content/events/im_dialog/2023-linked-open-data-in-dialogue/index.qmd (1)
42-46: Consider normalizing the project presentation list style.This block mixes one inline project entry with a bulleted list, which can render inconsistently. Using a single list style for all project items would improve readability.
Proposed markdown cleanup
-**11:30 – 12:30 – Project Presentations** - *The MURELCO Seminar – A Teaching Tool* — Matthieu Gillabert & Stephen Hart\ -- *The Processetti Inquiries (16th–17th c.)* — David Knecht\ -- *Switzerland and Beyond* — Tobias Hodel\ -- *Diaries of Anna Maria Preiswerk-Iselin* — Morgane Pica\ -- *OntoME – Ontology Management Environment* — Vincent Alamercery +**11:30 – 12:30 – Project Presentations**\ +- *The MURELCO Seminar – A Teaching Tool* — Matthieu Gillabert & Stephen Hart\ +- *The Processetti Inquiries (16th–17th c.)* — David Knecht\ +- *Switzerland and Beyond* — Tobias Hodel\ +- *Diaries of Anna Maria Preiswerk-Iselin* — Morgane Pica\ +- *OntoME – Ontology Management Environment* — Vincent Alamercery🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@content/events/im_dialog/2023-linked-open-data-in-dialogue/index.qmd` around lines 42 - 46, The "11:30 – 12:30 – Project Presentations" block mixes an inline entry with a bulleted list which causes inconsistent rendering; change all project entries to a single list style by converting the inline entry ("**11:30 – 12:30 – Project Presentations** - *The MURELCO Seminar – A Teaching Tool* — Matthieu Gillabert & Stephen Hart") into a top-level heading or bold time line followed by a consistent bullet list containing each project item (e.g., "The MURELCO Seminar – A Teaching Tool — Matthieu Gillabert & Stephen Hart", "The Processetti Inquiries (16th–17th c.) — David Knecht", etc.) so every project is rendered as a list item under the "11:30 – 12:30 – Project Presentations" label.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@content/events/im_dialog/2023-linked-open-data-in-dialogue/index.qmd`:
- Around line 42-46: The "11:30 – 12:30 – Project Presentations" block mixes an
inline entry with a bulleted list which causes inconsistent rendering; change
all project entries to a single list style by converting the inline entry
("**11:30 – 12:30 – Project Presentations** - *The MURELCO Seminar – A Teaching
Tool* — Matthieu Gillabert & Stephen Hart") into a top-level heading or bold
time line followed by a consistent bullet list containing each project item
(e.g., "The MURELCO Seminar – A Teaching Tool — Matthieu Gillabert & Stephen
Hart", "The Processetti Inquiries (16th–17th c.) — David Knecht", etc.) so every
project is rendered as a list item under the "11:30 – 12:30 – Project
Presentations" label.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ce188805-d7f7-4931-a229-7d4bcf09db24
📒 Files selected for processing (2)
content/events/im_dialog/2023-linked-open-data-in-dialogue/index.qmdscripts/split-events.py
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts/split-events.py
Pull request
Proposed changes
There are layout changes that I did here: The sidebar is now invisible on the Home page. For that reason I added the Events to the top navbar. The most notable change is the Events: They are now split into current and past events with the past events being hidden by default. I've also added a daily build cron job in order to keep this list correct.
Types of changes
Checklist
Summary by CodeRabbit
New Features
Improvements
Documentation
Chores