Add fieldnames inplace of placeholders in CAERadioTrackManager.h - #325
Add fieldnames inplace of placeholders in CAERadioTrackManager.h#325abums1210 wants to merge 8 commits into
Conversation
Radio modifications can make use of the fields - including one of mine.
|
Why not name all members? These are defined in reversed project. |
|
Okay will work on that. |
|
There is also tools\run_code_verification.cmd you can run locally. |
Oh. Thanks. Fixed the validation issue though. Took me a while to understand that I shouldn't leave gaps between them. |
|
You introduced breaking changes without mentioning them in readme file. |
I checked the readme file and it has version number. Do we need to include that in a pull request? I thought version numbers are updated are merging stuff. |
|
Version number will be next one obviously. Date you can put tomorrow. It is just coarse info to navigate in commits history.. |
I added one. Not sure if its okay. |
|
Nah, you document every single renamed member (that was not field_x before). X renamed to Y. |
Hmm I never intended to do this anyway but you gave the idea after initial commit. Anyway I added the details you requested. |
|
Nice. Thanks. |
Funny thing is while trying to refactor classic axis mod of _AG to latest SDK, I did the same detective work. It's good we keep track of stuff like that now. |
Radio modifications can make use of the field names - including one of mine.