Skip to content

Add fieldnames inplace of placeholders in CAERadioTrackManager.h - #325

Open
abums1210 wants to merge 8 commits into
DK22Pac:masterfrom
abums1210:CAEAudioTrackManager
Open

Add fieldnames inplace of placeholders in CAERadioTrackManager.h#325
abums1210 wants to merge 8 commits into
DK22Pac:masterfrom
abums1210:CAEAudioTrackManager

Conversation

@abums1210

Copy link
Copy Markdown
Contributor

Radio modifications can make use of the field names - including one of mine.

Radio modifications can make use of the fields - including one of mine.
@MiranDMC

MiranDMC commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Why not name all members? These are defined in reversed project.

@abums1210

Copy link
Copy Markdown
Contributor Author

Okay will work on that.

@abums1210 abums1210 changed the title Add fieldnames inplace of placeholders in CAEAudioTrackManager.h Add fieldnames inplace of placeholders in CAERadioTrackManager.h Aug 9, 2026
@abums1210
abums1210 marked this pull request as draft August 9, 2026 11:49
@MiranDMC

MiranDMC commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

There is also tools\run_code_verification.cmd you can run locally.

@abums1210

abums1210 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

There is also tools\run_code_verification.cmd you can run locally.

Oh. Thanks. Fixed the validation issue though. Took me a while to understand that I shouldn't leave gaps between them.
The another error is from the IV header you just fixed.

@MiranDMC

MiranDMC commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

You introduced breaking changes without mentioning them in readme file.
Giving names to field_x is fine but renaming m_nMonthDay will break some mods.

@abums1210

Copy link
Copy Markdown
Contributor Author

You introduced breaking changes without mentioning them in readme file. Giving names to field_x is fine but renaming m_nMonthDay will break some mods.

I checked the readme file and it has version number. Do we need to include that in a pull request? I thought version numbers are updated are merging stuff.

@abums1210
abums1210 marked this pull request as ready for review August 9, 2026 12:30
@MiranDMC

MiranDMC commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Version number will be next one obviously. Date you can put tomorrow. It is just coarse info to navigate in commits history..

@abums1210

Copy link
Copy Markdown
Contributor Author

Version number will be next one obviously. Date you can put tomorrow. It is just coarse info to navigate in commits history..

I added one. Not sure if its okay.

@MiranDMC

MiranDMC commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Nah, you document every single renamed member (that was not field_x before). X renamed to Y.
If you think it is too much work then don't change names at all.
That's entire point of breaking changes readme.

@abums1210

Copy link
Copy Markdown
Contributor Author

Nah, you document every single renamed member (that was not field_x before). X renamed to Y. If you think it is too much work then don't change names at all. That's entire point of breaking changes readme.

Hmm I never intended to do this anyway but you gave the idea after initial commit. Anyway I added the details you requested.

@MiranDMC

Copy link
Copy Markdown
Contributor

Nice. Thanks.
Now somebody having compilation problems do not have to do detective work himself.

@abums1210

Copy link
Copy Markdown
Contributor Author

Nice. Thanks. Now somebody having compilation problems do not have to do detective work himself.

Funny thing is while trying to refactor classic axis mod of _AG to latest SDK, I did the same detective work. It's good we keep track of stuff like that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants