DOCS: Explain Bunny CNAME/ALIAS behavior.#4368
Conversation
| Bunny supports adding CNAME records for the root domain (`@`), but within | ||
| DNSControl the `ALIAS` record should be used. |
There was a problem hiding this comment.
I think this needs a little more explanation. Something like:
Bunny supports adding CNAME records for the root domain (@). Use the ALIAS record type and DNSControl will generate a CNAME as appropriate.
| D("example.com", REG_NONE, DnsProvider(DSP_BUNNY_DNS), | ||
| A("test", "1.2.3.4"), | ||
| ); | ||
| D('example.com', REG_NONE, DnsProvider(DSP_BUNNY_DNS), A('test', '1.2.3.4')); |
There was a problem hiding this comment.
JavaScript code should use double quotes (") for strings, not single quotes (').
See https://docs.dnscontrol.org/developer-info/styleguide-doc
There was a problem hiding this comment.
Ok, y'all have a .prettierrc file that says otherwise. Which is why this PR is so huge... you have your repo set up to use Prettier, but don't actually seem to be using it properly. Hence me having to spend time disabling and working around this. I'll probably just drop wanting to get this merged, tbh. When y'all figure out your systems set up, I'm happy to take another crack at it.
There was a problem hiding this comment.
Ah, that's certainly a contradiction! We use prettier for pkg/js/helpers.js and nothing else. We should update the style guide (or maybe change pkg/js/helpers.js to be the same as the docs?). CC @cafferata for his opinion.
There was a problem hiding this comment.
Or use a .prettierignore file to ignore the docs. Or ideally just use Prettier for the docs (you can have a separate .prettierrc in the docs dir with different settings) and eliminate all the bikeshedding...
To be clear, the huge problem right now is that because you have that .prettierrc file, Zed and VS Code and any other editor set up to respect them will reformat everything in a file when you make edits.
| You can configure Bunny's Pull Zone type with `BUNNY_DNS_PZ`. The target is the | ||
| Pull Zone ID: |
There was a problem hiding this comment.
| You can configure Bunny's Pull Zone type with `BUNNY_DNS_PZ`. The target is the | |
| Pull Zone ID: | |
| You can configure Bunny's Pull Zone type with `BUNNY_DNS_PZ`. The target is the Pull Zone ID: |
CC @cafferata Is it ok that these lines are being broken? I believe you recently unbroke lines.
3 participants
Just an addition to explain that while Bunny DNS allows root CNAMEs, here in DNSControl, you should use
ALIASand the CNAME will result. This was initially unclear to me when setting up DNSControl.