Skip to content

Use VS 2022 developer command prompt action - #252

Closed
jwillemsen wants to merge 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-use-step-security-msvc-dev-cmd
Closed

jwillemsen wants to merge 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-use-step-security-msvc-dev-cmd

Conversation

@jwillemsen

@jwillemsen jwillemsen commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Replace microsoft/setup-msbuild@v3 with step-security/msvc-dev-cmd@v1, explicitly selecting Visual Studio 2022 for the existing msbuild step.

Validation: inspected the workflow; the PR build will verify MSBuild availability and compilation.

Summary by CodeRabbit

  • Chores
    • Windows solution builds now run with the Visual Studio 2022 development environment configured. This change affects the build process only; no application features or public interfaces have changed. There are no user-facing changes to report in this release.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 66572396-aeaa-4306-8662-cec6f602fce5

📥 Commits

Reviewing files that changed from the base of the PR and between 420e247 and 9b7a6d7.

📒 Files selected for processing (1)
  • .github/workflows/windows.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The Windows workflow replaces microsoft/setup-msbuild@v3 with step-security/msvc-dev-cmd@v1, configured for Visual Studio 2022.

Changes

Windows build setup

Layer / File(s) Summary
Configure Visual Studio environment
.github/workflows/windows.yml
The workflow uses step-security/msvc-dev-cmd@v1 with Visual Studio 2022 before building the solution.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 9b7a6

The workflow retains its MSBuild build path with the VS 2022 environment configured; no actionable merge risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 9b7a6

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/windows.yml: Replaces the Setup msbuild step using microsoft/setup-msbuild@v3 with a Visual Studio 2022 environment setup using step-security/msvc-dev-cmd@v1 and vsversion: '2022'.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: using the Visual Studio 2022 developer command prompt action in the Windows workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the Windows build,
Where Visual Studio stands prepared.
The workflow sets the tools in place,
Then sends the solution on its way.
I nibble clover, pleased and glad!

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@jwillemsen jwillemsen closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant