V1 - #926
V1#926
Conversation
|
I will review by the end of the week, thanks! |
| #' #' | ||
| #' See also Details below for more information. | ||
| #' @param end_utc `r get_ogc_params("time-series-metadata")$end_utc` | ||
| #' @param end_utc Deprecated in v1. Use "end" instead. |
There was a problem hiding this comment.
Move these to the bottom, just above the dot dot dots?
|
I need help understanding something. Are I decided to try using an offset to pull data: This pulled several records with the I then tried this same offset in Am I misunderstanding something? Related: I did a quick search for an example using a time offset and didn't see one for the water data APIs. I think this would be helpful. |
|
Maybe @mikemahoney218-usgs has more details on this ^^ or where I'm going wrong. |
|
The time series metadata endpoint only updates once per day, so it generally won't have the most up-to-date information on when the most recent record is from |
| "state_name is deprecated starting in v1 of the Water Data APIs. | ||
| Use the function read_waterdata_combined_meta instead. | ||
| Reverting to v0 version of Water Data APIs." | ||
| ) |
There was a problem hiding this comment.
Is there a planned date for when they'll be removed entirely? If we have a date, might be handy to put here.
There was a problem hiding this comment.
~June, but I'm trying to thread the needle of not freaking people out about V0 (which is mostly a non-event) before WaterServices is decommissioned (which is a much bigger event) -- so we haven't announced more specifics than that yet. (I also haven't thought about it a ton yet, either)
ehinman
left a comment
There was a problem hiding this comment.
These changes look good @ldecicco-USGS. I ran some tests on them and the warnings popped up as expected with helpful information. My only optional suggestion is to move the state_name, begin_utc and end_utc inputs to the bottom of the list, so that they're less obvious.


Let's get v1 ready to roll as soon as the announcement comes out.