PEP 639 license identifier in pyproject.toml #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per: https://packaging.python.org/en/latest/guides/licensing-examples-and-user-scenarios For: https://pypi.org/project/licensecheck/ which currently shows: ┏━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━ ┃ Compatible ┃ Package ┃ License ┡━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━ │ │ ✖ │ dataretrieval │ LICENSE DOI-USGS#185
ehinman
reviewed
Dec 29, 2025
Collaborator
ehinman
left a comment
ehinman
left a comment
There was a problem hiding this comment.
I think this looks fine besides the question of whether ".md" is needed. The other question is why the python 3.8 build tests are failing with the following error:
ValueError: invalid pyproject.toml config: `project.license`.
configuration error: `project.license` must be valid exactly by one definition (2 matches found):
- keys:
'file': {type: string}
required: ['file']
- keys:
'text': {type: string}
required: ['text']
[end of output]
I will note that we removed testing of 3.8 in a recent PR. Would you mind pulling in the most recent changes to main and testing again?
| requires-python = ">=3.8" | ||
| keywords = ["USGS", "water data"] | ||
| license = {file = "LICENSE.md"} | ||
| license = "CC0-1.0" |
Collaborator
There was a problem hiding this comment.
This matches with: https://spdx.org/licenses/CC0-1.0.html
| keywords = ["USGS", "water data"] | ||
| license = {file = "LICENSE.md"} | ||
| license = "CC0-1.0" | ||
| license-files = ["LICENSE.md"] |
Collaborator
There was a problem hiding this comment.
Not sure this needs the ".md"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185