Fixing Search Bugs

[sachin-panayil]

Important

This PR depends on PR #297 and is based on its branch.
This PR will be rebased after dependent PR is merged
Do not merge until dependent PR is merged and rebase occurs

Fixing Search Bugs

Problem

Four bugs in both search pages feature affecting user experience

1. Users couldn't backspace to clear the search field completely so the last character always would persist

   • User types "AAA" in search input → User presses backspace three times → Input shows "A" instead of empty and you cant backspace further

2. Searching from page 3 would return page 3 of the new results instead of page 1

   • User searches "Smith", navigates to page 3 → User searches "Jones" → URL becomes ?query=Jones&page=3

3. Clicking a page button while the input field had changes would use the input value instead of the search query

   • User searches "Smith" → User types "Jones" in input but doesn't submit → User clicks page 2 → URL becomes ?query=Jones&page=2

4. The search button briefly showed "Searching..." when navigating between pages, even though the user wasn't initiating a new search

   • User views search results → User clicks page 2 → Button shows "Searching..."

Solution

DId some coding to fix each bug

Result

The search input now allows full clearing, new searches always start at page 1, pagination respects the committed query from the URL, and the search button only shows "Searching..." during actual search submissions and not during page navigation

Test Plan

• run make up
• recreate and check to see if bugs exists