Align DuckDB Excel API with SQLite and add DuckTools parity#14
Open
Dagalon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
XLS-Memory-Lib/DuckDbExcelFunctions.csto match SQLite (e.g.MEMORY_DB.DUCKDB.CREATE_DB(name, path),TABLES(databaseId, dependency),CREATE.TABLE(databaseId, table, range, dependency),INSERT/EXECUTE/SCALAR/QUERY(..., dependency), and addedDROP.TABLE).DuckDB-Memory-Lib/DuckTools.cs: madeDuckToolspartial, addedQuoteIdentifier,ParameterName,ResolveSql, improvedGetListTablesbehavior,DropTable,DeleteDataBase, and a generated-regex hook (MyRegex) to mirror SQLite helper capabilities.TABLE_NOT_FOUNDtoDuckDB-Memory-Lib/EnumsDuckMemory.csso DuckDB can return the same table-drop status as SQLite.README.mdto reflect the unified Excel function signatures and addedCLASS_STRUCTURE.md(Mermaid diagrams) describing package/class relationships and the aligned Excel surface.Testing
dotnet build MSBuild/MemoryDb-Lib.slnanddotnet test MSBuild/MemoryDb-Lib.slnbut both could not be executed in this environment becausedotnetis not available (automated test execution blocked).git diff --check) locally in the environment and no whitespace/patch errors were reported.Codex Task