Skip to content

feat: Ridge Stage Authoring mode in debugger (#96)#101

Merged
DaniloNovakovic merged 5 commits into
mainfrom
feat/ridge-stage-authoring-debugger
Jun 8, 2026
Merged

feat: Ridge Stage Authoring mode in debugger (#96)#101
DaniloNovakovic merged 5 commits into
mainfrom
feat/ridge-stage-authoring-debugger

Conversation

@DaniloNovakovic

Copy link
Copy Markdown
Owner

Summary

  • Adds Stage Authoring Mode to the Ridge Stage Debugger (?mode=ridge-stage-debugger) for tuning stageComposition.ts without a separate map editor: session-only draft, live preview, sidebar sliders, copyable full-replacement TS snippets, and Discard Draft / Reset Selection.
  • Supports selecting and nudging Walk Rail points (x/y), Stage Spots (railProgress, offset), and Stage Object offsets via click, target dropdown, or marker drag (Shift+drag on spots = offset-only).
  • Adds Stage Authoring Camera (free pan on empty space, snap-to-selection when off-screen, restore player follow on exit) and fixes offset slider ranges (fixed ±200 slider, ±500 input clamp).
  • Removes temporary Bridge readability pocket halos from gameplay.

Closes #96

Test plan

  • Open ?mode=ridge-stage-debugger, enable Authoring Mode, confirm player freezes and rail/spot/object markers appear
  • Click or dropdown-select rail point, spot, and object; nudge via slider/number input; confirm live preview updates
  • Drag markers in preview; Shift+drag spot for offset-only; drag empty space to pan camera
  • Copy snippet, Discard Draft, Reset Selection; confirm draft reverts correctly
  • Confirm offset sliders stay in ±200 range and inputs clamp to ±500
  • Confirm normal Ridge play (non-debugger) has no yellow readability halos
  • npm run typecheck and npm test pass

Made with Cursor

DaniloNovakovic and others added 2 commits June 8, 2026 06:15
Let Danilo tune Walk Rail points, Stage Spots, and object offsets in a
session draft with live preview, sidebar controls, and copyable source
snippets—without replacing the typed composition source as canonical data.

Co-authored-by: Cursor <cursoragent@cursor.com>
Add camera pan/focus, marker drag, and fixed offset slider ranges so authoring controls stay usable. Remove temporary Bridge readability pocket halos from gameplay.

Co-authored-by: Cursor <cursoragent@cursor.com>
@DaniloNovakovic DaniloNovakovic self-assigned this Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Stage Authoring Mode to the Ridge Stage Debugger, enabling real-time, in-debugger adjustments of spatial data (such as rail points, spots, and objects) and generating copyable source snippets. Feedback on these changes highlights a few critical improvements: resolving a visibility bug in recreateBridgeCrossingVisuals where newly created bridge objects bypass active beat visibility rules, using stable serialized keys in the target selection dropdown to prevent DOM churn during dragging, and guarding against a potential crash in RidgeScene by safely accessing pointer.event?.shiftKey.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/game/scenes/ridge/bridge/BridgeTracerStageRuntime.ts
Comment thread src/dev/ridgeStageDebugger/components/AuthoringPanel.tsx Outdated
Comment thread src/dev/ridgeStageDebugger/components/AuthoringPanel.tsx
Comment thread src/game/scenes/ridge/runtime/RidgeScene.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 075d26cf91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/game/scenes/ridge/bridge/BridgeTracerStageRuntime.ts Outdated
Comment thread src/game/scenes/ridge/runtime/RidgeScene.ts
DaniloNovakovic and others added 3 commits June 8, 2026 06:47
Extract shared side-view keyboard bindings, dedupe toy-car placement, and refresh health/dupes baselines for new authoring complexity.

Co-authored-by: Cursor <cursoragent@cursor.com>
Reapply bridge visibility after crossing rebuild, sync interaction targets with authored spots, stabilize authoring target dropdown keys, and guard pointer shiftKey access.

Co-authored-by: Cursor <cursoragent@cursor.com>
Use placement signatures to avoid redundant bridge rebuilds during drags,
extract the authoring pointer FSM, dedupe selection helpers, and drop the
stale ridgeDevControls snapshot in favor of the live getter.

Co-authored-by: Cursor <cursoragent@cursor.com>
@DaniloNovakovic DaniloNovakovic merged commit e16e069 into main Jun 8, 2026
1 check passed
@DaniloNovakovic DaniloNovakovic deleted the feat/ridge-stage-authoring-debugger branch June 8, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add visual tweaking affordances to Ridge Stage Debugger

1 participant