Open
Conversation
* fix nav selector: ".nav" -> "nav" (tag not class) * sync page title and re-init mermaid after swap * move middleware registration to prepare (fix load-time crash) * add LiveReload + Middleware specs (14 examples) * update approval files for new config/cli option * document live_reload in README
Owner
|
Thanks. There are issues with this PR that need addressing before I can decide if I want to merge it.
Even if all these are fixed, I am still not sure I want to merge - there is more overhead than I am comfortable with, but if the above is fixed, I can at least start to evaluate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds WebSocket-based live reload support (edited, deleted, created)
What's included
listengem to watch andfaye-websocketto push changes/_live_reload.maincontent andnavsidebarlive_reload: trueby default, disable with--no-live-reloadorlive_reload: falsein.madness.yml