Skip to content
Merged

x #96

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/qodana_code_quality.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Qodana
on:
workflow_dispatch:
pull_request:
push:
branches: # Specify your branches here
- main # The 'main' branch
- 'releases/*' # The release branches

jobs:
qodana:
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
checks: write
Comment on lines +11 to +16
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Workflow permissions are broader than necessary for a read-only analysis job.

These permissions let the job modify repo contents and PRs. If Qodana doesn’t need to push commits or edit PR descriptions, consider reducing to contents: read plus only the minimal pull-requests/checks permissions required by its integration. This limits impact if the workflow or an action is compromised.

Suggested change
qodana:
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
checks: write
qodana:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: read
checks: write

steps:
- uses: actions/checkout@v3
with:
Comment thread
DarkModder33 marked this conversation as resolved.
ref: ${{ github.event.pull_request.head.sha }} # to check out the actual pull request commit, not the merge commit
fetch-depth: 0 # a full history is required for pull request analysis
Comment on lines +18 to +21
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Using github.event.pull_request.head.sha will fail on push and workflow_dispatch events where pull_request is undefined.

This expression is only defined for pull_request events; for push and workflow_dispatch it will be empty and likely break the job. You can either restrict this to PRs with if: github.event_name == 'pull_request' on the step, or fall back to the default SHA with something like ${{ github.event.pull_request.head.sha || github.sha }} so all triggers work.

- name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3
with:
pr-mode: false
env:
QODANA_TOKEN: ${{ secrets.QODANA_TOKEN_1287543422 }}
QODANA_ENDPOINT: 'https://qodana.cloud'
10 changes: 10 additions & 0 deletions qodana.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
####################################################################################################################
# WARNING: Do not store sensitive information in this file, as its contents will be included in the Qodana report. #
####################################################################################################################

version: "1.0"
linter: jetbrains/qodana-jvm:2025.3
profile:
name: qodana.recommended
include:
- name: CheckDependencyLicenses
Loading