Remove socket when overmind process is stopped.#203
Open
henrikbjorn wants to merge 1 commit intoDarthSim:masterfrom
Open
Remove socket when overmind process is stopped.#203henrikbjorn wants to merge 1 commit intoDarthSim:masterfrom
henrikbjorn wants to merge 1 commit intoDarthSim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #186 by cleaning up the socket when the overmind process is stopped.
It dosen't seem to be any tests in the repo so I tested it manually with the following
ProcfileThen verifying the socket is present, and after ctrl+c that it is gone.