flashrom.c: Fail immediately when trying to write/erase wp regions by m-iwanicki · Pull Request #17 · Dasharo/flashrom

m-iwanicki · 2024-12-05T21:16:10Z

write_protect_check can be deleted and PR0 check will still happen but only one region at a time, so if we write/erase multiple regions (e.g. -i fd -i bios) then first region might get written if it is read-write.

In case of e.g. FREG1: BIOS region (0x00580000-0x00ffffff) is read-write. & PR0: Warning: 0x00b00000-0x00ffffff is read-only. write/erase would still fail even if we tried to flash only unprotected parts of region e.g. 0x00580000-0x00590000

To force write/erase add --force argument.

meson test:

# meson test -C builddir
ninja: Entering directory `/flashrom/builddir'
ninja: no work to do.
1/1 cmocka test flashrom        OK              1.47s

Ok:                 1
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            0
Timeout:            0

Full log written to /flashrom/builddir/meson-logs/testlog.txt

Tested on Protectli VP6670:

Try to flash whole chip:

bash-5.2# flashrom -p internal -w backup.rom
flashrom 1.5.0-devel (git:v1.2-1579-gc50d797f) on Linux 6.6.21-yocto-standard (x86_64)
flashrom is free software, get the source code at https://flashrom.org

coreboot table found at 0x76a14000.
Found chipset "Intel Alder Lake-P".
Enabling flash write... Warning: BIOS region SMM protection is enabled!
Warning: Setting BIOS Control at 0xdc from 0xaa to 0x89 failed.
New value is 0xaa.
SPI Configuration is locked down.
FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-write.
FREG1: BIOS region (0x00580000-0x00ffffff) is read-write.
FREG2: Management Engine region (0x00001000-0x003aefff) is read-write.
PR0: Warning: 0x00b00000-0x00ffffff is read-only.
At least some flash regions are write protected. For write operations,
you should use a flash layout and include only writable regions. See
manpage for more details.
PROBLEMS, continuing anyway
Found Macronix flash chip "MX25L12805D" (16384 kB, Programmer-specific) on internal.
===
This flash part has status UNTESTED for operations: WP
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom@flashrom.org if any of the above operations
work correctly for you with this flash chip. Please include the flashrom log
file for all operations you tested (see the man page for details), and mention
which mainboard or programmer you tested in the subject line.
You can also try to follow the instructions here:
https://www.flashrom.org/contrib_howtos/how_to_mark_chip_tested.html
Thanks for your help!
check_for_unwritable_regions: cannot write/erase inside BIOS region (0x580000..0xffffff).
Requested regions are write protected. Aborting.

Try to flash protected part:

bash-5.2# flashrom -p internal --ifd -i bios -w backup.rom
(...)
Reading ich descriptor... done.
Using region: "bios".
check_for_unwritable_regions: cannot write/erase inside BIOS region (0x580000..0xffffff).
Requested regions are write protected. Aborting.

Try to flash unprotected part:

bash-5.2# flashrom -p internal --ifd -i fd -w backup.rom
(...)
Reading ich descriptor... done.
Using region: "fd".
Reading old flash chip contents... done.
Erase/write done from 0 to fff

WP protection checked with dummy programmer:

unprotected part:

# builddir/flashrom -p dummy:hwwp=yes,emulate=S25FL128L --wp-enable --wp-range 0x00040000,0x00fc0000 -l <(echo '00000000:0003ffff part1') -i part1 -E
flashrom 1.5.0-devel (git:v1.2-1579-gc50d797f79df) on Linux 6.11.10-300.fc41.x86_64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using region: "part1".
Found Spansion flash chip "S25FL128L" (16384 kB, SPI) on dummy.
===
This flash part has status UNTESTED for operations: WP
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom@flashrom.org if any of the above operations
work correctly for you with this flash chip. Please include the flashrom log
file for all operations you tested (see the man page for details), and mention
which mainboard or programmer you tested in the subject line.
You can also try to follow the instructions here:
https://www.flashrom.org/contrib_howtos/how_to_mark_chip_tested.html
Thanks for your help!
Enabled hardware protection
Activated protection range: start=0x00040000 length=0x00fc0000 (upper 63/64)
Failed to unlock flash status reg with wp support.
Unsetting lock bit(s) failed.
Erase/write done from 0 to 3ffff

Protected part:

# builddir/flashrom -p dummy:hwwp=yes,emulate=S25FL128L --wp-enable --wp-range 0x00040000,0x00fc0000 -l <(echo '00000000:0004ffff part1') -i part1 -E
flashrom 1.5.0-devel (git:v1.2-1579-gc50d797f79df) on Linux 6.11.10-300.fc41.x86_64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using region: "part1".
Found Spansion flash chip "S25FL128L" (16384 kB, SPI) on dummy.
===
This flash part has status UNTESTED for operations: WP
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom@flashrom.org if any of the above operations
work correctly for you with this flash chip. Please include the flashrom log
file for all operations you tested (see the man page for details), and mention
which mainboard or programmer you tested in the subject line.
You can also try to follow the instructions here:
https://www.flashrom.org/contrib_howtos/how_to_mark_chip_tested.html
Thanks for your help!
Enabled hardware protection
Activated protection range: start=0x00040000 length=0x00fc0000 (upper 63/64)
Requested regions are write protected. Aborting.
Your flash chip is in an unknown state.
Please report this to the mailing list at flashrom@flashrom.org or
on IRC (see https://www.flashrom.org/Contact for details), thanks!

mkopec · 2024-12-06T11:40:11Z

In case of e.g. FREG1: BIOS region (0x00580000-0x00ffffff) is read-write. & PR0: Warning: 0x00b00000-0x00ffffff is read-only. write/erase would still fail even if we tried to flash only unprotected parts of region e.g. 0x00580000-0x00590000

Can you change this so that only attempting to flash the actually protected ranges will throw an error? For example if someone has WP_RO protected but only wants to flash RW_SECTION_*

m-iwanicki · 2024-12-06T18:34:28Z

Tests

@mkopec
Tests were made on the same Protectli as before

Flash regions

bash-5.2# flashrom -p internal
flashrom 1.5.0-devel (git:v1.2-1581-g4dc3fa98) on Linux 6.6.21-yocto-standard (x86_64)
flashrom is free software, get the source code at https://flashrom.org

coreboot table found at 0x76a14000.
Found chipset "Intel Alder Lake-P".
Enabling flash write... Warning: BIOS region SMM protection is enabled!
Warning: Setting BIOS Control at 0xdc from 0xaa to 0x89 failed.
New value is 0xaa.
SPI Configuration is locked down.
FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-write.
FREG1: BIOS region (0x00580000-0x00ffffff) is read-write.
FREG2: Management Engine region (0x00001000-0x003aefff) is read-write.
PR0: Warning: 0x00b00000-0x00ffffff is read-only.

Layout file:

bash-5.2# cat layout
00000000:00000fff freg0
00580000:005fffff rw_bios
00a00000:00bfffff rw_r_bios
00c00000:00cfffff r_bios

Try to flash range that's partially protected

bash-5.2# flashrom -p internal -l layout -i rw_r_bios -w backup.rom
flashrom 1.5.0-devel (git:v1.2-1581-g4dc3fa98) on Linux 6.6.21-yocto-standard (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using region: "rw_r_bios".
(...)
Requested regions are write protected. Aborting.

Try to flash range that's fully protected

bash-5.2# flashrom -p internal -l layout -i r_bios -w backup.rom
flashrom 1.5.0-devel (git:v1.2-1581-g4dc3fa98) on Linux 6.6.21-yocto-standard (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using region: "r_bios"
(...)
Requested regions are write protected. Aborting.

Try to flash 2 ranges one unprotected and one protected

bash-5.2# flashrom -p internal -l layout -i rw_bios -i r_bios -w backup.rom
flashrom 1.5.0-devel (git:v1.2-1581-g4dc3fa98) on Linux 6.6.21-yocto-standard (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using regions: "r_bios", "rw_bios".
(...)
Requested regions are write protected. Aborting.

Try to flash 2 ranges in different regions one unprotected and one protected

bash-5.2# flashrom -p internal -l layout -i freg0 -i r_bios -w backup.rom
flashrom 1.5.0-devel (git:v1.2-1581-g4dc3fa98) on Linux 6.6.21-yocto-standard (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using regions: "r_bios", "freg0".
(...)
Requested regions are write protected. Aborting.

Try to flash unprotected part of BIOS region.
Erase/write was likely skipped as requested ranges are identical.

bash-5.2# flashrom -p internal -l layout -i rw_bios -w backup.rom
flashrom 1.5.0-devel (git:v1.2-1581-g4dc3fa98) on Linux 6.6.21-yocto-standard (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using region: "rw_bios".
coreboot table found at 0x76a14000.
Found chipset "Intel Alder Lake-P".
Enabling flash write... Warning: BIOS region SMM protection is enabled!
Warning: Setting BIOS Control at 0xdc from 0xaa to 0x89 failed.
New value is 0xaa.
SPI Configuration is locked down.
FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-write.
FREG1: BIOS region (0x00580000-0x00ffffff) is read-write.
FREG2: Management Engine region (0x00001000-0x003aefff) is read-write.
PR0: Warning: 0x00b00000-0x00ffffff is read-only.
At least some flash regions are write protected. For write operations,
you should use a flash layout and include only writable regions. See
manpage for more details.
PROBLEMS, continuing anyway
Found Macronix flash chip "MX25L12805D" (16384 kB, Programmer-specific) on internal.
===
This flash part has status UNTESTED for operations: WP
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom@flashrom.org if any of the above operations
work correctly for you with this flash chip. Please include the flashrom log
file for all operations you tested (see the man page for details), and mention
which mainboard or programmer you tested in the subject line.
You can also try to follow the instructions here:
https://www.flashrom.org/contrib_howtos/how_to_mark_chip_tested.html
Thanks for your help!
Reading old flash chip contents... done.
Erase/write done from 580000 to 5fffff

mkopec · 2024-12-13T18:41:59Z

Seems to work as described 👍

tested on NV40MB (Tiger Lake)

mkopec · 2024-12-13T18:42:40Z

 target/
+
+subprojects/cmocka-*/
+subprojects/packagecache/


Either remove or split into a separate commit, please

11e7895: those are folders generated by meson test.

mkopec · 2024-12-13T18:43:05Z

 	}

+	if ((write_it || erase_it) && !flash->flags.force) {
+		if(write_protect_check(flash)) {


Suggested change

if(write_protect_check(flash)) {

if (write_protect_check(flash)) {

Please make code style consistent

mkopec · 2024-12-13T18:50:35Z


+	prot->base = ICH_FREG_BASE(pr);
+	prot->limit = ICH_FREG_LIMIT(pr);
+	prot->write_prot = rwperms == WRITE_PROT;


Suggested change

prot->write_prot = rwperms == WRITE_PROT;

prot->write_prot = (rwperms == WRITE_PROT) || (rwperms == LOCKED);

I think, at least

I assumed based on

flashrom/ichspi.c

Line 2267 in ababbe1

switch (ich_spi_rw_restricted) {

that LOCKED != write-protected
If I'm reading this correctly in case ich_spi_rw_restricted == LOCKED then warning will only mention that's it's read-protected

Change-Id: Ic39b4acf1da73d093ce3a7df71c1c549d92240d5 Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

Change-Id: I989006eae97f5e015df20026b6f5361ad41223c1 Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

Change-Id: Iee172044959df8efd7148adb3a918a7dad963f6f Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

Change-Id: I1cdcfacaf61285bf4d7789610461a3f02ea4c64b Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

Change-Id: I0d8034aac411049e0223ad50f56b584602aa6899 Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

m-iwanicki self-assigned this Dec 5, 2024

m-iwanicki requested a review from mkopec December 5, 2024 21:16

m-iwanicki mentioned this pull request Dec 5, 2024

[DTS/Flashrom] Refuse flashing protected SPI flash ranges Dasharo/dasharo-issues#952

Open

m-iwanicki force-pushed the refuse-flashing-if-protected branch 2 times, most recently from 6892f59 to 4dc3fa9 Compare December 6, 2024 08:09

m-iwanicki force-pushed the refuse-flashing-if-protected branch from 337da02 to e7b4efa Compare December 6, 2024 18:31

m-iwanicki force-pushed the refuse-flashing-if-protected branch from e7b4efa to ababbe1 Compare December 6, 2024 18:39

mkopec requested changes Dec 13, 2024

View reviewed changes

tlaurion mentioned this pull request Dec 14, 2024

flash.sh: backup rom first, revert to backup if flashing fails for whatever reasons linuxboot/heads#1870

Draft

m-iwanicki force-pushed the refuse-flashing-if-protected branch from ababbe1 to c80f032 Compare December 18, 2024 08:42

m-iwanicki added 5 commits September 17, 2025 12:53

flashrom.c: Fail immediately when trying to write/erase wp regions

44f02be

Change-Id: Ic39b4acf1da73d093ce3a7df71c1c549d92240d5 Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

Check PR ranges when deciding if range is wp protected

0a54f18

Change-Id: I989006eae97f5e015df20026b6f5361ad41223c1 Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

.gitignore: Add folders generated by 'meson test'

0ebe902

Change-Id: Iee172044959df8efd7148adb3a918a7dad963f6f Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

flashrom.c & ichspi.c: code style fixes

659bdaf

Change-Id: I1cdcfacaf61285bf4d7789610461a3f02ea4c64b Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

ichspi.c: set write_prot if rwperms is LOCKED

a772b30

Change-Id: I0d8034aac411049e0223ad50f56b584602aa6899 Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>

m-iwanicki force-pushed the refuse-flashing-if-protected branch from 4de6d01 to a772b30 Compare September 17, 2025 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flashrom.c: Fail immediately when trying to write/erase wp regions#17

flashrom.c: Fail immediately when trying to write/erase wp regions#17
m-iwanicki wants to merge 5 commits into
syncfrom
refuse-flashing-if-protected

m-iwanicki commented Dec 5, 2024 •

edited

Loading

Uh oh!

mkopec commented Dec 6, 2024

Uh oh!

m-iwanicki commented Dec 6, 2024 •

edited

Loading

Uh oh!

mkopec commented Dec 13, 2024

Uh oh!

mkopec Dec 13, 2024

Uh oh!

m-iwanicki Dec 18, 2024

Uh oh!

mkopec Dec 13, 2024

Uh oh!

m-iwanicki Dec 18, 2024

Uh oh!

Uh oh!

mkopec Dec 13, 2024

Uh oh!

m-iwanicki Dec 13, 2024

Uh oh!

m-iwanicki Feb 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if(write_protect_check(flash)) {
	if (write_protect_check(flash)) {

	prot->write_prot = rwperms == WRITE_PROT;
	prot->write_prot = (rwperms == WRITE_PROT) \|\| (rwperms == LOCKED);

Conversation

m-iwanicki commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkopec commented Dec 6, 2024

Uh oh!

m-iwanicki commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests

Uh oh!

mkopec commented Dec 13, 2024

Uh oh!

mkopec Dec 13, 2024

Choose a reason for hiding this comment

Uh oh!

m-iwanicki Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

mkopec Dec 13, 2024

Choose a reason for hiding this comment

Uh oh!

m-iwanicki Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mkopec Dec 13, 2024

Choose a reason for hiding this comment

Uh oh!

m-iwanicki Dec 13, 2024

Choose a reason for hiding this comment

Uh oh!

m-iwanicki Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

m-iwanicki commented Dec 5, 2024 •

edited

Loading

m-iwanicki commented Dec 6, 2024 •

edited

Loading