Conversation
added 5 commits
March 7, 2019 16:21
| import play.api.libs.json._ | ||
|
|
||
| case class Template(id: String, template: String, description: String, parameterInfos: Map[String, ParameterInfo]) | ||
| case class Template(id: String, template: String, documentation_url: String, description: String, parameterInfos: Map[String, ParameterInfo]) |
There was a problem hiding this comment.
Please use camel caps for uniform naming scheme
| @@ -1,3 +1,4 @@ | |||
| documentation_url = "#curl-test-docs" | |||
There was a problem hiding this comment.
Please change to documentation-url. For uniformity. For example: Look at order-index.
|
@roman-p You can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR enables adding of documentation_url into template definition, which currently accepts any URL and renders it under the template description as a href.