[DT-3947] SO Console Summary Data - #3007
Open
otchet-broad wants to merge 2 commits into
Open
Conversation
otchet-broad
commented
Aug 7, 2026
| daas.forEach(daa -> daa.setBroadDaa(isBroadDAA(daa.getDaaId(), daas, allDacs))); | ||
| return daas; | ||
| } | ||
| return List.of(); |
Contributor
Author
There was a problem hiding this comment.
We can refactor this away because we modified the front end to not care which DAA was the Broad DAA. See screenshot below:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Signing Official dashboard summary endpoint and supporting data aggregation, while removing legacy “Broad DAA” tagging logic and adding DB indexes to improve query performance.
Changes:
- Introduces
/api/signing-official/dashboard-summarybacked by a new service + DAO that aggregates institution-scoped counts (DB + Elasticsearch). - Removes the
broadDaaflag and related “Broad-specific” DAA/DAC logic from services and tests. - Adds Liquibase changesets to create concurrent indexes used by the dashboard summary query.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/broadinstitute/consent/http/service/SigningOfficialDashboardService.java | Aggregates dashboard summary counts (DB + Elasticsearch) and maps to a typed response record. |
| src/main/java/org/broadinstitute/consent/http/db/SigningOfficialDashboardDAO.java | Implements the institution-scoped SQL aggregation for dashboard summary counts. |
| src/main/java/org/broadinstitute/consent/http/resources/SigningOfficialDashboardResource.java | Adds authenticated SO endpoint for dashboard summary. |
| src/main/java/org/broadinstitute/consent/http/models/SigningOfficialDashboardSummary.java | Defines the response model as Java records. |
| src/main/resources/assets/api-docs.yaml | Exposes the new endpoint and schema in OpenAPI. |
| src/main/resources/assets/paths/signingOfficialDashboardSummary.yaml | Adds OpenAPI path definition for the dashboard summary endpoint. |
| src/main/resources/assets/schemas/SigningOfficialDashboardSummary.yaml | Adds OpenAPI schema definition for the summary payload. |
| src/main/resources/changelog-master.xml | Includes the new Liquibase changeset in the master changelog. |
| src/main/resources/changesets/changelog-consent-2026-08-07-so-dashboard-indices.xml | Adds concurrent indexes to speed up dashboard-related joins/filters. |
| src/main/java/org/broadinstitute/consent/http/service/DacService.java | Removes Broad DAA tagging logic from DAC service responses. |
| src/main/java/org/broadinstitute/consent/http/service/DaaService.java | Removes Broad DAA identification/tagging logic; returns DAAs as-is. |
| src/main/java/org/broadinstitute/consent/http/models/DataAccessAgreement.java | Removes broadDaa field/accessors from the model. |
| src/main/java/org/broadinstitute/consent/http/ConsentModule.java | Wires new dashboard service and updates DacService/DaaService providers. |
| src/main/java/org/broadinstitute/consent/http/ConsentApplication.java | Registers the new dashboard resource with Jersey. |
| src/test/java/org/broadinstitute/consent/http/service/SigningOfficialDashboardServiceTest.java | Adds unit tests for summary aggregation behavior and failure modes. |
| src/test/java/org/broadinstitute/consent/http/resources/SigningOfficialDashboardResourceTest.java | Adds resource-level tests for HTTP status mappings. |
| src/test/java/org/broadinstitute/consent/http/db/SigningOfficialDashboardDAOTest.java | Adds DAO-level tests validating key counting semantics. |
| src/test/java/org/broadinstitute/consent/http/service/DacServiceTest.java | Updates tests to reflect removal of Broad DAA tagging. |
| src/test/java/org/broadinstitute/consent/http/service/DaaServiceTest.java | Updates tests to reflect removal of Broad DAA tagging. |
| JOIN users u ON u.user_id = c.create_user_id | ||
| WHERE dar.submission_date IS NOT NULL | ||
| AND u.institution_id = :institutionId | ||
| ORDER BY dar.collection_id, dar.submission_date DESC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-3947
Summary
Generates statistics for the SO Console Dashboard;
Resolves an OBE issue in DAA documents by removing the 'Broad' specific logic that was already being handled in a different way;
Indexes database fields that are used in joins for faster resolution
Have you read CONTRIBUTING.md lately? If not, do that first.