Skip to content

[DT-3218] Fix empty dataset rows in Signing Official DAR expansion#3569

Open
kevinmarete wants to merge 2 commits into
developfrom
km-dt-3218-so-dataset-loading-bug
Open

[DT-3218] Fix empty dataset rows in Signing Official DAR expansion#3569
kevinmarete wants to merge 2 commits into
developfrom
km-dt-3218-so-dataset-loading-bug

Conversation

@kevinmarete

Copy link
Copy Markdown
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-3218

Summary

This updates DAR expansion behavior for the Signing Official console so expanded dataset tables are shown in unfiltered mode (same as admin/researcher).

Previously, expanded rows could appear empty when DAC-based filtering removed all datasets for the current SO user context. Including SIGNING_OFFICIAL in isUnfilteredView ensures the full DAR dataset list is displayed reliably in the expanded view.

After

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@kevinmarete kevinmarete self-assigned this Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

DUOS Coverage Report

File Coverage Lines Branches
All files 32% 37% 27%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against da51e54

@kevinmarete kevinmarete marked this pull request as ready for review June 11, 2026 18:38
@kevinmarete kevinmarete requested a review from a team as a code owner June 11, 2026 18:38
@kevinmarete kevinmarete requested review from fboulnois and otchet-broad and removed request for a team June 11, 2026 18:38

@fboulnois fboulnois left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , shall we add a test for this behavior?

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants