feat: accept classname on loginview (and login) for consumer styling (#954)#957
Merged
Conversation
…954) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the public LoginView and underlying Login component APIs to accept an optional className, enabling consumers to style/position the login card by targeting the root element (without adding an extra wrapper node).
Changes:
- Extend
LoginViewPropsandLoginPropswithBaseComponentProps(adds optionalclassName). - Forward
classNamefromLoginView→Login→LoginWrapper(root element).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/views/LoginView/loginView.tsx | Adds className to LoginViewProps and forwards it to Login. |
| src/components/Login/types.ts | Extends Login props with BaseComponentProps to include className. |
| src/components/Login/login.tsx | Applies the forwarded className to the root LoginWrapper. |
NoopDog
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoginPropsandLoginViewPropswithBaseComponentProps, adding an optionalclassName.classNamefromLoginView→Login→ rootLoginWrapper, so consumers can style/position the login card without an extra wrapper element.Closes #954
Test plan
npm test)npx tscpassesclassNamesee no change.🤖 Generated with Claude Code