Skip to content

feat: accept classname on loginview (and login) for consumer styling (#954)#957

Merged
NoopDog merged 1 commit into
mainfrom
fran/954-loginview-classname
Jun 10, 2026
Merged

feat: accept classname on loginview (and login) for consumer styling (#954)#957
NoopDog merged 1 commit into
mainfrom
fran/954-loginview-classname

Conversation

@frano-m

@frano-m frano-m commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extends Login Props and LoginViewProps with BaseComponentProps, adding an optional className.
  • Forwards className from LoginViewLogin → root LoginWrapper, so consumers can style/position the login card without an extra wrapper element.

Closes #954

Test plan

  • Existing tests still pass (npm test)
  • npx tsc passes
  • Consumer usage works:
    const StyledLoginView = styled(LoginView)\`
      align-self: center;
    \`;
    <StyledLoginView providers={providers} />
    renders the login card with the styled-component class applied to its root.
  • Existing consumers that don't pass className see no change.

🤖 Generated with Claude Code

…954)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 10, 2026 06:48
@frano-m frano-m marked this pull request as ready for review June 10, 2026 06:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the public LoginView and underlying Login component APIs to accept an optional className, enabling consumers to style/position the login card by targeting the root element (without adding an extra wrapper node).

Changes:

  • Extend LoginViewProps and Login Props with BaseComponentProps (adds optional className).
  • Forward className from LoginViewLoginLoginWrapper (root element).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/views/LoginView/loginView.tsx Adds className to LoginViewProps and forwards it to Login.
src/components/Login/types.ts Extends Login props with BaseComponentProps to include className.
src/components/Login/login.tsx Applies the forwarded className to the root LoginWrapper.

@NoopDog NoopDog merged commit 5b148c1 into main Jun 10, 2026
3 checks passed
@frano-m frano-m deleted the fran/954-loginview-classname branch June 10, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: accept className on LoginView (and Login) for consumer styling

3 participants