feat: add support for extracting DSM context in event bridge#790
feat: add support for extracting DSM context in event bridge#790jeastham1993 wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b4a132b1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // detail-type as the topic, matching the produce-side convention. | ||
| if (this.config.dataStreamsEnabled) { | ||
| try { | ||
| this.tracerWrapper.setConsumeCheckpoint(headers, "eventbridge", event?.["detail-type"]); |
There was a problem hiding this comment.
For EventBridge records that carry DSM context from Datadog-instrumented producers, the producer checkpoint is keyed by the event bus name (the injected _datadog payload carries it as x-datadog-resource-name). This code instead consumes on the event's detail-type, so a message on bus orders with detail-type UserSignUp records the consume checkpoint under a different topic and the pathway will not stitch to the producer. Please use the producer's resource/bus name from the carrier rather than detail-type.
Useful? React with 👍 / 👎.
1 participant
What does this PR do?
Extends the support for DSM context extraction to EventBridge and EventBridge -> SQS
Motivation
Adding support for all serverless messaging technologies with DSM.
Testing Guidelines
Manually deployed NodeJS tracer layer and verified functionality works against a sample app.
Additional Notes
Types of Changes
Check all that apply