Skip to content

RUM-2780: Return no-op core when instance is already initialized #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ambushwork wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RUM-2780: Return no-op core when instance is already initialized #3271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dd-sdk-android-core/src/main/kotlin/com/datadog/android/Datadog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ object Datadog {
InternalLogger.Target.USER,
{ MESSAGE_ALREADY_INITIALIZED }
)
return existing
return NoOpInternalSdkCore
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Return existing core on duplicate initialization

Returning NoOpInternalSdkCore here breaks initialize() idempotency for callers that keep and reuse the returned SdkCore (for example, val core = Datadog.initialize(...); Rum.enable(..., core)). In a common defensive pattern where a library calls initialize() after the app already did, the second call now hands back a no-op core, so subsequent feature registration and user/context updates are silently dropped even though a real instance is already active.

Useful? React with 👍 / 👎.

}

val sdkInstanceId = hashGenerator.generate(
Expand Down
6 changes: 3 additions & 3 deletions dd-sdk-android-core/src/test/kotlin/com/datadog/android/DatadogTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ internal class DatadogTest {
}

@Test
fun `M warn W initialize() + initialize()`() {
fun `M warn and return no-op W initialize() + initialize()`() {
// When
val initialized1 = Datadog.initialize(
Datadog.initialize(
appContext.mockInstance,
fakeConfiguration,
fakeConsent
Expand All @@ -147,7 +147,7 @@ internal class DatadogTest {
InternalLogger.Target.USER,
Datadog.MESSAGE_ALREADY_INITIALIZED
)
assertThat(initialized2).isSameAs(initialized1)
assertThat(initialized2).isSameAs(NoOpInternalSdkCore)
}

@Test
Expand Down
Loading