-
Notifications
You must be signed in to change notification settings - Fork 324
Caching the primaryInstrumentationName #10477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Caching the primaryInstrumentationName to avoid repeatedly calling instrumentationNames() and constantly allocating a String[]
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069532
Total [baseline] (10.853 s) : 0, 10853148
Agent [candidate] (1.064 s) : 0, 1064206
Total [candidate] (10.793 s) : 0, 10792761
section appsec
Agent [baseline] (1.24 s) : 0, 1239594
Total [baseline] (11.121 s) : 0, 11121427
Agent [candidate] (1.243 s) : 0, 1242912
Total [candidate] (11.097 s) : 0, 11097181
section iast
Agent [baseline] (1.228 s) : 0, 1227989
Total [baseline] (11.131 s) : 0, 11131102
Agent [candidate] (1.23 s) : 0, 1230111
Total [candidate] (11.13 s) : 0, 11130083
section profiling
Agent [baseline] (1.199 s) : 0, 1199044
Total [baseline] (11.019 s) : 0, 11019086
Agent [candidate] (1.19 s) : 0, 1189971
Total [candidate] (10.906 s) : 0, 10906469
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (632.125 ms) : 0, 632125
BytebuddyAgent [candidate] (628.728 ms) : 0, 628728
AgentMeter [baseline] (29.072 ms) : 0, 29072
AgentMeter [candidate] (28.871 ms) : 0, 28871
GlobalTracer [baseline] (258.771 ms) : 0, 258771
GlobalTracer [candidate] (257.736 ms) : 0, 257736
AppSec [baseline] (32.957 ms) : 0, 32957
AppSec [candidate] (32.946 ms) : 0, 32946
Debugger [baseline] (60.853 ms) : 0, 60853
Debugger [candidate] (61.99 ms) : 0, 61990
Remote Config [baseline] (623.839 µs) : 0, 624
Remote Config [candidate] (618.824 µs) : 0, 619
Telemetry [baseline] (13.923 ms) : 0, 13923
Telemetry [candidate] (11.45 ms) : 0, 11450
Flare Poller [baseline] (4.583 ms) : 0, 4583
Flare Poller [candidate] (5.455 ms) : 0, 5455
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (658.143 ms) : 0, 658143
BytebuddyAgent [candidate] (660.103 ms) : 0, 660103
AgentMeter [baseline] (11.926 ms) : 0, 11926
AgentMeter [candidate] (11.934 ms) : 0, 11934
GlobalTracer [baseline] (258.558 ms) : 0, 258558
GlobalTracer [candidate] (259.286 ms) : 0, 259286
AppSec [baseline] (167.934 ms) : 0, 167934
AppSec [candidate] (168.358 ms) : 0, 168358
Debugger [baseline] (67.762 ms) : 0, 67762
Debugger [candidate] (67.741 ms) : 0, 67741
Remote Config [baseline] (683.964 µs) : 0, 684
Remote Config [candidate] (673.874 µs) : 0, 674
Telemetry [baseline] (9.262 ms) : 0, 9262
Telemetry [candidate] (9.164 ms) : 0, 9164
Flare Poller [baseline] (3.668 ms) : 0, 3668
Flare Poller [candidate] (3.631 ms) : 0, 3631
IAST [baseline] (25.187 ms) : 0, 25187
IAST [candidate] (25.552 ms) : 0, 25552
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (793.696 ms) : 0, 793696
BytebuddyAgent [candidate] (794.629 ms) : 0, 794629
AgentMeter [baseline] (11.229 ms) : 0, 11229
AgentMeter [candidate] (11.253 ms) : 0, 11253
GlobalTracer [baseline] (246.776 ms) : 0, 246776
GlobalTracer [candidate] (247.233 ms) : 0, 247233
AppSec [baseline] (32.728 ms) : 0, 32728
AppSec [candidate] (31.33 ms) : 0, 31330
Debugger [baseline] (67.48 ms) : 0, 67480
Debugger [candidate] (69.594 ms) : 0, 69594
Remote Config [baseline] (541.237 µs) : 0, 541
Remote Config [candidate] (544.256 µs) : 0, 544
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.662 ms) : 0, 8662
Flare Poller [baseline] (3.49 ms) : 0, 3490
Flare Poller [candidate] (3.527 ms) : 0, 3527
IAST [baseline] (27.0 ms) : 0, 27000
IAST [candidate] (26.999 ms) : 0, 26999
section profiling
ProfilingAgent [baseline] (98.853 ms) : 0, 98853
ProfilingAgent [candidate] (99.08 ms) : 0, 99080
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (687.608 ms) : 0, 687608
BytebuddyAgent [candidate] (681.953 ms) : 0, 681953
AgentMeter [baseline] (8.845 ms) : 0, 8845
AgentMeter [candidate] (8.755 ms) : 0, 8755
GlobalTracer [baseline] (217.812 ms) : 0, 217812
GlobalTracer [candidate] (216.004 ms) : 0, 216004
AppSec [baseline] (32.921 ms) : 0, 32921
AppSec [candidate] (32.58 ms) : 0, 32580
Debugger [baseline] (68.071 ms) : 0, 68071
Debugger [candidate] (67.441 ms) : 0, 67441
Remote Config [baseline] (604.313 µs) : 0, 604
Remote Config [candidate] (597.778 µs) : 0, 598
Telemetry [baseline] (8.975 ms) : 0, 8975
Telemetry [candidate] (8.796 ms) : 0, 8796
Flare Poller [baseline] (3.829 ms) : 0, 3829
Flare Poller [candidate] (3.716 ms) : 0, 3716
Profiling [baseline] (99.446 ms) : 0, 99446
Profiling [candidate] (99.652 ms) : 0, 99652
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066243
Total [baseline] (8.776 s) : 0, 8775805
Agent [candidate] (1.068 s) : 0, 1067887
Total [candidate] (8.778 s) : 0, 8777759
section iast
Agent [baseline] (1.229 s) : 0, 1229280
Total [baseline] (9.344 s) : 0, 9343960
Agent [candidate] (1.242 s) : 0, 1241782
Total [candidate] (9.397 s) : 0, 9397059
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (629.509 ms) : 0, 629509
BytebuddyAgent [candidate] (631.014 ms) : 0, 631014
AgentMeter [baseline] (28.857 ms) : 0, 28857
AgentMeter [candidate] (29.07 ms) : 0, 29070
GlobalTracer [baseline] (257.482 ms) : 0, 257482
GlobalTracer [candidate] (258.797 ms) : 0, 258797
AppSec [baseline] (32.871 ms) : 0, 32871
AppSec [candidate] (33.078 ms) : 0, 33078
Debugger [baseline] (60.357 ms) : 0, 60357
Debugger [candidate] (61.573 ms) : 0, 61573
Remote Config [baseline] (615.825 µs) : 0, 616
Remote Config [candidate] (624.263 µs) : 0, 624
Telemetry [baseline] (14.556 ms) : 0, 14556
Telemetry [candidate] (11.762 ms) : 0, 11762
Flare Poller [baseline] (5.301 ms) : 0, 5301
Flare Poller [candidate] (5.33 ms) : 0, 5330
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (794.302 ms) : 0, 794302
BytebuddyAgent [candidate] (803.414 ms) : 0, 803414
AgentMeter [baseline] (11.279 ms) : 0, 11279
AgentMeter [candidate] (11.604 ms) : 0, 11604
GlobalTracer [baseline] (247.181 ms) : 0, 247181
GlobalTracer [candidate] (249.86 ms) : 0, 249860
AppSec [baseline] (33.288 ms) : 0, 33288
AppSec [candidate] (33.67 ms) : 0, 33670
Debugger [baseline] (67.093 ms) : 0, 67093
Debugger [candidate] (66.658 ms) : 0, 66658
Remote Config [baseline] (535.353 µs) : 0, 535
Remote Config [candidate] (538.012 µs) : 0, 538
Telemetry [baseline] (8.589 ms) : 0, 8589
Telemetry [candidate] (8.557 ms) : 0, 8557
Flare Poller [baseline] (3.439 ms) : 0, 3439
Flare Poller [candidate] (3.514 ms) : 0, 3514
IAST [baseline] (27.089 ms) : 0, 27089
IAST [candidate] (27.321 ms) : 0, 27321
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1169, 1192
. : milestone, 1181,
iast (3.282 ms) : 3238, 3325
. : milestone, 3282,
iast_FULL (6.105 ms) : 6042, 6168
. : milestone, 6105,
iast_GLOBAL (3.544 ms) : 3485, 3603
. : milestone, 3544,
profiling (2.194 ms) : 2174, 2215
. : milestone, 2194,
tracing (1.808 ms) : 1792, 1825
. : milestone, 1808,
section candidate
no_agent (1.168 ms) : 1156, 1179
. : milestone, 1168,
iast (3.212 ms) : 3170, 3254
. : milestone, 3212,
iast_FULL (5.786 ms) : 5728, 5844
. : milestone, 5786,
iast_GLOBAL (3.714 ms) : 3651, 3776
. : milestone, 3714,
profiling (1.968 ms) : 1951, 1985
. : milestone, 1968,
tracing (1.774 ms) : 1759, 1789
. : milestone, 1774,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (19.036 ms) : 18841, 19231
. : milestone, 19036,
appsec (18.333 ms) : 18147, 18519
. : milestone, 18333,
code_origins (17.472 ms) : 17297, 17646
. : milestone, 17472,
iast (17.564 ms) : 17392, 17737
. : milestone, 17564,
profiling (18.473 ms) : 18284, 18662
. : milestone, 18473,
tracing (17.547 ms) : 17374, 17720
. : milestone, 17547,
section candidate
no_agent (18.186 ms) : 18000, 18372
. : milestone, 18186,
appsec (18.323 ms) : 18137, 18510
. : milestone, 18323,
code_origins (18.397 ms) : 18213, 18581
. : milestone, 18397,
iast (17.498 ms) : 17323, 17672
. : milestone, 17498,
profiling (18.33 ms) : 18147, 18512
. : milestone, 18330,
tracing (18.443 ms) : 18256, 18630
. : milestone, 18443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.69 ms) : 3473, 3906
. : milestone, 3690,
iast (2.253 ms) : 2183, 2322
. : milestone, 2253,
iast_GLOBAL (2.292 ms) : 2223, 2362
. : milestone, 2292,
profiling (2.081 ms) : 2026, 2136
. : milestone, 2081,
tracing (2.072 ms) : 2018, 2126
. : milestone, 2072,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.762 ms) : 3541, 3983
. : milestone, 3762,
iast (2.252 ms) : 2183, 2321
. : milestone, 2252,
iast_GLOBAL (2.297 ms) : 2226, 2367
. : milestone, 2297,
profiling (2.102 ms) : 2046, 2159
. : milestone, 2102,
tracing (2.054 ms) : 2000, 2107
. : milestone, 2054,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~8dbc564919, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
appsec (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
iast (17.9 s) : 17900000, 17900000
. : milestone, 17900000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
. : milestone, 17882000,
profiling (14.813 s) : 14813000, 14813000
. : milestone, 14813000,
tracing (14.762 s) : 14762000, 14762000
. : milestone, 14762000,
section candidate
no_agent (15.701 s) : 15701000, 15701000
. : milestone, 15701000,
appsec (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
iast (18.596 s) : 18596000, 18596000
. : milestone, 18596000,
iast_GLOBAL (17.948 s) : 17948000, 17948000
. : milestone, 17948000,
profiling (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
tracing (14.623 s) : 14623000, 14623000
. : milestone, 14623000,
|
bric3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What Does This Do
Caching the primaryInstrumentationName to avoid repeatedly calling instrumentationNames and constantly allocating a String[]
Motivation
Avoid repetitive work and memory allocation
Additional Notes
The high load benchmarks are known to be flaky, but I wanted to double check the regressions anyway.
In a local load test, this change performed as expected...
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]