Move reactor-core and rective-streams advices to context tracking#10483
Move reactor-core and rective-streams advices to context tracking#10483gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073204
Total [baseline] (10.946 s) : 0, 10946205
Agent [candidate] (1.068 s) : 0, 1067821
Total [candidate] (10.893 s) : 0, 10892691
section appsec
Agent [baseline] (1.239 s) : 0, 1239141
Total [baseline] (11.041 s) : 0, 11040951
Agent [candidate] (1.312 s) : 0, 1312337
Total [candidate] (4.469 s) : 0, 4469476
section iast
Agent [baseline] (1.23 s) : 0, 1230263
Total [baseline] (11.212 s) : 0, 11212464
Agent [candidate] (1.248 s) : 0, 1247640
Total [candidate] (11.369 s) : 0, 11369462
section profiling
Agent [baseline] (1.193 s) : 0, 1193445
Total [baseline] (11.106 s) : 0, 11105736
Agent [candidate] (1.193 s) : 0, 1193374
Total [candidate] (11.012 s) : 0, 11011597
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (633.405 ms) : 0, 633405
BytebuddyAgent [candidate] (629.895 ms) : 0, 629895
AgentMeter [baseline] (29.183 ms) : 0, 29183
AgentMeter [candidate] (28.908 ms) : 0, 28908
GlobalTracer [baseline] (259.846 ms) : 0, 259846
GlobalTracer [candidate] (258.648 ms) : 0, 258648
AppSec [baseline] (33.093 ms) : 0, 33093
AppSec [candidate] (32.96 ms) : 0, 32960
Debugger [baseline] (62.461 ms) : 0, 62461
Debugger [candidate] (62.493 ms) : 0, 62493
Remote Config [baseline] (613.84 µs) : 0, 614
Remote Config [candidate] (616.833 µs) : 0, 617
Telemetry [baseline] (12.383 ms) : 0, 12383
Telemetry [candidate] (13.066 ms) : 0, 13066
Flare Poller [baseline] (5.397 ms) : 0, 5397
Flare Poller [candidate] (4.623 ms) : 0, 4623
section appsec
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.271 ms) : 0, 1271
BytebuddyAgent [baseline] (658.084 ms) : 0, 658084
BytebuddyAgent [candidate] (705.846 ms) : 0, 705846
AgentMeter [baseline] (11.885 ms) : 0, 11885
AgentMeter [candidate] (12.664 ms) : 0, 12664
GlobalTracer [baseline] (258.752 ms) : 0, 258752
GlobalTracer [candidate] (273.384 ms) : 0, 273384
IAST [baseline] (25.226 ms) : 0, 25226
IAST [candidate] (27.706 ms) : 0, 27706
AppSec [baseline] (168.045 ms) : 0, 168045
AppSec [candidate] (172.872 ms) : 0, 172872
Debugger [baseline] (67.267 ms) : 0, 67267
Debugger [candidate] (68.375 ms) : 0, 68375
Remote Config [baseline] (657.762 µs) : 0, 658
Remote Config [candidate] (678.887 µs) : 0, 679
Telemetry [baseline] (8.988 ms) : 0, 8988
Telemetry [candidate] (9.332 ms) : 0, 9332
Flare Poller [baseline] (3.648 ms) : 0, 3648
Flare Poller [candidate] (3.397 ms) : 0, 3397
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (794.934 ms) : 0, 794934
BytebuddyAgent [candidate] (805.601 ms) : 0, 805601
AgentMeter [baseline] (11.242 ms) : 0, 11242
AgentMeter [candidate] (11.563 ms) : 0, 11563
GlobalTracer [baseline] (247.335 ms) : 0, 247335
GlobalTracer [candidate] (251.189 ms) : 0, 251189
IAST [baseline] (26.939 ms) : 0, 26939
IAST [candidate] (27.358 ms) : 0, 27358
AppSec [baseline] (33.887 ms) : 0, 33887
AppSec [candidate] (32.693 ms) : 0, 32693
Debugger [baseline] (66.568 ms) : 0, 66568
Debugger [candidate] (69.234 ms) : 0, 69234
Remote Config [baseline] (549.643 µs) : 0, 550
Remote Config [candidate] (550.947 µs) : 0, 551
Telemetry [baseline] (8.809 ms) : 0, 8809
Telemetry [candidate] (8.92 ms) : 0, 8920
Flare Poller [baseline] (3.452 ms) : 0, 3452
Flare Poller [candidate] (3.584 ms) : 0, 3584
section profiling
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (682.943 ms) : 0, 682943
BytebuddyAgent [candidate] (682.009 ms) : 0, 682009
AgentMeter [baseline] (8.764 ms) : 0, 8764
AgentMeter [candidate] (8.843 ms) : 0, 8843
GlobalTracer [baseline] (216.284 ms) : 0, 216284
GlobalTracer [candidate] (217.013 ms) : 0, 217013
AppSec [baseline] (32.42 ms) : 0, 32420
AppSec [candidate] (32.652 ms) : 0, 32652
Debugger [baseline] (67.771 ms) : 0, 67771
Debugger [candidate] (68.318 ms) : 0, 68318
Remote Config [baseline] (600.442 µs) : 0, 600
Remote Config [candidate] (611.974 µs) : 0, 612
Telemetry [baseline] (8.898 ms) : 0, 8898
Telemetry [candidate] (8.971 ms) : 0, 8971
Flare Poller [baseline] (3.834 ms) : 0, 3834
Flare Poller [candidate] (3.793 ms) : 0, 3793
ProfilingAgent [baseline] (100.596 ms) : 0, 100596
ProfilingAgent [candidate] (100.188 ms) : 0, 100188
Profiling [baseline] (101.174 ms) : 0, 101174
Profiling [candidate] (100.767 ms) : 0, 100767
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071942
Total [baseline] (8.804 s) : 0, 8804346
Agent [candidate] (1.063 s) : 0, 1063293
Total [candidate] (8.756 s) : 0, 8755996
section iast
Agent [baseline] (1.233 s) : 0, 1232746
Total [baseline] (9.362 s) : 0, 9361808
Agent [candidate] (1.234 s) : 0, 1233606
Total [candidate] (9.381 s) : 0, 9380845
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (632.1 ms) : 0, 632100
BytebuddyAgent [candidate] (628.164 ms) : 0, 628164
AgentMeter [baseline] (29.244 ms) : 0, 29244
AgentMeter [candidate] (28.796 ms) : 0, 28796
GlobalTracer [baseline] (259.512 ms) : 0, 259512
GlobalTracer [candidate] (257.706 ms) : 0, 257706
AppSec [baseline] (33.175 ms) : 0, 33175
AppSec [candidate] (32.756 ms) : 0, 32756
Debugger [baseline] (62.595 ms) : 0, 62595
Debugger [candidate] (61.051 ms) : 0, 61051
Remote Config [baseline] (624.891 µs) : 0, 625
Remote Config [candidate] (620.453 µs) : 0, 620
Telemetry [baseline] (11.635 ms) : 0, 11635
Telemetry [candidate] (10.747 ms) : 0, 10747
Flare Poller [baseline] (6.213 ms) : 0, 6213
Flare Poller [candidate] (6.973 ms) : 0, 6973
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (796.222 ms) : 0, 796222
BytebuddyAgent [candidate] (796.982 ms) : 0, 796982
AgentMeter [baseline] (11.272 ms) : 0, 11272
AgentMeter [candidate] (11.278 ms) : 0, 11278
GlobalTracer [baseline] (248.231 ms) : 0, 248231
GlobalTracer [candidate] (248.824 ms) : 0, 248824
IAST [baseline] (27.046 ms) : 0, 27046
IAST [candidate] (27.065 ms) : 0, 27065
AppSec [baseline] (33.2 ms) : 0, 33200
AppSec [candidate] (34.086 ms) : 0, 34086
Debugger [baseline] (67.376 ms) : 0, 67376
Debugger [candidate] (65.971 ms) : 0, 65971
Remote Config [baseline] (543.245 µs) : 0, 543
Remote Config [candidate] (548.932 µs) : 0, 549
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.689 ms) : 0, 8689
Flare Poller [baseline] (3.541 ms) : 0, 3541
Flare Poller [candidate] (3.607 ms) : 0, 3607
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1173, 1195
. : milestone, 1184,
iast (3.235 ms) : 3186, 3283
. : milestone, 3235,
iast_FULL (5.663 ms) : 5607, 5719
. : milestone, 5663,
iast_GLOBAL (3.532 ms) : 3478, 3586
. : milestone, 3532,
profiling (2.143 ms) : 2123, 2163
. : milestone, 2143,
tracing (1.759 ms) : 1744, 1774
. : milestone, 1759,
section candidate
no_agent (1.195 ms) : 1184, 1206
. : milestone, 1195,
iast (3.13 ms) : 3089, 3170
. : milestone, 3130,
iast_FULL (6.153 ms) : 6090, 6216
. : milestone, 6153,
iast_GLOBAL (3.608 ms) : 3547, 3668
. : milestone, 3608,
profiling (2.158 ms) : 2137, 2180
. : milestone, 2158,
tracing (1.782 ms) : 1768, 1796
. : milestone, 1782,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (17.074 ms) : 16907, 17242
. : milestone, 17074,
appsec (18.814 ms) : 18627, 19001
. : milestone, 18814,
code_origins (18.564 ms) : 18378, 18749
. : milestone, 18564,
iast (17.952 ms) : 17772, 18132
. : milestone, 17952,
profiling (19.509 ms) : 19310, 19707
. : milestone, 19509,
tracing (17.518 ms) : 17346, 17690
. : milestone, 17518,
section candidate
no_agent (19.212 ms) : 19016, 19409
. : milestone, 19212,
appsec (18.463 ms) : 18276, 18650
. : milestone, 18463,
code_origins (17.832 ms) : 17653, 18011
. : milestone, 17832,
iast (17.899 ms) : 17717, 18080
. : milestone, 17899,
profiling (18.82 ms) : 18631, 19009
. : milestone, 18820,
tracing (17.678 ms) : 17506, 17851
. : milestone, 17678,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.723 ms) : 3507, 3939
. : milestone, 3723,
iast (2.26 ms) : 2192, 2329
. : milestone, 2260,
iast_GLOBAL (2.298 ms) : 2228, 2367
. : milestone, 2298,
profiling (2.075 ms) : 2021, 2129
. : milestone, 2075,
tracing (2.052 ms) : 1999, 2105
. : milestone, 2052,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.784 ms) : 3562, 4006
. : milestone, 3784,
iast (2.258 ms) : 2190, 2327
. : milestone, 2258,
iast_GLOBAL (2.301 ms) : 2231, 2370
. : milestone, 2301,
profiling (2.092 ms) : 2036, 2148
. : milestone, 2092,
tracing (2.061 ms) : 2008, 2115
. : milestone, 2061,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4db98f2db3, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (15.544 s) : 15544000, 15544000
. : milestone, 15544000,
appsec (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
iast (18.014 s) : 18014000, 18014000
. : milestone, 18014000,
iast_GLOBAL (18.238 s) : 18238000, 18238000
. : milestone, 18238000,
profiling (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
tracing (14.58 s) : 14580000, 14580000
. : milestone, 14580000,
section candidate
no_agent (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
appsec (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
iast (18.21 s) : 18210000, 18210000
. : milestone, 18210000,
iast_GLOBAL (17.721 s) : 17721000, 17721000
. : milestone, 17721000,
profiling (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
tracing (14.496 s) : 14496000, 14496000
. : milestone, 14496000,
|
...n/java/datadog/trace/instrumentation/resilience4j/CircuitBreakerOperatorInstrumentation.java
Outdated
Show resolved
Hide resolved
...1/src/main/java/datadog/trace/instrumentation/reactor/core/CorePublisherInstrumentation.java
Outdated
Show resolved
Hide resolved
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status waiting |
5c80905
into
master
What Does This Do
This PR changes instrumenter type of modules ony doing context tracking to CONTEXT_TRACKING target system.
Also changes the API and the context stores to use generically Context and not span/scopes
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]