Extract inner classes when getting test source file#10506
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom Feb 4, 2026
Merged
Extract inner classes when getting test source file#10506gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
sarahchen6
added
type: bug
sarahchen6
requested review from
AlexeyKuznetsov-DD,
PerfectSlayer and
pawelchcki
and removed request for
a team
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064635
Total [baseline] (8.767 s) : 0, 8766837
Agent [candidate] (1.065 s) : 0, 1064612
Total [candidate] (8.777 s) : 0, 8776584
section iast
Agent [baseline] (1.245 s) : 0, 1245070
Total [baseline] (9.471 s) : 0, 9470604
Agent [candidate] (1.232 s) : 0, 1232104
Total [candidate] (9.364 s) : 0, 9363639
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (629.696 ms) : 0, 629696
BytebuddyAgent [candidate] (628.473 ms) : 0, 628473
AgentMeter [baseline] (28.725 ms) : 0, 28725
AgentMeter [candidate] (28.832 ms) : 0, 28832
GlobalTracer [baseline] (257.873 ms) : 0, 257873
GlobalTracer [candidate] (257.739 ms) : 0, 257739
AppSec [baseline] (32.8 ms) : 0, 32800
AppSec [candidate] (32.949 ms) : 0, 32949
Debugger [baseline] (62.422 ms) : 0, 62422
Debugger [candidate] (59.669 ms) : 0, 59669
Remote Config [baseline] (611.206 µs) : 0, 611
Remote Config [candidate] (611.515 µs) : 0, 612
Telemetry [baseline] (12.212 ms) : 0, 12212
Telemetry [candidate] (14.453 ms) : 0, 14453
Flare Poller [baseline] (3.751 ms) : 0, 3751
Flare Poller [candidate] (5.335 ms) : 0, 5335
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (806.203 ms) : 0, 806203
BytebuddyAgent [candidate] (798.453 ms) : 0, 798453
AgentMeter [baseline] (11.558 ms) : 0, 11558
AgentMeter [candidate] (11.132 ms) : 0, 11132
GlobalTracer [baseline] (249.104 ms) : 0, 249104
GlobalTracer [candidate] (247.212 ms) : 0, 247212
IAST [baseline] (27.249 ms) : 0, 27249
IAST [candidate] (26.9 ms) : 0, 26900
AppSec [baseline] (33.688 ms) : 0, 33688
AppSec [candidate] (35.526 ms) : 0, 35526
Debugger [baseline] (67.489 ms) : 0, 67489
Debugger [candidate] (63.679 ms) : 0, 63679
Remote Config [baseline] (565.004 µs) : 0, 565
Remote Config [candidate] (529.855 µs) : 0, 530
Telemetry [baseline] (8.939 ms) : 0, 8939
Telemetry [candidate] (8.711 ms) : 0, 8711
Flare Poller [baseline] (3.547 ms) : 0, 3547
Flare Poller [candidate] (3.422 ms) : 0, 3422
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063031
Total [baseline] (10.943 s) : 0, 10942743
Agent [candidate] (1.077 s) : 0, 1077430
Total [candidate] (10.968 s) : 0, 10968157
section appsec
Agent [baseline] (1.24 s) : 0, 1240381
Total [baseline] (11.157 s) : 0, 11156930
Agent [candidate] (1.242 s) : 0, 1242110
Total [candidate] (11.144 s) : 0, 11143685
section iast
Agent [baseline] (1.232 s) : 0, 1232087
Total [baseline] (11.268 s) : 0, 11268361
Agent [candidate] (1.233 s) : 0, 1232887
Total [candidate] (11.15 s) : 0, 11149940
section profiling
Agent [baseline] (1.205 s) : 0, 1205117
Total [baseline] (11.121 s) : 0, 11121044
Agent [candidate] (1.193 s) : 0, 1193198
Total [candidate] (11.05 s) : 0, 11050407
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (627.622 ms) : 0, 627622
BytebuddyAgent [candidate] (636.323 ms) : 0, 636323
AgentMeter [baseline] (28.62 ms) : 0, 28620
AgentMeter [candidate] (29.166 ms) : 0, 29166
GlobalTracer [baseline] (257.127 ms) : 0, 257127
GlobalTracer [candidate] (260.705 ms) : 0, 260705
AppSec [baseline] (32.764 ms) : 0, 32764
AppSec [candidate] (33.379 ms) : 0, 33379
Debugger [baseline] (62.053 ms) : 0, 62053
Debugger [candidate] (63.47 ms) : 0, 63470
Remote Config [baseline] (618.448 µs) : 0, 618
Remote Config [candidate] (624.688 µs) : 0, 625
Telemetry [baseline] (11.598 ms) : 0, 11598
Telemetry [candidate] (13.143 ms) : 0, 13143
Flare Poller [baseline] (6.101 ms) : 0, 6101
Flare Poller [candidate] (3.88 ms) : 0, 3880
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (659.034 ms) : 0, 659034
BytebuddyAgent [candidate] (660.411 ms) : 0, 660411
AgentMeter [baseline] (11.741 ms) : 0, 11741
AgentMeter [candidate] (11.779 ms) : 0, 11779
GlobalTracer [baseline] (258.489 ms) : 0, 258489
GlobalTracer [candidate] (259.234 ms) : 0, 259234
IAST [baseline] (25.223 ms) : 0, 25223
IAST [candidate] (25.296 ms) : 0, 25296
AppSec [baseline] (167.828 ms) : 0, 167828
AppSec [candidate] (168.103 ms) : 0, 168103
Debugger [baseline] (67.816 ms) : 0, 67816
Debugger [candidate] (67.3 ms) : 0, 67300
Remote Config [baseline] (677.433 µs) : 0, 677
Remote Config [candidate] (657.498 µs) : 0, 657
Telemetry [baseline] (9.226 ms) : 0, 9226
Telemetry [candidate] (9.138 ms) : 0, 9138
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.59 ms) : 0, 3590
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (796.663 ms) : 0, 796663
BytebuddyAgent [candidate] (796.936 ms) : 0, 796936
AgentMeter [baseline] (11.143 ms) : 0, 11143
AgentMeter [candidate] (11.115 ms) : 0, 11115
GlobalTracer [baseline] (248.05 ms) : 0, 248050
GlobalTracer [candidate] (248.313 ms) : 0, 248313
IAST [baseline] (26.945 ms) : 0, 26945
IAST [candidate] (26.973 ms) : 0, 26973
AppSec [baseline] (35.583 ms) : 0, 35583
AppSec [candidate] (33.111 ms) : 0, 33111
Debugger [baseline] (64.744 ms) : 0, 64744
Debugger [candidate] (67.449 ms) : 0, 67449
Remote Config [baseline] (539.147 µs) : 0, 539
Remote Config [candidate] (533.413 µs) : 0, 533
Telemetry [baseline] (8.559 ms) : 0, 8559
Telemetry [candidate] (8.62 ms) : 0, 8620
Flare Poller [baseline] (3.443 ms) : 0, 3443
Flare Poller [candidate] (3.417 ms) : 0, 3417
section profiling
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (690.896 ms) : 0, 690896
BytebuddyAgent [candidate] (683.911 ms) : 0, 683911
AgentMeter [baseline] (8.802 ms) : 0, 8802
AgentMeter [candidate] (8.657 ms) : 0, 8657
GlobalTracer [baseline] (218.477 ms) : 0, 218477
GlobalTracer [candidate] (216.721 ms) : 0, 216721
AppSec [baseline] (33.097 ms) : 0, 33097
AppSec [candidate] (32.605 ms) : 0, 32605
Debugger [baseline] (68.692 ms) : 0, 68692
Debugger [candidate] (67.574 ms) : 0, 67574
Remote Config [baseline] (616.076 µs) : 0, 616
Remote Config [candidate] (599.09 µs) : 0, 599
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.721 ms) : 0, 8721
Flare Poller [baseline] (3.803 ms) : 0, 3803
Flare Poller [candidate] (3.683 ms) : 0, 3683
ProfilingAgent [baseline] (100.471 ms) : 0, 100471
ProfilingAgent [candidate] (99.67 ms) : 0, 99670
Profiling [baseline] (101.065 ms) : 0, 101065
Profiling [candidate] (100.25 ms) : 0, 100250
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 2 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1177, 1200
. : milestone, 1188,
iast (3.281 ms) : 3235, 3326
. : milestone, 3281,
iast_FULL (6.118 ms) : 6057, 6180
. : milestone, 6118,
iast_GLOBAL (3.575 ms) : 3520, 3630
. : milestone, 3575,
profiling (2.197 ms) : 2176, 2217
. : milestone, 2197,
tracing (1.83 ms) : 1812, 1847
. : milestone, 1830,
section candidate
no_agent (1.168 ms) : 1157, 1180
. : milestone, 1168,
iast (3.188 ms) : 3147, 3230
. : milestone, 3188,
iast_FULL (5.788 ms) : 5731, 5846
. : milestone, 5788,
iast_GLOBAL (3.526 ms) : 3477, 3576
. : milestone, 3526,
profiling (2.112 ms) : 2092, 2133
. : milestone, 2112,
tracing (1.901 ms) : 1885, 1918
. : milestone, 1901,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (17.517 ms) : 17337, 17697
. : milestone, 17517,
appsec (18.496 ms) : 18304, 18688
. : milestone, 18496,
code_origins (17.421 ms) : 17250, 17592
. : milestone, 17421,
iast (18.653 ms) : 18464, 18841
. : milestone, 18653,
profiling (20.386 ms) : 20174, 20599
. : milestone, 20386,
tracing (17.501 ms) : 17329, 17673
. : milestone, 17501,
section candidate
no_agent (18.194 ms) : 18006, 18383
. : milestone, 18194,
appsec (18.788 ms) : 18601, 18975
. : milestone, 18788,
code_origins (17.449 ms) : 17276, 17623
. : milestone, 17449,
iast (17.787 ms) : 17608, 17965
. : milestone, 17787,
profiling (18.802 ms) : 18616, 18988
. : milestone, 18802,
tracing (18.66 ms) : 18470, 18849
. : milestone, 18660,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
appsec (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
iast (18.431 s) : 18431000, 18431000
. : milestone, 18431000,
iast_GLOBAL (18.123 s) : 18123000, 18123000
. : milestone, 18123000,
profiling (14.712 s) : 14712000, 14712000
. : milestone, 14712000,
tracing (14.594 s) : 14594000, 14594000
. : milestone, 14594000,
section candidate
no_agent (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
appsec (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
iast (18.26 s) : 18260000, 18260000
. : milestone, 18260000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
tracing (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~346fcb29df, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.769 ms) : 3547, 3991
. : milestone, 3769,
iast (2.256 ms) : 2187, 2326
. : milestone, 2256,
iast_GLOBAL (2.317 ms) : 2247, 2387
. : milestone, 2317,
profiling (2.095 ms) : 2039, 2151
. : milestone, 2095,
tracing (2.07 ms) : 2016, 2124
. : milestone, 2070,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.5 ms) : 2445, 2555
. : milestone, 2500,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.299 ms) : 2230, 2369
. : milestone, 2299,
profiling (2.11 ms) : 2053, 2166
. : milestone, 2110,
tracing (2.064 ms) : 2010, 2117
. : milestone, 2064,
|
Contributor
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
A bit tough to evaluate the changes but sounds good.
Should we add some tests to help with ensuring it covers the various cases and make sure we won’t introduce regressions?
Contributor
|
Giving at try at @codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca692dd159
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
@PerfectSlayer We can see the results in the TestOpt dashboard:
Alternatively, we can check by querying specifically on tests that previously did not have any codeowners (e.g. "IastSpringBootSmokeTest$WithGlobalContext" test suite on master vs this branch) For ensuring no regressions are introduced, I drafted up a quick monitor to alert on no codeowner situations; however, #10502 should already address this. |
PerfectSlayer
approved these changes
Feb 3, 2026
Contributor
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
Great! That's all good for me 👍
Thanks for the links and explainations that help me checking the changes
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit dc55309:
What to do next?
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: rejected
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
bot
merged commit 0a94e76
into
master
1033 of 1074 checks passed
gh-worker-dd-mergequeue-cf854d
bot
deleted the
sarahchen6/extract-inner-classes
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Extract inner classes when getting the test source file
Motivation
Previously when parsing the file_path to get the test source file, we weren't checking for inner classes. This led to tests such as
...SpringBootSmokeTest$WithGlobalContextfinding no source file, resulting in no codeowner. Thus, the changes in this PR should also address our missing codeowners (see master vs this branch test vis results).Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]