WIP: Implicitly merge any current non-span context when using span.attach()#10512
WIP: Implicitly merge any current non-span context when using span.attach()#10512
Conversation
4b2624e to
c65f10f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065188
Total [baseline] (8.731 s) : 0, 8731384
Agent [candidate] (1.067 s) : 0, 1066743
Total [candidate] (8.72 s) : 0, 8720227
section iast
Agent [baseline] (1.229 s) : 0, 1229238
Total [baseline] (9.382 s) : 0, 9381665
Agent [candidate] (1.23 s) : 0, 1230359
Total [candidate] (9.393 s) : 0, 9393425
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (628.178 ms) : 0, 628178
BytebuddyAgent [candidate] (629.826 ms) : 0, 629826
AgentMeter [baseline] (28.69 ms) : 0, 28690
AgentMeter [candidate] (28.87 ms) : 0, 28870
GlobalTracer [baseline] (258.171 ms) : 0, 258171
GlobalTracer [candidate] (258.388 ms) : 0, 258388
AppSec [baseline] (32.829 ms) : 0, 32829
AppSec [candidate] (32.887 ms) : 0, 32887
Debugger [baseline] (60.734 ms) : 0, 60734
Debugger [candidate] (60.919 ms) : 0, 60919
Remote Config [baseline] (623.895 µs) : 0, 624
Remote Config [candidate] (616.352 µs) : 0, 616
Telemetry [baseline] (14.801 ms) : 0, 14801
Telemetry [candidate] (12.328 ms) : 0, 12328
Flare Poller [baseline] (4.551 ms) : 0, 4551
Flare Poller [candidate] (6.106 ms) : 0, 6106
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (794.991 ms) : 0, 794991
BytebuddyAgent [candidate] (794.918 ms) : 0, 794918
AgentMeter [baseline] (11.188 ms) : 0, 11188
AgentMeter [candidate] (11.16 ms) : 0, 11160
GlobalTracer [baseline] (247.214 ms) : 0, 247214
GlobalTracer [candidate] (247.713 ms) : 0, 247713
AppSec [baseline] (33.968 ms) : 0, 33968
AppSec [candidate] (33.001 ms) : 0, 33001
Debugger [baseline] (65.61 ms) : 0, 65610
Debugger [candidate] (67.158 ms) : 0, 67158
Remote Config [baseline] (544.377 µs) : 0, 544
Remote Config [candidate] (548.551 µs) : 0, 549
Telemetry [baseline] (8.686 ms) : 0, 8686
Telemetry [candidate] (8.723 ms) : 0, 8723
Flare Poller [baseline] (3.465 ms) : 0, 3465
Flare Poller [candidate] (3.523 ms) : 0, 3523
IAST [baseline] (26.998 ms) : 0, 26998
IAST [candidate] (26.99 ms) : 0, 26990
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064786
Total [baseline] (10.975 s) : 0, 10974774
Agent [candidate] (1.068 s) : 0, 1068481
Total [candidate] (10.834 s) : 0, 10833637
section appsec
Agent [baseline] (1.239 s) : 0, 1238660
Total [baseline] (10.935 s) : 0, 10935413
Agent [candidate] (1.237 s) : 0, 1237382
Total [candidate] (10.881 s) : 0, 10880748
section iast
Agent [baseline] (1.232 s) : 0, 1232005
Total [baseline] (11.141 s) : 0, 11141160
Agent [candidate] (1.229 s) : 0, 1228722
Total [candidate] (11.221 s) : 0, 11220910
section profiling
Agent [baseline] (1.201 s) : 0, 1200874
Total [baseline] (11.078 s) : 0, 11077520
Agent [candidate] (1.188 s) : 0, 1188228
Total [candidate] (10.941 s) : 0, 10940979
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (628.655 ms) : 0, 628655
BytebuddyAgent [candidate] (628.808 ms) : 0, 628808
AgentMeter [baseline] (28.716 ms) : 0, 28716
AgentMeter [candidate] (28.727 ms) : 0, 28727
GlobalTracer [baseline] (257.843 ms) : 0, 257843
GlobalTracer [candidate] (258.999 ms) : 0, 258999
AppSec [baseline] (32.798 ms) : 0, 32798
AppSec [candidate] (33.151 ms) : 0, 33151
Debugger [baseline] (63.506 ms) : 0, 63506
Debugger [candidate] (61.166 ms) : 0, 61166
Remote Config [baseline] (617.783 µs) : 0, 618
Remote Config [candidate] (645.43 µs) : 0, 645
Telemetry [baseline] (11.56 ms) : 0, 11560
Telemetry [candidate] (13.26 ms) : 0, 13260
Flare Poller [baseline] (4.582 ms) : 0, 4582
Flare Poller [candidate] (7.079 ms) : 0, 7079
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (658.118 ms) : 0, 658118
BytebuddyAgent [candidate] (657.14 ms) : 0, 657140
AgentMeter [baseline] (11.756 ms) : 0, 11756
AgentMeter [candidate] (11.776 ms) : 0, 11776
GlobalTracer [baseline] (258.177 ms) : 0, 258177
GlobalTracer [candidate] (257.917 ms) : 0, 257917
AppSec [baseline] (167.984 ms) : 0, 167984
AppSec [candidate] (167.914 ms) : 0, 167914
Debugger [baseline] (67.432 ms) : 0, 67432
Debugger [candidate] (67.445 ms) : 0, 67445
Remote Config [baseline] (672.082 µs) : 0, 672
Remote Config [candidate] (665.706 µs) : 0, 666
Telemetry [baseline] (9.058 ms) : 0, 9058
Telemetry [candidate] (9.093 ms) : 0, 9093
Flare Poller [baseline] (3.65 ms) : 0, 3650
Flare Poller [candidate] (3.594 ms) : 0, 3594
IAST [baseline] (25.258 ms) : 0, 25258
IAST [candidate] (25.355 ms) : 0, 25355
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (796.364 ms) : 0, 796364
BytebuddyAgent [candidate] (794.38 ms) : 0, 794380
AgentMeter [baseline] (11.125 ms) : 0, 11125
AgentMeter [candidate] (11.122 ms) : 0, 11122
GlobalTracer [baseline] (248.253 ms) : 0, 248253
GlobalTracer [candidate] (247.315 ms) : 0, 247315
AppSec [baseline] (33.759 ms) : 0, 33759
AppSec [candidate] (34.614 ms) : 0, 34614
Debugger [baseline] (66.431 ms) : 0, 66431
Debugger [candidate] (65.325 ms) : 0, 65325
Remote Config [baseline] (563.945 µs) : 0, 564
Remote Config [candidate] (545.688 µs) : 0, 546
Telemetry [baseline] (8.657 ms) : 0, 8657
Telemetry [candidate] (8.65 ms) : 0, 8650
Flare Poller [baseline] (3.428 ms) : 0, 3428
Flare Poller [candidate] (3.473 ms) : 0, 3473
IAST [baseline] (26.957 ms) : 0, 26957
IAST [candidate] (26.889 ms) : 0, 26889
section profiling
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (686.362 ms) : 0, 686362
BytebuddyAgent [candidate] (680.687 ms) : 0, 680687
AgentMeter [baseline] (8.7 ms) : 0, 8700
AgentMeter [candidate] (8.603 ms) : 0, 8603
GlobalTracer [baseline] (217.796 ms) : 0, 217796
GlobalTracer [candidate] (215.712 ms) : 0, 215712
AppSec [baseline] (32.976 ms) : 0, 32976
AppSec [candidate] (32.28 ms) : 0, 32280
Debugger [baseline] (68.612 ms) : 0, 68612
Debugger [candidate] (67.256 ms) : 0, 67256
Remote Config [baseline] (629.565 µs) : 0, 630
Remote Config [candidate] (600.426 µs) : 0, 600
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.917 ms) : 0, 8917
Flare Poller [baseline] (3.808 ms) : 0, 3808
Flare Poller [candidate] (3.76 ms) : 0, 3760
ProfilingAgent [baseline] (101.527 ms) : 0, 101527
ProfilingAgent [candidate] (99.509 ms) : 0, 99509
Profiling [baseline] (102.114 ms) : 0, 102114
Profiling [candidate] (100.075 ms) : 0, 100075
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1176, 1201
. : milestone, 1189,
iast (3.152 ms) : 3105, 3198
. : milestone, 3152,
iast_FULL (5.787 ms) : 5729, 5845
. : milestone, 5787,
iast_GLOBAL (3.523 ms) : 3467, 3578
. : milestone, 3523,
profiling (2.161 ms) : 2141, 2181
. : milestone, 2161,
tracing (1.863 ms) : 1845, 1881
. : milestone, 1863,
section candidate
no_agent (1.164 ms) : 1153, 1175
. : milestone, 1164,
iast (3.119 ms) : 3077, 3160
. : milestone, 3119,
iast_FULL (5.925 ms) : 5865, 5986
. : milestone, 5925,
iast_GLOBAL (3.667 ms) : 3600, 3735
. : milestone, 3667,
profiling (2.063 ms) : 2042, 2083
. : milestone, 2063,
tracing (1.796 ms) : 1781, 1810
. : milestone, 1796,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section baseline
no_agent (18.408 ms) : 18218, 18598
. : milestone, 18408,
appsec (18.727 ms) : 18538, 18916
. : milestone, 18727,
code_origins (18.516 ms) : 18330, 18701
. : milestone, 18516,
iast (17.933 ms) : 17754, 18112
. : milestone, 17933,
profiling (18.836 ms) : 18646, 19025
. : milestone, 18836,
tracing (18.07 ms) : 17888, 18251
. : milestone, 18070,
section candidate
no_agent (16.858 ms) : 16695, 17021
. : milestone, 16858,
appsec (18.815 ms) : 18619, 19012
. : milestone, 18815,
code_origins (17.838 ms) : 17662, 18014
. : milestone, 17838,
iast (17.67 ms) : 17495, 17845
. : milestone, 17670,
profiling (18.7 ms) : 18514, 18885
. : milestone, 18700,
tracing (17.67 ms) : 17494, 17846
. : milestone, 17670,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section baseline
no_agent (15.458 s) : 15458000, 15458000
. : milestone, 15458000,
appsec (14.729 s) : 14729000, 14729000
. : milestone, 14729000,
iast (18.029 s) : 18029000, 18029000
. : milestone, 18029000,
iast_GLOBAL (17.739 s) : 17739000, 17739000
. : milestone, 17739000,
profiling (14.739 s) : 14739000, 14739000
. : milestone, 14739000,
tracing (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
section candidate
no_agent (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
appsec (14.88 s) : 14880000, 14880000
. : milestone, 14880000,
iast (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
iast_GLOBAL (17.845 s) : 17845000, 17845000
. : milestone, 17845000,
profiling (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
tracing (14.739 s) : 14739000, 14739000
. : milestone, 14739000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~c65f10f6e4, baseline=1.60.0-SNAPSHOT~71d8c2624e
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.749 ms) : 3527, 3972
. : milestone, 3749,
iast (2.273 ms) : 2203, 2343
. : milestone, 2273,
iast_GLOBAL (2.325 ms) : 2254, 2396
. : milestone, 2325,
profiling (2.518 ms) : 2353, 2683
. : milestone, 2518,
tracing (2.084 ms) : 2030, 2138
. : milestone, 2084,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.493 ms) : 2438, 2548
. : milestone, 2493,
iast (2.269 ms) : 2199, 2339
. : milestone, 2269,
iast_GLOBAL (2.306 ms) : 2236, 2377
. : milestone, 2306,
profiling (2.091 ms) : 2035, 2146
. : milestone, 2091,
tracing (2.075 ms) : 2021, 2130
. : milestone, 2075,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
❔ question: This seems to break the contract of the Context API. Merging contexts will make the newly context contains both elements from current and the new one so we might end up leaking products context once they adopt this API.
What the rationale behind this change? It feels this is trying for broken context tracking from instrumentations.
This is a draft PR, clearly marked as WIP - I'll update the description and answer questions when it's in review :) |
|
No worry, I was mostly curious about the rationale 🫣 Not trying to review an early work! |
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]