Fix Job URL format for Github Actions#10514
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075260
Total [baseline] (8.843 s) : 0, 8842811
Agent [candidate] (1.065 s) : 0, 1065068
Total [candidate] (8.735 s) : 0, 8734524
section iast
Agent [baseline] (1.231 s) : 0, 1231431
Total [baseline] (9.362 s) : 0, 9361652
Agent [candidate] (1.242 s) : 0, 1241704
Total [candidate] (9.367 s) : 0, 9367137
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (633.969 ms) : 0, 633969
BytebuddyAgent [candidate] (629.727 ms) : 0, 629727
AgentMeter [baseline] (28.954 ms) : 0, 28954
AgentMeter [candidate] (28.812 ms) : 0, 28812
GlobalTracer [baseline] (259.888 ms) : 0, 259888
GlobalTracer [candidate] (258.448 ms) : 0, 258448
AppSec [baseline] (33.084 ms) : 0, 33084
AppSec [candidate] (32.947 ms) : 0, 32947
Debugger [baseline] (62.953 ms) : 0, 62953
Debugger [candidate] (62.677 ms) : 0, 62677
Remote Config [baseline] (630.728 µs) : 0, 631
Remote Config [candidate] (603.95 µs) : 0, 604
Telemetry [baseline] (12.645 ms) : 0, 12645
Telemetry [candidate] (10.662 ms) : 0, 10662
Flare Poller [baseline] (6.288 ms) : 0, 6288
Flare Poller [candidate] (4.497 ms) : 0, 4497
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (796.08 ms) : 0, 796080
BytebuddyAgent [candidate] (803.659 ms) : 0, 803659
AgentMeter [baseline] (11.176 ms) : 0, 11176
AgentMeter [candidate] (11.43 ms) : 0, 11430
GlobalTracer [baseline] (248.139 ms) : 0, 248139
GlobalTracer [candidate] (249.577 ms) : 0, 249577
IAST [baseline] (27.042 ms) : 0, 27042
IAST [candidate] (27.302 ms) : 0, 27302
AppSec [baseline] (33.265 ms) : 0, 33265
AppSec [candidate] (33.598 ms) : 0, 33598
Debugger [baseline] (66.339 ms) : 0, 66339
Debugger [candidate] (66.636 ms) : 0, 66636
Remote Config [baseline] (550.17 µs) : 0, 550
Remote Config [candidate] (536.289 µs) : 0, 536
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.702 ms) : 0, 8702
Flare Poller [baseline] (3.496 ms) : 0, 3496
Flare Poller [candidate] (3.496 ms) : 0, 3496
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065554
Total [baseline] (10.84 s) : 0, 10840460
Agent [candidate] (1.063 s) : 0, 1062640
Total [candidate] (10.903 s) : 0, 10902518
section appsec
Agent [baseline] (1.243 s) : 0, 1242922
Total [baseline] (11.144 s) : 0, 11143532
Agent [candidate] (1.241 s) : 0, 1240662
Total [candidate] (11.095 s) : 0, 11094734
section iast
Agent [baseline] (1.233 s) : 0, 1232668
Total [baseline] (11.241 s) : 0, 11240632
Agent [candidate] (1.241 s) : 0, 1240507
Total [candidate] (11.241 s) : 0, 11240794
section profiling
Agent [baseline] (1.197 s) : 0, 1197289
Total [baseline] (10.971 s) : 0, 10971376
Agent [candidate] (1.192 s) : 0, 1191665
Total [candidate] (10.996 s) : 0, 10995606
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (629.051 ms) : 0, 629051
BytebuddyAgent [candidate] (628.228 ms) : 0, 628228
AgentMeter [baseline] (28.758 ms) : 0, 28758
AgentMeter [candidate] (28.735 ms) : 0, 28735
GlobalTracer [baseline] (257.879 ms) : 0, 257879
GlobalTracer [candidate] (257.838 ms) : 0, 257838
AppSec [baseline] (32.8 ms) : 0, 32800
AppSec [candidate] (32.846 ms) : 0, 32846
Debugger [baseline] (62.36 ms) : 0, 62360
Debugger [candidate] (61.461 ms) : 0, 61461
Remote Config [baseline] (606.968 µs) : 0, 607
Remote Config [candidate] (626.087 µs) : 0, 626
Telemetry [baseline] (11.567 ms) : 0, 11567
Telemetry [candidate] (11.789 ms) : 0, 11789
Flare Poller [baseline] (6.06 ms) : 0, 6060
Flare Poller [candidate] (4.531 ms) : 0, 4531
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (660.178 ms) : 0, 660178
BytebuddyAgent [candidate] (658.048 ms) : 0, 658048
AgentMeter [baseline] (11.772 ms) : 0, 11772
AgentMeter [candidate] (11.75 ms) : 0, 11750
GlobalTracer [baseline] (259.771 ms) : 0, 259771
GlobalTracer [candidate] (259.294 ms) : 0, 259294
AppSec [baseline] (168.644 ms) : 0, 168644
AppSec [candidate] (168.137 ms) : 0, 168137
Debugger [baseline] (67.248 ms) : 0, 67248
Debugger [candidate] (67.862 ms) : 0, 67862
Remote Config [baseline] (671.151 µs) : 0, 671
Remote Config [candidate] (685.13 µs) : 0, 685
Telemetry [baseline] (9.077 ms) : 0, 9077
Telemetry [candidate] (9.228 ms) : 0, 9228
Flare Poller [baseline] (3.623 ms) : 0, 3623
Flare Poller [candidate] (3.761 ms) : 0, 3761
IAST [baseline] (25.312 ms) : 0, 25312
IAST [candidate] (25.31 ms) : 0, 25310
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (796.219 ms) : 0, 796219
BytebuddyAgent [candidate] (802.291 ms) : 0, 802291
AgentMeter [baseline] (11.142 ms) : 0, 11142
AgentMeter [candidate] (11.411 ms) : 0, 11411
GlobalTracer [baseline] (248.459 ms) : 0, 248459
GlobalTracer [candidate] (249.495 ms) : 0, 249495
AppSec [baseline] (34.929 ms) : 0, 34929
AppSec [candidate] (33.884 ms) : 0, 33884
Debugger [baseline] (65.843 ms) : 0, 65843
Debugger [candidate] (66.809 ms) : 0, 66809
Remote Config [baseline] (542.303 µs) : 0, 542
Remote Config [candidate] (539.966 µs) : 0, 540
Telemetry [baseline] (8.703 ms) : 0, 8703
Telemetry [candidate] (8.718 ms) : 0, 8718
Flare Poller [baseline] (3.427 ms) : 0, 3427
Flare Poller [candidate] (3.458 ms) : 0, 3458
IAST [baseline] (26.915 ms) : 0, 26915
IAST [candidate] (27.267 ms) : 0, 27267
section profiling
ProfilingAgent [baseline] (100.149 ms) : 0, 100149
ProfilingAgent [candidate] (99.914 ms) : 0, 99914
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (685.736 ms) : 0, 685736
BytebuddyAgent [candidate] (682.709 ms) : 0, 682709
AgentMeter [baseline] (8.725 ms) : 0, 8725
AgentMeter [candidate] (8.624 ms) : 0, 8624
GlobalTracer [baseline] (217.472 ms) : 0, 217472
GlobalTracer [candidate] (215.89 ms) : 0, 215890
AppSec [baseline] (32.619 ms) : 0, 32619
AppSec [candidate] (32.44 ms) : 0, 32440
Debugger [baseline] (67.971 ms) : 0, 67971
Debugger [candidate] (67.65 ms) : 0, 67650
Remote Config [baseline] (604.45 µs) : 0, 604
Remote Config [candidate] (599.845 µs) : 0, 600
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (8.861 ms) : 0, 8861
Flare Poller [baseline] (3.75 ms) : 0, 3750
Flare Poller [candidate] (3.806 ms) : 0, 3806
Profiling [baseline] (100.729 ms) : 0, 100729
Profiling [candidate] (100.504 ms) : 0, 100504
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1174, 1194
. : milestone, 1184,
iast (3.076 ms) : 3035, 3118
. : milestone, 3076,
iast_FULL (6.033 ms) : 5971, 6095
. : milestone, 6033,
iast_GLOBAL (3.386 ms) : 3334, 3439
. : milestone, 3386,
profiling (2.009 ms) : 1991, 2028
. : milestone, 2009,
tracing (1.76 ms) : 1747, 1774
. : milestone, 1760,
section candidate
no_agent (1.179 ms) : 1167, 1190
. : milestone, 1179,
iast (3.193 ms) : 3151, 3236
. : milestone, 3193,
iast_FULL (5.916 ms) : 5856, 5976
. : milestone, 5916,
iast_GLOBAL (3.5 ms) : 3447, 3554
. : milestone, 3500,
profiling (2.203 ms) : 2182, 2223
. : milestone, 2203,
tracing (1.855 ms) : 1839, 1872
. : milestone, 1855,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (16.852 ms) : 16685, 17019
. : milestone, 16852,
appsec (18.199 ms) : 18018, 18380
. : milestone, 18199,
code_origins (17.621 ms) : 17443, 17798
. : milestone, 17621,
iast (17.392 ms) : 17221, 17563
. : milestone, 17392,
profiling (19.526 ms) : 19327, 19725
. : milestone, 19526,
tracing (17.715 ms) : 17539, 17891
. : milestone, 17715,
section candidate
no_agent (18.227 ms) : 18038, 18416
. : milestone, 18227,
appsec (18.493 ms) : 18307, 18679
. : milestone, 18493,
code_origins (17.636 ms) : 17461, 17811
. : milestone, 17636,
iast (17.673 ms) : 17500, 17847
. : milestone, 17673,
profiling (18.847 ms) : 18657, 19037
. : milestone, 18847,
tracing (17.932 ms) : 17754, 18110
. : milestone, 17932,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.745 ms) : 3522, 3967
. : milestone, 3745,
iast (2.242 ms) : 2173, 2310
. : milestone, 2242,
iast_GLOBAL (2.293 ms) : 2224, 2363
. : milestone, 2293,
profiling (2.083 ms) : 2029, 2138
. : milestone, 2083,
tracing (2.067 ms) : 2013, 2120
. : milestone, 2067,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.758 ms) : 3537, 3979
. : milestone, 3758,
iast (2.243 ms) : 2175, 2312
. : milestone, 2243,
iast_GLOBAL (2.293 ms) : 2224, 2362
. : milestone, 2293,
profiling (2.095 ms) : 2039, 2151
. : milestone, 2095,
tracing (2.062 ms) : 2009, 2116
. : milestone, 2062,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~52de604f3b, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (15.452 s) : 15452000, 15452000
. : milestone, 15452000,
appsec (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
iast (18.015 s) : 18015000, 18015000
. : milestone, 18015000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (15.247 s) : 15247000, 15247000
. : milestone, 15247000,
tracing (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
section candidate
no_agent (15.308 s) : 15308000, 15308000
. : milestone, 15308000,
appsec (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
iast (17.98 s) : 17980000, 17980000
. : milestone, 17980000,
iast_GLOBAL (18.164 s) : 18164000, 18164000
. : milestone, 18164000,
profiling (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
tracing (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
|
|
|
||
| // Sort by filename in descending order to get the most recent file first | ||
| workerFiles.sort( | ||
| Comparator.comparing(p -> p.getFileName().toString(), Comparator.reverseOrder())); |
There was a problem hiding this comment.
Nitpitck: we don't need to sort the entire list to find the most recent log, a single O(N) pass is enough:
Path mostRecentLog = null;
for (Path workerLog : stream) {
if (mostRecentLog == null ||
workerLog.getFileName().toString().compareTo(mostRecentLog.getFileName().toString()) > 0) {
mostRecentLog = workerLog;
}
}
if (workerLog == null) { return null; }
| if (value.contains(".")) { | ||
| try { | ||
| long longValue = (long) Double.parseDouble(value); | ||
| lastMatch = String.valueOf(longValue); |
There was a problem hiding this comment.
Since you're converting it back to String, could we just do:
int pointIdx = value.indexOf(".");
if (pointIdx != -1) {
lastMatch = value.substring(0, pointIdx);
}
I might be missing things, but looking at the regex it seems like a NumberFormatException is not possible here given how you match the group
What Does This Do
@ci.job.urltag for Github Actions with the appropriate@ci.job.idvalue. The new format ishttps://github.com/REPO_NAME/actions/runs/RUN_ID/job/JOB_IDwhile we previously were limited tohttps://github.com/REPO_NAME/commit/COMMIT_SHA/checks:JOB_CHECK_RUN_IDis present, we use it as job id.Motivation
These changes allow users to directly access CI logs with the URL provided, as well as improving the correlation between Test Optimization and CI Visibility.
Additional Notes
Validation in example project: https://github.com/DataDog/danm-testing-repo/pull/8
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-2999