Conversation
ad0f955 to
2e2e9d5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062583
Total [baseline] (8.754 s) : 0, 8754198
Agent [candidate] (1.07 s) : 0, 1069896
Total [candidate] (8.775 s) : 0, 8774677
section iast
Agent [baseline] (1.245 s) : 0, 1245094
Total [baseline] (9.448 s) : 0, 9447847
Agent [candidate] (1.239 s) : 0, 1239184
Total [candidate] (9.375 s) : 0, 9374642
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (626.379 ms) : 0, 626379
BytebuddyAgent [candidate] (633.442 ms) : 0, 633442
AgentMeter [baseline] (28.733 ms) : 0, 28733
AgentMeter [candidate] (29.149 ms) : 0, 29149
GlobalTracer [baseline] (257.322 ms) : 0, 257322
GlobalTracer [candidate] (258.176 ms) : 0, 258176
AppSec [baseline] (32.853 ms) : 0, 32853
AppSec [candidate] (32.839 ms) : 0, 32839
Debugger [baseline] (60.083 ms) : 0, 60083
Debugger [candidate] (61.097 ms) : 0, 61097
Remote Config [baseline] (623.334 µs) : 0, 623
Remote Config [candidate] (617.593 µs) : 0, 618
Telemetry [baseline] (14.732 ms) : 0, 14732
Telemetry [candidate] (11.556 ms) : 0, 11556
Flare Poller [baseline] (5.387 ms) : 0, 5387
Flare Poller [candidate] (6.241 ms) : 0, 6241
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (805.893 ms) : 0, 805893
BytebuddyAgent [candidate] (802.256 ms) : 0, 802256
AgentMeter [baseline] (11.563 ms) : 0, 11563
AgentMeter [candidate] (11.518 ms) : 0, 11518
GlobalTracer [baseline] (250.163 ms) : 0, 250163
GlobalTracer [candidate] (248.955 ms) : 0, 248955
IAST [baseline] (27.386 ms) : 0, 27386
IAST [candidate] (27.076 ms) : 0, 27076
AppSec [baseline] (34.429 ms) : 0, 34429
AppSec [candidate] (35.146 ms) : 0, 35146
Debugger [baseline] (66.157 ms) : 0, 66157
Debugger [candidate] (64.656 ms) : 0, 64656
Remote Config [baseline] (548.609 µs) : 0, 549
Remote Config [candidate] (551.572 µs) : 0, 552
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.764 ms) : 0, 8764
Flare Poller [baseline] (3.583 ms) : 0, 3583
Flare Poller [candidate] (3.501 ms) : 0, 3501
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063433
Total [baseline] (10.927 s) : 0, 10926839
Agent [candidate] (1.067 s) : 0, 1067469
Total [candidate] (11.118 s) : 0, 11118379
section appsec
Agent [baseline] (1.247 s) : 0, 1246877
Total [baseline] (11.156 s) : 0, 11155997
Agent [candidate] (1.244 s) : 0, 1243528
Total [candidate] (11.109 s) : 0, 11109332
section iast
Agent [baseline] (1.232 s) : 0, 1232009
Total [baseline] (11.222 s) : 0, 11221501
Agent [candidate] (1.234 s) : 0, 1234437
Total [candidate] (11.22 s) : 0, 11219892
section profiling
Agent [baseline] (1.189 s) : 0, 1189191
Total [baseline] (10.985 s) : 0, 10985195
Agent [candidate] (1.191 s) : 0, 1190678
Total [candidate] (11.053 s) : 0, 11053286
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (627.735 ms) : 0, 627735
BytebuddyAgent [candidate] (627.726 ms) : 0, 627726
AgentMeter [baseline] (28.823 ms) : 0, 28823
AgentMeter [candidate] (28.85 ms) : 0, 28850
GlobalTracer [baseline] (257.352 ms) : 0, 257352
GlobalTracer [candidate] (259.272 ms) : 0, 259272
AppSec [baseline] (32.766 ms) : 0, 32766
AppSec [candidate] (33.02 ms) : 0, 33020
Debugger [baseline] (64.357 ms) : 0, 64357
Debugger [candidate] (63.207 ms) : 0, 63207
Remote Config [baseline] (614.707 µs) : 0, 615
Remote Config [candidate] (611.567 µs) : 0, 612
Telemetry [baseline] (9.942 ms) : 0, 9942
Telemetry [candidate] (13.72 ms) : 0, 13720
Flare Poller [baseline] (5.341 ms) : 0, 5341
Flare Poller [candidate] (4.542 ms) : 0, 4542
section appsec
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (662.908 ms) : 0, 662908
BytebuddyAgent [candidate] (660.557 ms) : 0, 660557
AgentMeter [baseline] (11.906 ms) : 0, 11906
AgentMeter [candidate] (11.886 ms) : 0, 11886
GlobalTracer [baseline] (259.816 ms) : 0, 259816
GlobalTracer [candidate] (259.599 ms) : 0, 259599
IAST [baseline] (25.47 ms) : 0, 25470
IAST [candidate] (25.452 ms) : 0, 25452
AppSec [baseline] (168.637 ms) : 0, 168637
AppSec [candidate] (168.457 ms) : 0, 168457
Debugger [baseline] (67.685 ms) : 0, 67685
Debugger [candidate] (67.327 ms) : 0, 67327
Remote Config [baseline] (685.261 µs) : 0, 685
Remote Config [candidate] (694.445 µs) : 0, 694
Telemetry [baseline] (9.312 ms) : 0, 9312
Telemetry [candidate] (9.146 ms) : 0, 9146
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.711 ms) : 0, 3711
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (795.876 ms) : 0, 795876
BytebuddyAgent [candidate] (798.09 ms) : 0, 798090
AgentMeter [baseline] (11.274 ms) : 0, 11274
AgentMeter [candidate] (11.283 ms) : 0, 11283
GlobalTracer [baseline] (248.08 ms) : 0, 248080
GlobalTracer [candidate] (248.503 ms) : 0, 248503
IAST [baseline] (27.045 ms) : 0, 27045
IAST [candidate] (26.923 ms) : 0, 26923
AppSec [baseline] (33.068 ms) : 0, 33068
AppSec [candidate] (33.81 ms) : 0, 33810
Debugger [baseline] (67.568 ms) : 0, 67568
Debugger [candidate] (66.607 ms) : 0, 66607
Remote Config [baseline] (533.303 µs) : 0, 533
Remote Config [candidate] (541.885 µs) : 0, 542
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.718 ms) : 0, 8718
Flare Poller [baseline] (3.472 ms) : 0, 3472
Flare Poller [candidate] (3.461 ms) : 0, 3461
section profiling
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (680.888 ms) : 0, 680888
BytebuddyAgent [candidate] (682.752 ms) : 0, 682752
AgentMeter [baseline] (8.709 ms) : 0, 8709
AgentMeter [candidate] (8.753 ms) : 0, 8753
GlobalTracer [baseline] (215.734 ms) : 0, 215734
GlobalTracer [candidate] (216.082 ms) : 0, 216082
AppSec [baseline] (32.44 ms) : 0, 32440
AppSec [candidate] (32.244 ms) : 0, 32244
Debugger [baseline] (67.709 ms) : 0, 67709
Debugger [candidate] (67.834 ms) : 0, 67834
Remote Config [baseline] (596.725 µs) : 0, 597
Remote Config [candidate] (600.291 µs) : 0, 600
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (8.809 ms) : 0, 8809
Flare Poller [baseline] (3.808 ms) : 0, 3808
Flare Poller [candidate] (3.738 ms) : 0, 3738
ProfilingAgent [baseline] (99.699 ms) : 0, 99699
ProfilingAgent [candidate] (98.896 ms) : 0, 98896
Profiling [baseline] (100.277 ms) : 0, 100277
Profiling [candidate] (99.457 ms) : 0, 99457
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.188 ms) : 3142, 3235
. : milestone, 3188,
iast_FULL (5.968 ms) : 5908, 6028
. : milestone, 5968,
iast_GLOBAL (3.485 ms) : 3433, 3538
. : milestone, 3485,
profiling (2.398 ms) : 2375, 2422
. : milestone, 2398,
tracing (1.816 ms) : 1801, 1831
. : milestone, 1816,
section candidate
no_agent (1.193 ms) : 1181, 1205
. : milestone, 1193,
iast (3.021 ms) : 2987, 3055
. : milestone, 3021,
iast_FULL (6.047 ms) : 5985, 6109
. : milestone, 6047,
iast_GLOBAL (3.56 ms) : 3502, 3617
. : milestone, 3560,
profiling (1.992 ms) : 1975, 2010
. : milestone, 1992,
tracing (1.848 ms) : 1831, 1865
. : milestone, 1848,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (19.247 ms) : 19054, 19441
. : milestone, 19247,
appsec (18.541 ms) : 18351, 18731
. : milestone, 18541,
code_origins (17.395 ms) : 17224, 17566
. : milestone, 17395,
iast (17.495 ms) : 17323, 17668
. : milestone, 17495,
profiling (18.54 ms) : 18351, 18729
. : milestone, 18540,
tracing (17.843 ms) : 17666, 18020
. : milestone, 17843,
section candidate
no_agent (19.236 ms) : 19040, 19433
. : milestone, 19236,
appsec (18.54 ms) : 18353, 18728
. : milestone, 18540,
code_origins (17.347 ms) : 17173, 17522
. : milestone, 17347,
iast (18.63 ms) : 18443, 18818
. : milestone, 18630,
profiling (19.752 ms) : 19553, 19951
. : milestone, 19752,
tracing (17.789 ms) : 17610, 17968
. : milestone, 17789,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
appsec (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
iast (18.282 s) : 18282000, 18282000
. : milestone, 18282000,
iast_GLOBAL (17.85 s) : 17850000, 17850000
. : milestone, 17850000,
profiling (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
tracing (14.793 s) : 14793000, 14793000
. : milestone, 14793000,
section candidate
no_agent (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
appsec (14.482 s) : 14482000, 14482000
. : milestone, 14482000,
iast (18.231 s) : 18231000, 18231000
. : milestone, 18231000,
iast_GLOBAL (17.871 s) : 17871000, 17871000
. : milestone, 17871000,
profiling (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
tracing (14.772 s) : 14772000, 14772000
. : milestone, 14772000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~2bdb4d4cfc, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.485 ms) : 2431, 2540
. : milestone, 2485,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.288 ms) : 2219, 2357
. : milestone, 2288,
profiling (2.1 ms) : 2043, 2156
. : milestone, 2100,
tracing (2.063 ms) : 2010, 2117
. : milestone, 2063,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.753 ms) : 3534, 3972
. : milestone, 3753,
iast (2.255 ms) : 2186, 2324
. : milestone, 2255,
iast_GLOBAL (2.297 ms) : 2228, 2366
. : milestone, 2297,
profiling (2.117 ms) : 2060, 2174
. : milestone, 2117,
tracing (2.059 ms) : 2006, 2113
. : milestone, 2059,
|
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, left minor comment and one question.
| java-version: | | ||
| 8 | ||
| 11 | ||
| 17 | ||
| 21 |
There was a problem hiding this comment.
Just curious why we may need more than one java for Gradle lockfiles update?
There was a problem hiding this comment.
I wonder what happens for some modules need specific Java version?
It might not be needed for dependency resolution. I will give it another try as not specifying such JDK versions we decrease the maintenance burden.
There was a problem hiding this comment.
Yep, we can try to use 21? It should support all previous versions I hope...
There was a problem hiding this comment.
Yes, it seems to be running but I can properly test with the current master failure.
I refactor the workflow to use a one-pass upgrade. It should be faster too.
There was a problem hiding this comment.
It seems to be failing with Xerces parsing error.... No sure if it's related to some dependencies or the setup.
https://github.com/DataDog/dd-trace-java/actions/runs/21703975990/job/62590444230#step:6:584
There was a problem hiding this comment.
I can confirm it was the issue.
@bric3 Do you know why we still need the following setup:
JAVA_HOME=$JAVA_HOME_8_X64 \
JAVA_8_HOME=$JAVA_HOME_8_X64 \
JAVA_11_HOME=$JAVA_HOME_11_X64 \
JAVA_17_HOME=$JAVA_HOME_17_X64 \
JAVA_21_HOME=$JAVA_HOME_21_X64 \
JAVA_25_HOME=$JAVA_HOME_25_X64 \and why the usual Java setup is not enough?
- uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
distribution: 'temurin'
java-version: '21'
cache: 'gradle'a57442f to
3a0623d
Compare
| # - uses: DataDog/dd-octo-sts-action@acaa02eee7e3bb0839e4272dacb37b8f3b58ba80 # v1.0.3 | ||
| # id: octo-sts | ||
| # with: | ||
| # scope: DataDog/dd-trace-java | ||
| # policy: self.update-gradle-dependencies.create-pr |
There was a problem hiding this comment.
I assume this will be uncommented before merging? Otherwise looks good!
There was a problem hiding this comment.
Yes, it's containing few changes (like the additionnal trigger) to test it on my branch.
I just pushed it late as I were waiting for master to build again.
3a0623d to
957d0cc
Compare
What Does This Do
This PR splits the Gradle lock update into two PRs:
Additionally, it improves the JDK setup, gradle cache and generated PR description.
Motivation
The current workflow updates all 516 lock files in a single PR, which creates large PRs that are difficult to review and mixes unrelated dependency changes (core vs instrumentation). Splitting into two jobs creates smaller, focused PRs (77 files for core, 439 files for instrumentation) and allows independent review and merge of each category.
Additional Notes
I tested the Java setup and the build works fine. But the PR creation requires to be run from
masterto get the proper token.Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]