Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Run
startup,load, anddacapobenchmarks on the merge queue instead of for every PR push. Allow these benchmarks to be run with manual triggers or by setting the CI variableBENCHMARKS=true.Motivation
By migrating these benchmarks to the merge queue, we can greatly reduce CI runtime (from ~60 min to ~35 min) and support faster development experiences. At the same time, however, we don't want to lose benchmarking ability nor merge in unknown regressions.
Additional Notes
We should ensure existing SLOs to block PRs that introduce major regressions are updated. We can also consider adding a line in the default PR description to suggest manually running benchmarks before adding to the merge queue.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]