Resources should be closed in reverse order.#10532
Draft
AlexeyKuznetsov-DD wants to merge 1 commit intomasterfrom
Draft
Resources should be closed in reverse order.#10532AlexeyKuznetsov-DD wants to merge 1 commit intomasterfrom
AlexeyKuznetsov-DD wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071995
Total [baseline] (8.787 s) : 0, 8787402
Agent [candidate] (1.063 s) : 0, 1062569
Total [candidate] (8.749 s) : 0, 8748804
section iast
Agent [baseline] (1.246 s) : 0, 1245564
Total [baseline] (9.505 s) : 0, 9504959
Agent [candidate] (1.25 s) : 0, 1249830
Total [candidate] (9.428 s) : 0, 9428240
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (632.101 ms) : 0, 632101
BytebuddyAgent [candidate] (628.769 ms) : 0, 628769
AgentMeter [baseline] (29.092 ms) : 0, 29092
AgentMeter [candidate] (28.756 ms) : 0, 28756
GlobalTracer [baseline] (259.2 ms) : 0, 259200
GlobalTracer [candidate] (257.254 ms) : 0, 257254
AppSec [baseline] (33.119 ms) : 0, 33119
AppSec [candidate] (32.658 ms) : 0, 32658
Debugger [baseline] (60.948 ms) : 0, 60948
Debugger [candidate] (59.447 ms) : 0, 59447
Remote Config [baseline] (641.712 µs) : 0, 642
Remote Config [candidate] (616.904 µs) : 0, 617
Telemetry [baseline] (11.584 ms) : 0, 11584
Telemetry [candidate] (11.496 ms) : 0, 11496
Flare Poller [baseline] (8.598 ms) : 0, 8598
Flare Poller [candidate] (6.947 ms) : 0, 6947
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (805.439 ms) : 0, 805439
BytebuddyAgent [candidate] (809.732 ms) : 0, 809732
AgentMeter [baseline] (11.565 ms) : 0, 11565
AgentMeter [candidate] (11.779 ms) : 0, 11779
GlobalTracer [baseline] (250.284 ms) : 0, 250284
GlobalTracer [candidate] (250.859 ms) : 0, 250859
AppSec [baseline] (33.601 ms) : 0, 33601
AppSec [candidate] (35.116 ms) : 0, 35116
Debugger [baseline] (67.849 ms) : 0, 67849
Debugger [candidate] (65.339 ms) : 0, 65339
Remote Config [baseline] (549.127 µs) : 0, 549
Remote Config [candidate] (553.501 µs) : 0, 554
Telemetry [baseline] (8.743 ms) : 0, 8743
Telemetry [candidate] (8.697 ms) : 0, 8697
Flare Poller [baseline] (3.513 ms) : 0, 3513
Flare Poller [candidate] (3.488 ms) : 0, 3488
IAST [baseline] (27.355 ms) : 0, 27355
IAST [candidate] (27.436 ms) : 0, 27436
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065652
Total [baseline] (10.834 s) : 0, 10833540
Agent [candidate] (1.074 s) : 0, 1073875
Total [candidate] (10.88 s) : 0, 10880463
section appsec
Agent [baseline] (1.246 s) : 0, 1246203
Total [baseline] (11.046 s) : 0, 11046425
Agent [candidate] (1.241 s) : 0, 1241216
Total [candidate] (11.071 s) : 0, 11070648
section iast
Agent [baseline] (1.236 s) : 0, 1235648
Total [baseline] (11.17 s) : 0, 11169851
Agent [candidate] (1.245 s) : 0, 1244936
Total [candidate] (11.264 s) : 0, 11264044
section profiling
Agent [baseline] (1.193 s) : 0, 1193198
Total [baseline] (11.081 s) : 0, 11080510
Agent [candidate] (1.19 s) : 0, 1190478
Total [candidate] (11.016 s) : 0, 11015568
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (628.03 ms) : 0, 628030
BytebuddyAgent [candidate] (633.267 ms) : 0, 633267
AgentMeter [baseline] (28.871 ms) : 0, 28871
AgentMeter [candidate] (29.205 ms) : 0, 29205
GlobalTracer [baseline] (257.749 ms) : 0, 257749
GlobalTracer [candidate] (259.92 ms) : 0, 259920
AppSec [baseline] (32.843 ms) : 0, 32843
AppSec [candidate] (33.136 ms) : 0, 33136
Debugger [baseline] (61.757 ms) : 0, 61757
Debugger [candidate] (63.18 ms) : 0, 63180
Remote Config [baseline] (614.846 µs) : 0, 615
Remote Config [candidate] (611.671 µs) : 0, 612
Telemetry [baseline] (12.943 ms) : 0, 12943
Telemetry [candidate] (11.542 ms) : 0, 11542
Flare Poller [baseline] (6.172 ms) : 0, 6172
Flare Poller [candidate] (6.2 ms) : 0, 6200
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (662.268 ms) : 0, 662268
BytebuddyAgent [candidate] (659.045 ms) : 0, 659045
AgentMeter [baseline] (11.941 ms) : 0, 11941
AgentMeter [candidate] (11.902 ms) : 0, 11902
GlobalTracer [baseline] (259.746 ms) : 0, 259746
GlobalTracer [candidate] (259.317 ms) : 0, 259317
AppSec [baseline] (168.84 ms) : 0, 168840
AppSec [candidate] (168.511 ms) : 0, 168511
Debugger [baseline] (67.903 ms) : 0, 67903
Debugger [candidate] (67.23 ms) : 0, 67230
Remote Config [baseline] (669.255 µs) : 0, 669
Remote Config [candidate] (670.969 µs) : 0, 671
Telemetry [baseline] (9.114 ms) : 0, 9114
Telemetry [candidate] (9.055 ms) : 0, 9055
Flare Poller [baseline] (3.685 ms) : 0, 3685
Flare Poller [candidate] (3.664 ms) : 0, 3664
IAST [baseline] (25.436 ms) : 0, 25436
IAST [candidate] (25.181 ms) : 0, 25181
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (798.526 ms) : 0, 798526
BytebuddyAgent [candidate] (804.831 ms) : 0, 804831
AgentMeter [baseline] (11.278 ms) : 0, 11278
AgentMeter [candidate] (11.422 ms) : 0, 11422
GlobalTracer [baseline] (248.795 ms) : 0, 248795
GlobalTracer [candidate] (250.057 ms) : 0, 250057
AppSec [baseline] (33.845 ms) : 0, 33845
AppSec [candidate] (34.928 ms) : 0, 34928
Debugger [baseline] (67.008 ms) : 0, 67008
Debugger [candidate] (66.782 ms) : 0, 66782
Remote Config [baseline] (548.101 µs) : 0, 548
Remote Config [candidate] (560.491 µs) : 0, 560
Telemetry [baseline] (8.595 ms) : 0, 8595
Telemetry [candidate] (8.732 ms) : 0, 8732
Flare Poller [baseline] (3.404 ms) : 0, 3404
Flare Poller [candidate] (3.485 ms) : 0, 3485
IAST [baseline] (27.071 ms) : 0, 27071
IAST [candidate] (27.259 ms) : 0, 27259
section profiling
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (683.214 ms) : 0, 683214
BytebuddyAgent [candidate] (682.002 ms) : 0, 682002
AgentMeter [baseline] (8.774 ms) : 0, 8774
AgentMeter [candidate] (8.776 ms) : 0, 8776
GlobalTracer [baseline] (216.45 ms) : 0, 216450
GlobalTracer [candidate] (215.951 ms) : 0, 215951
AppSec [baseline] (32.483 ms) : 0, 32483
AppSec [candidate] (32.453 ms) : 0, 32453
Debugger [baseline] (67.944 ms) : 0, 67944
Debugger [candidate] (67.416 ms) : 0, 67416
Remote Config [baseline] (592.615 µs) : 0, 593
Remote Config [candidate] (604.469 µs) : 0, 604
Telemetry [baseline] (8.809 ms) : 0, 8809
Telemetry [candidate] (8.854 ms) : 0, 8854
Flare Poller [baseline] (3.759 ms) : 0, 3759
Flare Poller [candidate] (3.758 ms) : 0, 3758
ProfilingAgent [baseline] (99.922 ms) : 0, 99922
ProfilingAgent [candidate] (99.522 ms) : 0, 99522
Profiling [baseline] (100.514 ms) : 0, 100514
Profiling [candidate] (100.106 ms) : 0, 100106
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 4 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section baseline
no_agent (1.195 ms) : 1184, 1207
. : milestone, 1195,
iast (3.229 ms) : 3189, 3269
. : milestone, 3229,
iast_FULL (5.955 ms) : 5894, 6016
. : milestone, 5955,
iast_GLOBAL (3.784 ms) : 3724, 3843
. : milestone, 3784,
profiling (2.077 ms) : 2058, 2096
. : milestone, 2077,
tracing (1.75 ms) : 1736, 1764
. : milestone, 1750,
section candidate
no_agent (1.186 ms) : 1175, 1198
. : milestone, 1186,
iast (3.269 ms) : 3220, 3318
. : milestone, 3269,
iast_FULL (5.897 ms) : 5838, 5956
. : milestone, 5897,
iast_GLOBAL (3.556 ms) : 3496, 3615
. : milestone, 3556,
profiling (2.045 ms) : 2027, 2063
. : milestone, 2045,
tracing (1.776 ms) : 1760, 1792
. : milestone, 1776,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section baseline
no_agent (18.97 ms) : 18784, 19157
. : milestone, 18970,
appsec (18.492 ms) : 18303, 18681
. : milestone, 18492,
code_origins (17.645 ms) : 17472, 17819
. : milestone, 17645,
iast (17.609 ms) : 17435, 17783
. : milestone, 17609,
profiling (20.73 ms) : 20521, 20938
. : milestone, 20730,
tracing (17.555 ms) : 17382, 17728
. : milestone, 17555,
section candidate
no_agent (19.302 ms) : 19107, 19498
. : milestone, 19302,
appsec (20.751 ms) : 20542, 20960
. : milestone, 20751,
code_origins (17.918 ms) : 17737, 18100
. : milestone, 17918,
iast (18.552 ms) : 18365, 18738
. : milestone, 18552,
profiling (19.033 ms) : 18844, 19223
. : milestone, 19033,
tracing (17.751 ms) : 17576, 17925
. : milestone, 17751,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section baseline
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (14.787 s) : 14787000, 14787000
. : milestone, 14787000,
iast (18.509 s) : 18509000, 18509000
. : milestone, 18509000,
iast_GLOBAL (18.126 s) : 18126000, 18126000
. : milestone, 18126000,
profiling (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
tracing (14.803 s) : 14803000, 14803000
. : milestone, 14803000,
section candidate
no_agent (15.328 s) : 15328000, 15328000
. : milestone, 15328000,
appsec (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
iast (18.1 s) : 18100000, 18100000
. : milestone, 18100000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
tracing (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~18b71b9fe5, baseline=1.60.0-SNAPSHOT~a6411dddeb
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.747 ms) : 3527, 3967
. : milestone, 3747,
iast (2.25 ms) : 2181, 2319
. : milestone, 2250,
iast_GLOBAL (2.286 ms) : 2217, 2355
. : milestone, 2286,
profiling (2.085 ms) : 2030, 2139
. : milestone, 2085,
tracing (2.051 ms) : 1998, 2104
. : milestone, 2051,
section candidate
no_agent (1.472 ms) : 1460, 1484
. : milestone, 1472,
appsec (3.685 ms) : 3471, 3900
. : milestone, 3685,
iast (2.249 ms) : 2180, 2317
. : milestone, 2249,
iast_GLOBAL (2.288 ms) : 2219, 2357
. : milestone, 2288,
profiling (2.139 ms) : 2080, 2198
. : milestone, 2139,
tracing (2.05 ms) : 1997, 2103
. : milestone, 2050,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Trying to fix Redisson test that hanged on CI.
Motivation
Green CI.
Additional Notes
Test hanged on CI with the follwing thread dump:
There is no obvious root cause, but I noticed that:
redisServer -> redissonClient -> lowLevelRedisClient,redissonClient -> lowLevelRedisClient -> redisServer.It is recommended to clear resources in reverse order. That may potentially fix hanged test.