Update PR description with merge queue information#10533
Update PR description with merge queue information#10533sarahchen6 wants to merge 1 commit intomasterfrom
Conversation
| - Format the title [according the contribution guidelines](https://github.com/DataDog/dd-trace-java/blob/master/CONTRIBUTING.md#title-format) | ||
| - Assign the `type:` and (`comp:` or `inst:`) labels in addition to [any useful labels](https://github.com/DataDog/dd-trace-java/blob/master/CONTRIBUTING.md#labels) | ||
| - Don't use `close`, `fix` or any [linking keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) when referencing an issue. | ||
| ***Note:*** **Once your PR is ready to merge, add it to the merge queue by commenting `/merge`.** `/merge -c` cancels the queue request. For more information, see [this doc](https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/3121612126/MergeQueue). |
There was a problem hiding this comment.
Another helpful command is that /merge -f --reason "reason" skips merge queue checks. Not sure if we should explicitly mention this though.
There was a problem hiding this comment.
I guess most of developers should be responsible :)
So I guess it make sense to add this command to description too.
And it will be visible to all, so we can always ask "Why?"
There was a problem hiding this comment.
I would put the /merge instruction by the end of the checklist. Doing so, you make sure they go through 😇
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062986
Total [baseline] (8.795 s) : 0, 8794566
Agent [candidate] (1.081 s) : 0, 1080874
Total [candidate] (8.779 s) : 0, 8779055
section iast
Agent [baseline] (1.239 s) : 0, 1238602
Total [baseline] (9.432 s) : 0, 9432427
Agent [candidate] (1.235 s) : 0, 1234944
Total [candidate] (9.412 s) : 0, 9412083
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (628.304 ms) : 0, 628304
BytebuddyAgent [candidate] (639.564 ms) : 0, 639564
AgentMeter [baseline] (28.936 ms) : 0, 28936
AgentMeter [candidate] (29.431 ms) : 0, 29431
GlobalTracer [baseline] (258.197 ms) : 0, 258197
GlobalTracer [candidate] (261.141 ms) : 0, 261141
AppSec [baseline] (32.776 ms) : 0, 32776
AppSec [candidate] (33.423 ms) : 0, 33423
Debugger [baseline] (61.574 ms) : 0, 61574
Debugger [candidate] (61.259 ms) : 0, 61259
Remote Config [baseline] (610.02 µs) : 0, 610
Remote Config [candidate] (639.255 µs) : 0, 639
Telemetry [baseline] (11.377 ms) : 0, 11377
Telemetry [candidate] (12.321 ms) : 0, 12321
Flare Poller [baseline] (4.608 ms) : 0, 4608
Flare Poller [candidate] (6.096 ms) : 0, 6096
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (800.915 ms) : 0, 800915
BytebuddyAgent [candidate] (797.668 ms) : 0, 797668
AgentMeter [baseline] (11.492 ms) : 0, 11492
AgentMeter [candidate] (11.267 ms) : 0, 11267
GlobalTracer [baseline] (249.097 ms) : 0, 249097
GlobalTracer [candidate] (248.412 ms) : 0, 248412
AppSec [baseline] (34.134 ms) : 0, 34134
AppSec [candidate] (34.235 ms) : 0, 34235
Debugger [baseline] (66.243 ms) : 0, 66243
Debugger [candidate] (66.827 ms) : 0, 66827
Remote Config [baseline] (548.911 µs) : 0, 549
Remote Config [candidate] (540.624 µs) : 0, 541
Telemetry [baseline] (8.731 ms) : 0, 8731
Telemetry [candidate] (8.743 ms) : 0, 8743
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (3.52 ms) : 0, 3520
IAST [baseline] (27.212 ms) : 0, 27212
IAST [candidate] (27.027 ms) : 0, 27027
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068460
Total [baseline] (10.891 s) : 0, 10891491
Agent [candidate] (1.067 s) : 0, 1067219
Total [candidate] (10.891 s) : 0, 10890642
section appsec
Agent [baseline] (1.239 s) : 0, 1238968
Total [baseline] (11.05 s) : 0, 11050115
Agent [candidate] (1.246 s) : 0, 1246095
Total [candidate] (11.039 s) : 0, 11039229
section iast
Agent [baseline] (1.234 s) : 0, 1233521
Total [baseline] (11.263 s) : 0, 11262564
Agent [candidate] (1.239 s) : 0, 1239337
Total [candidate] (11.288 s) : 0, 11288081
section profiling
Agent [baseline] (1.195 s) : 0, 1194571
Total [baseline] (11.059 s) : 0, 11059172
Agent [candidate] (1.193 s) : 0, 1192712
Total [candidate] (11.023 s) : 0, 11022987
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (629.878 ms) : 0, 629878
BytebuddyAgent [candidate] (628.964 ms) : 0, 628964
AgentMeter [baseline] (28.955 ms) : 0, 28955
AgentMeter [candidate] (28.863 ms) : 0, 28863
GlobalTracer [baseline] (258.767 ms) : 0, 258767
GlobalTracer [candidate] (258.146 ms) : 0, 258146
AppSec [baseline] (33.014 ms) : 0, 33014
AppSec [candidate] (32.717 ms) : 0, 32717
Debugger [baseline] (65.358 ms) : 0, 65358
Debugger [candidate] (62.658 ms) : 0, 62658
Remote Config [baseline] (608.825 µs) : 0, 609
Remote Config [candidate] (768.087 µs) : 0, 768
Telemetry [baseline] (11.476 ms) : 0, 11476
Telemetry [candidate] (13.84 ms) : 0, 13840
Flare Poller [baseline] (3.796 ms) : 0, 3796
Flare Poller [candidate] (4.567 ms) : 0, 4567
section appsec
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (657.431 ms) : 0, 657431
BytebuddyAgent [candidate] (662.617 ms) : 0, 662617
AgentMeter [baseline] (11.885 ms) : 0, 11885
AgentMeter [candidate] (11.94 ms) : 0, 11940
GlobalTracer [baseline] (258.911 ms) : 0, 258911
GlobalTracer [candidate] (259.897 ms) : 0, 259897
AppSec [baseline] (167.963 ms) : 0, 167963
AppSec [candidate] (168.951 ms) : 0, 168951
Debugger [baseline] (67.498 ms) : 0, 67498
Debugger [candidate] (67.138 ms) : 0, 67138
Remote Config [baseline] (658.467 µs) : 0, 658
Remote Config [candidate] (691.781 µs) : 0, 692
Telemetry [baseline] (9.073 ms) : 0, 9073
Telemetry [candidate] (9.05 ms) : 0, 9050
Flare Poller [baseline] (3.657 ms) : 0, 3657
Flare Poller [candidate] (3.631 ms) : 0, 3631
IAST [baseline] (25.37 ms) : 0, 25370
IAST [candidate] (25.307 ms) : 0, 25307
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (796.487 ms) : 0, 796487
BytebuddyAgent [candidate] (801.443 ms) : 0, 801443
AgentMeter [baseline] (11.27 ms) : 0, 11270
AgentMeter [candidate] (11.291 ms) : 0, 11291
GlobalTracer [baseline] (248.531 ms) : 0, 248531
GlobalTracer [candidate] (249.227 ms) : 0, 249227
AppSec [baseline] (33.876 ms) : 0, 33876
AppSec [candidate] (34.104 ms) : 0, 34104
Debugger [baseline] (67.125 ms) : 0, 67125
Debugger [candidate] (66.99 ms) : 0, 66990
Remote Config [baseline] (545.307 µs) : 0, 545
Remote Config [candidate] (543.244 µs) : 0, 543
Telemetry [baseline] (8.627 ms) : 0, 8627
Telemetry [candidate] (8.683 ms) : 0, 8683
Flare Poller [baseline] (3.484 ms) : 0, 3484
Flare Poller [candidate] (3.421 ms) : 0, 3421
IAST [baseline] (27.011 ms) : 0, 27011
IAST [candidate] (26.972 ms) : 0, 26972
section profiling
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (684.492 ms) : 0, 684492
BytebuddyAgent [candidate] (682.929 ms) : 0, 682929
AgentMeter [baseline] (8.777 ms) : 0, 8777
AgentMeter [candidate] (8.729 ms) : 0, 8729
GlobalTracer [baseline] (216.479 ms) : 0, 216479
GlobalTracer [candidate] (216.195 ms) : 0, 216195
AppSec [baseline] (32.606 ms) : 0, 32606
AppSec [candidate] (32.467 ms) : 0, 32467
Debugger [baseline] (68.391 ms) : 0, 68391
Debugger [candidate] (67.777 ms) : 0, 67777
Remote Config [baseline] (596.233 µs) : 0, 596
Remote Config [candidate] (601.542 µs) : 0, 602
Telemetry [baseline] (8.83 ms) : 0, 8830
Telemetry [candidate] (8.811 ms) : 0, 8811
Flare Poller [baseline] (3.728 ms) : 0, 3728
Flare Poller [candidate] (3.784 ms) : 0, 3784
ProfilingAgent [baseline] (99.412 ms) : 0, 99412
ProfilingAgent [candidate] (100.325 ms) : 0, 100325
Profiling [baseline] (99.981 ms) : 0, 99981
Profiling [candidate] (100.894 ms) : 0, 100894
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (1.179 ms) : 1168, 1190
. : milestone, 1179,
iast (3.176 ms) : 3133, 3218
. : milestone, 3176,
iast_FULL (6.287 ms) : 6221, 6353
. : milestone, 6287,
iast_GLOBAL (3.518 ms) : 3468, 3567
. : milestone, 3518,
profiling (2.053 ms) : 2036, 2070
. : milestone, 2053,
tracing (1.767 ms) : 1752, 1782
. : milestone, 1767,
section candidate
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.118 ms) : 3077, 3159
. : milestone, 3118,
iast_FULL (6.011 ms) : 5951, 6072
. : milestone, 6011,
iast_GLOBAL (3.554 ms) : 3491, 3616
. : milestone, 3554,
profiling (2.078 ms) : 2060, 2096
. : milestone, 2078,
tracing (1.804 ms) : 1789, 1819
. : milestone, 1804,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (18.292 ms) : 18103, 18481
. : milestone, 18292,
appsec (18.28 ms) : 18094, 18466
. : milestone, 18280,
code_origins (17.766 ms) : 17592, 17941
. : milestone, 17766,
iast (17.634 ms) : 17455, 17813
. : milestone, 17634,
profiling (18.583 ms) : 18397, 18769
. : milestone, 18583,
tracing (19.685 ms) : 19493, 19877
. : milestone, 19685,
section candidate
no_agent (17.997 ms) : 17815, 18179
. : milestone, 17997,
appsec (18.332 ms) : 18145, 18519
. : milestone, 18332,
code_origins (17.734 ms) : 17557, 17910
. : milestone, 17734,
iast (17.878 ms) : 17700, 18055
. : milestone, 17878,
profiling (18.362 ms) : 18178, 18546
. : milestone, 18362,
tracing (17.804 ms) : 17627, 17981
. : milestone, 17804,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (15.552 s) : 15552000, 15552000
. : milestone, 15552000,
appsec (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
iast (18.146 s) : 18146000, 18146000
. : milestone, 18146000,
iast_GLOBAL (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
profiling (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
tracing (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
section candidate
no_agent (15.52 s) : 15520000, 15520000
. : milestone, 15520000,
appsec (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
iast (18.035 s) : 18035000, 18035000
. : milestone, 18035000,
iast_GLOBAL (17.922 s) : 17922000, 17922000
. : milestone, 17922000,
profiling (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
tracing (14.876 s) : 14876000, 14876000
. : milestone, 14876000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~9f3a660356, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (3.766 ms) : 3548, 3984
. : milestone, 3766,
iast (2.278 ms) : 2207, 2349
. : milestone, 2278,
iast_GLOBAL (2.314 ms) : 2242, 2385
. : milestone, 2314,
profiling (2.112 ms) : 2055, 2169
. : milestone, 2112,
tracing (2.086 ms) : 2031, 2141
. : milestone, 2086,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.799 ms) : 3575, 4022
. : milestone, 3799,
iast (2.269 ms) : 2199, 2339
. : milestone, 2269,
iast_GLOBAL (2.31 ms) : 2239, 2381
. : milestone, 2310,
profiling (2.082 ms) : 2026, 2138
. : milestone, 2082,
tracing (2.07 ms) : 2016, 2124
. : milestone, 2070,
|
What Does This Do
Update the PR description template to include merge queue information.
Motivation
This can act as a helpful guide when merge queues become enforced.
Additional Notes
I used https://markdownlivepreview.com/ to test this.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]