Implement OpenTelemetry meter storage and aggregations#10534
Open
Implement OpenTelemetry meter storage and aggregations#10534
Conversation
…ice - we do this to match OTel behaviour
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062743
Total [baseline] (8.751 s) : 0, 8751024
Agent [candidate] (1.077 s) : 0, 1077025
Total [candidate] (8.78 s) : 0, 8779992
section iast
Agent [baseline] (1.234 s) : 0, 1233509
Total [baseline] (9.388 s) : 0, 9387888
Agent [candidate] (1.233 s) : 0, 1233473
Total [candidate] (9.401 s) : 0, 9400535
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (627.801 ms) : 0, 627801
BytebuddyAgent [candidate] (636.861 ms) : 0, 636861
AgentMeter [baseline] (28.837 ms) : 0, 28837
AgentMeter [candidate] (29.392 ms) : 0, 29392
GlobalTracer [baseline] (257.582 ms) : 0, 257582
GlobalTracer [candidate] (261.122 ms) : 0, 261122
AppSec [baseline] (32.831 ms) : 0, 32831
AppSec [candidate] (33.361 ms) : 0, 33361
Debugger [baseline] (61.842 ms) : 0, 61842
Debugger [candidate] (61.84 ms) : 0, 61840
Remote Config [baseline] (600.847 µs) : 0, 601
Remote Config [candidate] (624.939 µs) : 0, 625
Telemetry [baseline] (11.545 ms) : 0, 11545
Telemetry [candidate] (12.376 ms) : 0, 12376
Flare Poller [baseline] (5.35 ms) : 0, 5350
Flare Poller [candidate] (4.594 ms) : 0, 4594
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (798.023 ms) : 0, 798023
BytebuddyAgent [candidate] (796.935 ms) : 0, 796935
AgentMeter [baseline] (11.267 ms) : 0, 11267
AgentMeter [candidate] (11.259 ms) : 0, 11259
GlobalTracer [baseline] (248.311 ms) : 0, 248311
GlobalTracer [candidate] (248.577 ms) : 0, 248577
AppSec [baseline] (35.013 ms) : 0, 35013
AppSec [candidate] (32.276 ms) : 0, 32276
Debugger [baseline] (64.523 ms) : 0, 64523
Debugger [candidate] (67.946 ms) : 0, 67946
Remote Config [baseline] (541.715 µs) : 0, 542
Remote Config [candidate] (545.068 µs) : 0, 545
Telemetry [baseline] (8.756 ms) : 0, 8756
Telemetry [candidate] (8.822 ms) : 0, 8822
Flare Poller [baseline] (3.531 ms) : 0, 3531
Flare Poller [candidate] (3.602 ms) : 0, 3602
IAST [baseline] (27.135 ms) : 0, 27135
IAST [candidate] (27.028 ms) : 0, 27028
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065744
Total [baseline] (10.902 s) : 0, 10901889
Agent [candidate] (1.067 s) : 0, 1066839
Total [candidate] (10.934 s) : 0, 10934299
section appsec
Agent [baseline] (1.236 s) : 0, 1235648
Total [baseline] (11.003 s) : 0, 11002627
Agent [candidate] (1.239 s) : 0, 1239097
Total [candidate] (11.016 s) : 0, 11016139
section iast
Agent [baseline] (1.231 s) : 0, 1230740
Total [baseline] (11.237 s) : 0, 11236675
Agent [candidate] (1.23 s) : 0, 1229826
Total [candidate] (11.144 s) : 0, 11144021
section profiling
Agent [baseline] (1.19 s) : 0, 1189665
Total [baseline] (10.968 s) : 0, 10967730
Agent [candidate] (1.199 s) : 0, 1199193
Total [candidate] (11.003 s) : 0, 11003360
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (628.207 ms) : 0, 628207
BytebuddyAgent [candidate] (629.679 ms) : 0, 629679
AgentMeter [baseline] (28.923 ms) : 0, 28923
AgentMeter [candidate] (28.936 ms) : 0, 28936
GlobalTracer [baseline] (257.701 ms) : 0, 257701
GlobalTracer [candidate] (258.338 ms) : 0, 258338
AppSec [baseline] (32.776 ms) : 0, 32776
AppSec [candidate] (32.729 ms) : 0, 32729
Debugger [baseline] (62.729 ms) : 0, 62729
Debugger [candidate] (62.142 ms) : 0, 62142
Remote Config [baseline] (594.901 µs) : 0, 595
Remote Config [candidate] (615.095 µs) : 0, 615
Telemetry [baseline] (13.027 ms) : 0, 13027
Telemetry [candidate] (12.205 ms) : 0, 12205
Flare Poller [baseline] (5.372 ms) : 0, 5372
Flare Poller [candidate] (5.584 ms) : 0, 5584
section appsec
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (656.975 ms) : 0, 656975
BytebuddyAgent [candidate] (658.239 ms) : 0, 658239
AgentMeter [baseline] (11.832 ms) : 0, 11832
AgentMeter [candidate] (11.846 ms) : 0, 11846
GlobalTracer [baseline] (257.817 ms) : 0, 257817
GlobalTracer [candidate] (258.677 ms) : 0, 258677
AppSec [baseline] (167.17 ms) : 0, 167170
AppSec [candidate] (168.293 ms) : 0, 168293
Debugger [baseline] (66.91 ms) : 0, 66910
Debugger [candidate] (66.836 ms) : 0, 66836
Remote Config [baseline] (648.913 µs) : 0, 649
Remote Config [candidate] (656.635 µs) : 0, 657
Telemetry [baseline] (9.091 ms) : 0, 9091
Telemetry [candidate] (9.095 ms) : 0, 9095
Flare Poller [baseline] (3.605 ms) : 0, 3605
Flare Poller [candidate] (3.623 ms) : 0, 3623
IAST [baseline] (25.144 ms) : 0, 25144
IAST [candidate] (25.348 ms) : 0, 25348
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (795.029 ms) : 0, 795029
BytebuddyAgent [candidate] (794.729 ms) : 0, 794729
AgentMeter [baseline] (11.245 ms) : 0, 11245
AgentMeter [candidate] (11.2 ms) : 0, 11200
GlobalTracer [baseline] (247.688 ms) : 0, 247688
GlobalTracer [candidate] (247.202 ms) : 0, 247202
AppSec [baseline] (33.238 ms) : 0, 33238
AppSec [candidate] (32.977 ms) : 0, 32977
Debugger [baseline] (67.437 ms) : 0, 67437
Debugger [candidate] (67.576 ms) : 0, 67576
Remote Config [baseline] (542.709 µs) : 0, 543
Remote Config [candidate] (544.102 µs) : 0, 544
Telemetry [baseline] (8.743 ms) : 0, 8743
Telemetry [candidate] (8.725 ms) : 0, 8725
Flare Poller [baseline] (3.485 ms) : 0, 3485
Flare Poller [candidate] (3.452 ms) : 0, 3452
IAST [baseline] (26.933 ms) : 0, 26933
IAST [candidate] (26.947 ms) : 0, 26947
section profiling
ProfilingAgent [baseline] (99.589 ms) : 0, 99589
ProfilingAgent [candidate] (99.628 ms) : 0, 99628
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (681.716 ms) : 0, 681716
BytebuddyAgent [candidate] (686.826 ms) : 0, 686826
AgentMeter [baseline] (8.737 ms) : 0, 8737
AgentMeter [candidate] (8.827 ms) : 0, 8827
GlobalTracer [baseline] (215.855 ms) : 0, 215855
GlobalTracer [candidate] (218.241 ms) : 0, 218241
AppSec [baseline] (32.311 ms) : 0, 32311
AppSec [candidate] (32.817 ms) : 0, 32817
Debugger [baseline] (67.268 ms) : 0, 67268
Debugger [candidate] (68.121 ms) : 0, 68121
Remote Config [baseline] (582.889 µs) : 0, 583
Remote Config [candidate] (621.772 µs) : 0, 622
Telemetry [baseline] (8.824 ms) : 0, 8824
Telemetry [candidate] (8.899 ms) : 0, 8899
Flare Poller [baseline] (3.759 ms) : 0, 3759
Flare Poller [candidate] (3.76 ms) : 0, 3760
Profiling [baseline] (100.154 ms) : 0, 100154
Profiling [candidate] (100.208 ms) : 0, 100208
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 14 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.248 ms) : 3203, 3294
. : milestone, 3248,
iast_FULL (5.67 ms) : 5613, 5726
. : milestone, 5670,
iast_GLOBAL (3.674 ms) : 3613, 3735
. : milestone, 3674,
profiling (1.997 ms) : 1980, 2014
. : milestone, 1997,
tracing (1.803 ms) : 1788, 1819
. : milestone, 1803,
section candidate
no_agent (1.189 ms) : 1178, 1201
. : milestone, 1189,
iast (3.145 ms) : 3114, 3175
. : milestone, 3145,
iast_FULL (5.864 ms) : 5805, 5923
. : milestone, 5864,
iast_GLOBAL (3.499 ms) : 3441, 3558
. : milestone, 3499,
profiling (2.215 ms) : 2196, 2235
. : milestone, 2215,
tracing (1.865 ms) : 1847, 1883
. : milestone, 1865,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (18.006 ms) : 17823, 18189
. : milestone, 18006,
appsec (19.711 ms) : 19508, 19914
. : milestone, 19711,
code_origins (17.589 ms) : 17416, 17762
. : milestone, 17589,
iast (17.91 ms) : 17731, 18089
. : milestone, 17910,
profiling (18.216 ms) : 18036, 18396
. : milestone, 18216,
tracing (17.493 ms) : 17320, 17667
. : milestone, 17493,
section candidate
no_agent (18.06 ms) : 17871, 18249
. : milestone, 18060,
appsec (18.77 ms) : 18582, 18958
. : milestone, 18770,
code_origins (17.594 ms) : 17422, 17767
. : milestone, 17594,
iast (17.342 ms) : 17168, 17515
. : milestone, 17342,
profiling (18.549 ms) : 18365, 18734
. : milestone, 18549,
tracing (17.548 ms) : 17374, 17721
. : milestone, 17548,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.645 ms) : 3434, 3857
. : milestone, 3645,
iast (2.245 ms) : 2176, 2315
. : milestone, 2245,
iast_GLOBAL (2.297 ms) : 2227, 2366
. : milestone, 2297,
profiling (2.072 ms) : 2018, 2127
. : milestone, 2072,
tracing (2.072 ms) : 2017, 2126
. : milestone, 2072,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.761 ms) : 3540, 3982
. : milestone, 3761,
iast (2.238 ms) : 2169, 2308
. : milestone, 2238,
iast_GLOBAL (2.288 ms) : 2218, 2358
. : milestone, 2288,
profiling (2.087 ms) : 2030, 2143
. : milestone, 2087,
tracing (2.055 ms) : 2002, 2109
. : milestone, 2055,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~492a33e6eb, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
appsec (14.645 s) : 14645000, 14645000
. : milestone, 14645000,
iast (18.08 s) : 18080000, 18080000
. : milestone, 18080000,
iast_GLOBAL (17.777 s) : 17777000, 17777000
. : milestone, 17777000,
profiling (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
tracing (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
section candidate
no_agent (15.265 s) : 15265000, 15265000
. : milestone, 15265000,
appsec (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
iast (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
iast_GLOBAL (17.96 s) : 17960000, 17960000
. : milestone, 17960000,
profiling (15.107 s) : 15107000, 15107000
. : milestone, 15107000,
tracing (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Notes
Exporting of metrics will be implemented in a separate PR.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-1765