chore(appsec): rename request body sampling env var#11162
Open
manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
Open
chore(appsec): rename request body sampling env var#11162manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
manuel-alvarez-alvarez wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065458
Total [baseline] (11.007 s) : 0, 11007328
Agent [candidate] (1.058 s) : 0, 1058395
Total [candidate] (11.051 s) : 0, 11051224
section appsec
Agent [baseline] (1.256 s) : 0, 1256262
Total [baseline] (11.114 s) : 0, 11114038
Agent [candidate] (1.251 s) : 0, 1250927
Total [candidate] (11.072 s) : 0, 11072053
section iast
Agent [baseline] (1.23 s) : 0, 1230244
Total [baseline] (11.288 s) : 0, 11287595
Agent [candidate] (1.22 s) : 0, 1220474
Total [candidate] (11.343 s) : 0, 11343418
section profiling
Agent [baseline] (1.184 s) : 0, 1184198
Total [baseline] (10.983 s) : 0, 10983047
Agent [candidate] (1.182 s) : 0, 1181613
Total [candidate] (10.996 s) : 0, 10996407
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (637.031 ms) : 0, 637031
BytebuddyAgent [candidate] (632.478 ms) : 0, 632478
AgentMeter [baseline] (29.702 ms) : 0, 29702
AgentMeter [candidate] (29.578 ms) : 0, 29578
GlobalTracer [baseline] (250.591 ms) : 0, 250591
GlobalTracer [candidate] (248.585 ms) : 0, 248585
AppSec [baseline] (32.501 ms) : 0, 32501
AppSec [candidate] (32.394 ms) : 0, 32394
Debugger [baseline] (60.19 ms) : 0, 60190
Debugger [candidate] (59.779 ms) : 0, 59779
Remote Config [baseline] (609.253 µs) : 0, 609
Remote Config [candidate] (585.867 µs) : 0, 586
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (7.974 ms) : 0, 7974
Flare Poller [baseline] (9.109 ms) : 0, 9109
Flare Poller [candidate] (9.702 ms) : 0, 9702
section appsec
crashtracking [baseline] (1.244 ms) : 0, 1244
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (666.453 ms) : 0, 666453
BytebuddyAgent [candidate] (663.463 ms) : 0, 663463
AgentMeter [baseline] (12.348 ms) : 0, 12348
AgentMeter [candidate] (12.285 ms) : 0, 12285
GlobalTracer [baseline] (250.412 ms) : 0, 250412
GlobalTracer [candidate] (249.274 ms) : 0, 249274
AppSec [baseline] (185.995 ms) : 0, 185995
AppSec [candidate] (184.983 ms) : 0, 184983
Debugger [baseline] (66.065 ms) : 0, 66065
Debugger [candidate] (66.016 ms) : 0, 66016
Remote Config [baseline] (619.169 µs) : 0, 619
Remote Config [candidate] (590.296 µs) : 0, 590
Telemetry [baseline] (8.426 ms) : 0, 8426
Telemetry [candidate] (8.499 ms) : 0, 8499
Flare Poller [baseline] (3.54 ms) : 0, 3540
Flare Poller [candidate] (3.576 ms) : 0, 3576
IAST [baseline] (24.64 ms) : 0, 24640
IAST [candidate] (24.551 ms) : 0, 24551
section iast
crashtracking [baseline] (1.271 ms) : 0, 1271
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (805.919 ms) : 0, 805919
BytebuddyAgent [candidate] (798.274 ms) : 0, 798274
AgentMeter [baseline] (11.698 ms) : 0, 11698
AgentMeter [candidate] (11.567 ms) : 0, 11567
GlobalTracer [baseline] (239.56 ms) : 0, 239560
GlobalTracer [candidate] (238.708 ms) : 0, 238708
AppSec [baseline] (32.03 ms) : 0, 32030
AppSec [candidate] (31.136 ms) : 0, 31136
Debugger [baseline] (64.122 ms) : 0, 64122
Debugger [candidate] (63.721 ms) : 0, 63721
Remote Config [baseline] (543.453 µs) : 0, 543
Remote Config [candidate] (533.449 µs) : 0, 533
Telemetry [baseline] (9.373 ms) : 0, 9373
Telemetry [candidate] (9.324 ms) : 0, 9324
Flare Poller [baseline] (3.617 ms) : 0, 3617
Flare Poller [candidate] (3.572 ms) : 0, 3572
IAST [baseline] (25.787 ms) : 0, 25787
IAST [candidate] (26.437 ms) : 0, 26437
section profiling
ProfilingAgent [baseline] (94.068 ms) : 0, 94068
ProfilingAgent [candidate] (93.497 ms) : 0, 93497
crashtracking [baseline] (1.167 ms) : 0, 1167
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (690.536 ms) : 0, 690536
BytebuddyAgent [candidate] (690.401 ms) : 0, 690401
AgentMeter [baseline] (9.207 ms) : 0, 9207
AgentMeter [candidate] (9.198 ms) : 0, 9198
GlobalTracer [baseline] (207.027 ms) : 0, 207027
GlobalTracer [candidate] (206.599 ms) : 0, 206599
AppSec [baseline] (32.977 ms) : 0, 32977
AppSec [candidate] (32.615 ms) : 0, 32615
Debugger [baseline] (65.953 ms) : 0, 65953
Debugger [candidate] (65.336 ms) : 0, 65336
Remote Config [baseline] (583.365 µs) : 0, 583
Remote Config [candidate] (559.887 µs) : 0, 560
Telemetry [baseline] (7.788 ms) : 0, 7788
Telemetry [candidate] (7.742 ms) : 0, 7742
Flare Poller [baseline] (3.607 ms) : 0, 3607
Flare Poller [candidate] (3.495 ms) : 0, 3495
Profiling [baseline] (94.628 ms) : 0, 94628
Profiling [candidate] (94.064 ms) : 0, 94064
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056999
Total [baseline] (8.839 s) : 0, 8839384
Agent [candidate] (1.052 s) : 0, 1052312
Total [candidate] (8.802 s) : 0, 8802191
section iast
Agent [baseline] (1.23 s) : 0, 1229667
Total [baseline] (9.594 s) : 0, 9593941
Agent [candidate] (1.222 s) : 0, 1222033
Total [candidate] (9.543 s) : 0, 9542751
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.242 ms) : 0, 1242
BytebuddyAgent [baseline] (633.455 ms) : 0, 633455
BytebuddyAgent [candidate] (630.914 ms) : 0, 630914
AgentMeter [baseline] (29.408 ms) : 0, 29408
AgentMeter [candidate] (29.51 ms) : 0, 29510
GlobalTracer [baseline] (248.337 ms) : 0, 248337
GlobalTracer [candidate] (249.101 ms) : 0, 249101
AppSec [baseline] (32.354 ms) : 0, 32354
AppSec [candidate] (32.557 ms) : 0, 32557
Debugger [baseline] (59.116 ms) : 0, 59116
Debugger [candidate] (59.165 ms) : 0, 59165
Remote Config [baseline] (593.999 µs) : 0, 594
Remote Config [candidate] (591.721 µs) : 0, 592
Telemetry [baseline] (8.066 ms) : 0, 8066
Telemetry [candidate] (8.796 ms) : 0, 8796
Flare Poller [baseline] (8.26 ms) : 0, 8260
Flare Poller [candidate] (4.33 ms) : 0, 4330
section iast
crashtracking [baseline] (1.265 ms) : 0, 1265
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (805.178 ms) : 0, 805178
BytebuddyAgent [candidate] (800.522 ms) : 0, 800522
AgentMeter [baseline] (11.781 ms) : 0, 11781
AgentMeter [candidate] (11.611 ms) : 0, 11611
GlobalTracer [baseline] (239.892 ms) : 0, 239892
GlobalTracer [candidate] (238.805 ms) : 0, 238805
AppSec [baseline] (31.447 ms) : 0, 31447
AppSec [candidate] (32.439 ms) : 0, 32439
Debugger [baseline] (64.352 ms) : 0, 64352
Debugger [candidate] (62.342 ms) : 0, 62342
Remote Config [baseline] (544.729 µs) : 0, 545
Remote Config [candidate] (529.479 µs) : 0, 529
Telemetry [baseline] (9.346 ms) : 0, 9346
Telemetry [candidate] (9.22 ms) : 0, 9220
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (3.477 ms) : 0, 3477
IAST [baseline] (26.038 ms) : 0, 26038
IAST [candidate] (25.856 ms) : 0, 25856
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section baseline
no_agent (18.159 ms) : 17975, 18343
. : milestone, 18159,
appsec (18.867 ms) : 18672, 19062
. : milestone, 18867,
code_origins (17.899 ms) : 17722, 18076
. : milestone, 17899,
iast (17.962 ms) : 17783, 18142
. : milestone, 17962,
profiling (18.38 ms) : 18197, 18563
. : milestone, 18380,
tracing (17.854 ms) : 17679, 18030
. : milestone, 17854,
section candidate
no_agent (18.026 ms) : 17843, 18208
. : milestone, 18026,
appsec (18.508 ms) : 18322, 18694
. : milestone, 18508,
code_origins (18.434 ms) : 18253, 18616
. : milestone, 18434,
iast (17.954 ms) : 17779, 18130
. : milestone, 17954,
profiling (19.406 ms) : 19211, 19600
. : milestone, 19406,
tracing (17.685 ms) : 17506, 17864
. : milestone, 17685,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section baseline
no_agent (1.245 ms) : 1234, 1257
. : milestone, 1245,
iast (3.24 ms) : 3194, 3287
. : milestone, 3240,
iast_FULL (6.054 ms) : 5991, 6116
. : milestone, 6054,
iast_GLOBAL (3.722 ms) : 3661, 3784
. : milestone, 3722,
profiling (2.412 ms) : 2385, 2438
. : milestone, 2412,
tracing (1.901 ms) : 1885, 1917
. : milestone, 1901,
section candidate
no_agent (1.263 ms) : 1250, 1276
. : milestone, 1263,
iast (3.607 ms) : 3553, 3661
. : milestone, 3607,
iast_FULL (6.119 ms) : 6057, 6182
. : milestone, 6119,
iast_GLOBAL (3.649 ms) : 3588, 3710
. : milestone, 3649,
profiling (2.292 ms) : 2269, 2314
. : milestone, 2292,
tracing (1.866 ms) : 1851, 1881
. : milestone, 1866,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section baseline
no_agent (15.295 s) : 15295000, 15295000
. : milestone, 15295000,
appsec (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
iast (18.34 s) : 18340000, 18340000
. : milestone, 18340000,
iast_GLOBAL (18.139 s) : 18139000, 18139000
. : milestone, 18139000,
profiling (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
tracing (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
section candidate
no_agent (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
appsec (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
iast (17.945 s) : 17945000, 17945000
. : milestone, 17945000,
iast_GLOBAL (18.124 s) : 18124000, 18124000
. : milestone, 18124000,
profiling (15.153 s) : 15153000, 15153000
. : milestone, 15153000,
tracing (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~54af2dda23, baseline=1.62.0-SNAPSHOT~081af53226
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1498
. : milestone, 1486,
appsec (3.843 ms) : 3621, 4066
. : milestone, 3843,
iast (2.285 ms) : 2215, 2355
. : milestone, 2285,
iast_GLOBAL (2.322 ms) : 2251, 2392
. : milestone, 2322,
profiling (2.103 ms) : 2048, 2158
. : milestone, 2103,
tracing (2.091 ms) : 2037, 2145
. : milestone, 2091,
section candidate
no_agent (1.491 ms) : 1479, 1502
. : milestone, 1491,
appsec (3.833 ms) : 3610, 4056
. : milestone, 3833,
iast (2.285 ms) : 2215, 2355
. : milestone, 2285,
iast_GLOBAL (2.326 ms) : 2255, 2396
. : milestone, 2326,
profiling (2.518 ms) : 2348, 2688
. : milestone, 2518,
tracing (2.079 ms) : 2026, 2133
. : milestone, 2079,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Renames the environment variable
DD_API_SECURITY_DOWNSTREAM_REQUEST_BODY_ANALYSIS_SAMPLE_RATEtoDD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATEkeeping the aliases.Motivation
The name of the previous variable was too long for certain languages so we had to crop it.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-59936
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.