Refactor connection creation from where block into setup block.#11167
Open
AlexeyKuznetsov-DD wants to merge 2 commits intomasterfrom
Open
Refactor connection creation from where block into setup block.#11167AlexeyKuznetsov-DD wants to merge 2 commits intomasterfrom
where block into setup block.#11167AlexeyKuznetsov-DD wants to merge 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059340
Total [baseline] (10.989 s) : 0, 10989158
Agent [candidate] (1.064 s) : 0, 1064190
Total [candidate] (11.107 s) : 0, 11106758
section appsec
Agent [baseline] (1.266 s) : 0, 1266368
Total [baseline] (10.896 s) : 0, 10895748
Agent [candidate] (1.267 s) : 0, 1267216
Total [candidate] (10.989 s) : 0, 10989269
section iast
Agent [baseline] (1.229 s) : 0, 1229266
Total [baseline] (11.31 s) : 0, 11309734
Agent [candidate] (1.241 s) : 0, 1240908
Total [candidate] (11.376 s) : 0, 11375895
section profiling
Agent [baseline] (1.186 s) : 0, 1186390
Total [baseline] (11.027 s) : 0, 11026818
Agent [candidate] (1.193 s) : 0, 1193295
Total [candidate] (11.062 s) : 0, 11061839
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (634.097 ms) : 0, 634097
BytebuddyAgent [candidate] (638.469 ms) : 0, 638469
AgentMeter [baseline] (29.558 ms) : 0, 29558
AgentMeter [candidate] (29.777 ms) : 0, 29777
GlobalTracer [baseline] (249.036 ms) : 0, 249036
GlobalTracer [candidate] (249.315 ms) : 0, 249315
AppSec [baseline] (32.434 ms) : 0, 32434
AppSec [candidate] (32.539 ms) : 0, 32539
Debugger [baseline] (59.85 ms) : 0, 59850
Debugger [candidate] (59.881 ms) : 0, 59881
Remote Config [baseline] (604.749 µs) : 0, 605
Remote Config [candidate] (597.731 µs) : 0, 598
Telemetry [baseline] (8.028 ms) : 0, 8028
Telemetry [candidate] (8.034 ms) : 0, 8034
Flare Poller [baseline] (8.243 ms) : 0, 8243
Flare Poller [candidate] (8.112 ms) : 0, 8112
section appsec
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (677.207 ms) : 0, 677207
BytebuddyAgent [candidate] (678.344 ms) : 0, 678344
AgentMeter [baseline] (12.158 ms) : 0, 12158
AgentMeter [candidate] (12.227 ms) : 0, 12227
GlobalTracer [baseline] (250.108 ms) : 0, 250108
GlobalTracer [candidate] (249.799 ms) : 0, 249799
IAST [baseline] (24.45 ms) : 0, 24450
IAST [candidate] (24.396 ms) : 0, 24396
AppSec [baseline] (186.149 ms) : 0, 186149
AppSec [candidate] (186.744 ms) : 0, 186744
Debugger [baseline] (66.593 ms) : 0, 66593
Debugger [candidate] (66.041 ms) : 0, 66041
Remote Config [baseline] (579.193 µs) : 0, 579
Remote Config [candidate] (577.759 µs) : 0, 578
Telemetry [baseline] (7.909 ms) : 0, 7909
Telemetry [candidate] (7.855 ms) : 0, 7855
Flare Poller [baseline] (3.469 ms) : 0, 3469
Flare Poller [candidate] (3.469 ms) : 0, 3469
section iast
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.229 ms) : 0, 1229
BytebuddyAgent [baseline] (807.688 ms) : 0, 807688
BytebuddyAgent [candidate] (815.901 ms) : 0, 815901
AgentMeter [baseline] (11.378 ms) : 0, 11378
AgentMeter [candidate] (11.569 ms) : 0, 11569
GlobalTracer [baseline] (238.569 ms) : 0, 238569
GlobalTracer [candidate] (239.91 ms) : 0, 239910
IAST [baseline] (29.757 ms) : 0, 29757
IAST [candidate] (26.717 ms) : 0, 26717
AppSec [baseline] (29.221 ms) : 0, 29221
AppSec [candidate] (28.997 ms) : 0, 28997
Debugger [baseline] (63.754 ms) : 0, 63754
Debugger [candidate] (68.376 ms) : 0, 68376
Remote Config [baseline] (528.055 µs) : 0, 528
Remote Config [candidate] (531.277 µs) : 0, 531
Telemetry [baseline] (7.754 ms) : 0, 7754
Telemetry [candidate] (7.92 ms) : 0, 7920
Flare Poller [baseline] (3.402 ms) : 0, 3402
Flare Poller [candidate] (3.478 ms) : 0, 3478
section profiling
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (692.272 ms) : 0, 692272
BytebuddyAgent [candidate] (695.86 ms) : 0, 695860
AgentMeter [baseline] (9.204 ms) : 0, 9204
AgentMeter [candidate] (9.225 ms) : 0, 9225
GlobalTracer [baseline] (206.756 ms) : 0, 206756
GlobalTracer [candidate] (208.989 ms) : 0, 208989
AppSec [baseline] (32.814 ms) : 0, 32814
AppSec [candidate] (32.967 ms) : 0, 32967
Debugger [baseline] (66.059 ms) : 0, 66059
Debugger [candidate] (66.216 ms) : 0, 66216
Remote Config [baseline] (587.23 µs) : 0, 587
Remote Config [candidate] (582.331 µs) : 0, 582
Telemetry [baseline] (7.819 ms) : 0, 7819
Telemetry [candidate] (7.913 ms) : 0, 7913
Flare Poller [baseline] (3.55 ms) : 0, 3550
Flare Poller [candidate] (3.625 ms) : 0, 3625
ProfilingAgent [baseline] (94.853 ms) : 0, 94853
ProfilingAgent [candidate] (95.083 ms) : 0, 95083
Profiling [baseline] (95.438 ms) : 0, 95438
Profiling [candidate] (95.661 ms) : 0, 95661
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056356
Total [baseline] (8.814 s) : 0, 8814024
Agent [candidate] (1.055 s) : 0, 1054917
Total [candidate] (8.856 s) : 0, 8855667
section iast
Agent [baseline] (1.232 s) : 0, 1232112
Total [baseline] (9.527 s) : 0, 9526602
Agent [candidate] (1.228 s) : 0, 1228448
Total [candidate] (9.525 s) : 0, 9524949
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.23 ms) : 0, 1230
BytebuddyAgent [baseline] (633.127 ms) : 0, 633127
BytebuddyAgent [candidate] (632.12 ms) : 0, 632120
AgentMeter [baseline] (29.498 ms) : 0, 29498
AgentMeter [candidate] (29.532 ms) : 0, 29532
GlobalTracer [baseline] (248.037 ms) : 0, 248037
GlobalTracer [candidate] (248.882 ms) : 0, 248882
AppSec [baseline] (32.405 ms) : 0, 32405
AppSec [candidate] (32.451 ms) : 0, 32451
Debugger [baseline] (59.022 ms) : 0, 59022
Debugger [candidate] (59.151 ms) : 0, 59151
Remote Config [baseline] (591.46 µs) : 0, 591
Remote Config [candidate] (595.182 µs) : 0, 595
Telemetry [baseline] (8.001 ms) : 0, 8001
Telemetry [candidate] (9.521 ms) : 0, 9521
Flare Poller [baseline] (8.288 ms) : 0, 8288
Flare Poller [candidate] (5.313 ms) : 0, 5313
section iast
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (809.653 ms) : 0, 809653
BytebuddyAgent [candidate] (807.818 ms) : 0, 807818
AgentMeter [baseline] (11.422 ms) : 0, 11422
AgentMeter [candidate] (11.396 ms) : 0, 11396
GlobalTracer [baseline] (239.079 ms) : 0, 239079
GlobalTracer [candidate] (238.694 ms) : 0, 238694
AppSec [baseline] (27.799 ms) : 0, 27799
AppSec [candidate] (29.975 ms) : 0, 29975
Debugger [baseline] (66.624 ms) : 0, 66624
Debugger [candidate] (62.697 ms) : 0, 62697
Remote Config [baseline] (534.743 µs) : 0, 535
Remote Config [candidate] (526.647 µs) : 0, 527
Telemetry [baseline] (7.81 ms) : 0, 7810
Telemetry [candidate] (7.706 ms) : 0, 7706
Flare Poller [baseline] (3.433 ms) : 0, 3433
Flare Poller [candidate] (3.386 ms) : 0, 3386
IAST [baseline] (28.393 ms) : 0, 28393
IAST [candidate] (28.183 ms) : 0, 28183
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 20 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section baseline
no_agent (1.258 ms) : 1245, 1270
. : milestone, 1258,
iast (3.309 ms) : 3262, 3356
. : milestone, 3309,
iast_FULL (6.005 ms) : 5944, 6066
. : milestone, 6005,
iast_GLOBAL (3.725 ms) : 3657, 3792
. : milestone, 3725,
profiling (2.074 ms) : 2057, 2092
. : milestone, 2074,
tracing (1.881 ms) : 1866, 1897
. : milestone, 1881,
section candidate
no_agent (1.257 ms) : 1244, 1269
. : milestone, 1257,
iast (3.357 ms) : 3306, 3407
. : milestone, 3357,
iast_FULL (6.007 ms) : 5946, 6069
. : milestone, 6007,
iast_GLOBAL (3.801 ms) : 3737, 3865
. : milestone, 3801,
profiling (2.51 ms) : 2486, 2534
. : milestone, 2510,
tracing (1.856 ms) : 1842, 1871
. : milestone, 1856,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section baseline
no_agent (18.364 ms) : 18178, 18549
. : milestone, 18364,
appsec (18.703 ms) : 18512, 18894
. : milestone, 18703,
code_origins (17.944 ms) : 17765, 18123
. : milestone, 17944,
iast (18.074 ms) : 17896, 18253
. : milestone, 18074,
profiling (19.381 ms) : 19182, 19581
. : milestone, 19381,
tracing (18.858 ms) : 18671, 19045
. : milestone, 18858,
section candidate
no_agent (18.068 ms) : 17887, 18250
. : milestone, 18068,
appsec (18.764 ms) : 18575, 18953
. : milestone, 18764,
code_origins (17.925 ms) : 17748, 18101
. : milestone, 17925,
iast (17.919 ms) : 17741, 18097
. : milestone, 17919,
profiling (19.542 ms) : 19345, 19740
. : milestone, 19542,
tracing (17.746 ms) : 17571, 17922
. : milestone, 17746,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section baseline
no_agent (14.886 s) : 14886000, 14886000
. : milestone, 14886000,
appsec (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
iast (18.269 s) : 18269000, 18269000
. : milestone, 18269000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
. : milestone, 18061000,
profiling (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
tracing (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
iast (18.543 s) : 18543000, 18543000
. : milestone, 18543000,
iast_GLOBAL (18.169 s) : 18169000, 18169000
. : milestone, 18169000,
profiling (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~1ef1e7e85a, baseline=1.62.0-SNAPSHOT~6e28457d70
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (3.769 ms) : 3551, 3988
. : milestone, 3769,
iast (2.274 ms) : 2205, 2344
. : milestone, 2274,
iast_GLOBAL (2.315 ms) : 2244, 2385
. : milestone, 2315,
profiling (2.101 ms) : 2046, 2156
. : milestone, 2101,
tracing (2.098 ms) : 2044, 2152
. : milestone, 2098,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.827 ms) : 3605, 4049
. : milestone, 3827,
iast (2.267 ms) : 2197, 2336
. : milestone, 2267,
iast_GLOBAL (2.315 ms) : 2245, 2385
. : milestone, 2315,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.072 ms) : 2019, 2126
. : milestone, 2072,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactors connection creation by moving it from the
whereblock to thesetupblock.Motivation
This PR only refactors how connections are created in tests; no test logic has changed.
The main goal is to enable skipping specific databases when they are not available on certain platforms (currently arm64). When connections are created inside the
wheredata table, skipping a database results in skipping all rows in that table. With this change, only the affected database is skipped.This also helps minimize the size and complexity of an upcoming PR that adds support for testing
dd-trace-javaonarm64in GitLab.Additional Notes
There is no logic change in this PR. Logic for skipping
MS SQL Serveronarm64will be introduced in a separate PR.