Restore original tracer during LambdaAppSecHandlerTest cleanup#11172
Open
Restore original tracer during LambdaAppSecHandlerTest cleanup#11172
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
AlexeyKuznetsov-DD
approved these changes
Apr 21, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056020
Total [baseline] (8.802 s) : 0, 8802200
Agent [candidate] (1.059 s) : 0, 1058610
Total [candidate] (8.831 s) : 0, 8831252
section iast
Agent [baseline] (1.236 s) : 0, 1236209
Total [baseline] (9.582 s) : 0, 9581665
Agent [candidate] (1.238 s) : 0, 1238234
Total [candidate] (9.601 s) : 0, 9600794
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.238 ms) : 0, 1238
BytebuddyAgent [baseline] (632.591 ms) : 0, 632591
BytebuddyAgent [candidate] (634.082 ms) : 0, 634082
AgentMeter [baseline] (29.567 ms) : 0, 29567
AgentMeter [candidate] (29.551 ms) : 0, 29551
GlobalTracer [baseline] (248.759 ms) : 0, 248759
GlobalTracer [candidate] (248.979 ms) : 0, 248979
AppSec [baseline] (32.56 ms) : 0, 32560
AppSec [candidate] (32.634 ms) : 0, 32634
Debugger [baseline] (59.106 ms) : 0, 59106
Debugger [candidate] (59.087 ms) : 0, 59087
Remote Config [baseline] (599.167 µs) : 0, 599
Remote Config [candidate] (587.896 µs) : 0, 588
Telemetry [baseline] (7.997 ms) : 0, 7997
Telemetry [candidate] (7.984 ms) : 0, 7984
Flare Poller [baseline] (7.489 ms) : 0, 7489
Flare Poller [candidate] (8.206 ms) : 0, 8206
section iast
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (812.987 ms) : 0, 812987
BytebuddyAgent [candidate] (814.305 ms) : 0, 814305
AgentMeter [baseline] (11.478 ms) : 0, 11478
AgentMeter [candidate] (11.467 ms) : 0, 11467
GlobalTracer [baseline] (239.536 ms) : 0, 239536
GlobalTracer [candidate] (239.586 ms) : 0, 239586
IAST [baseline] (30.987 ms) : 0, 30987
IAST [candidate] (27.679 ms) : 0, 27679
AppSec [baseline] (28.65 ms) : 0, 28650
AppSec [candidate] (29.735 ms) : 0, 29735
Debugger [baseline] (63.366 ms) : 0, 63366
Debugger [candidate] (64.487 ms) : 0, 64487
Remote Config [baseline] (542.844 µs) : 0, 543
Remote Config [candidate] (540.03 µs) : 0, 540
Telemetry [baseline] (7.8 ms) : 0, 7800
Telemetry [candidate] (7.827 ms) : 0, 7827
Flare Poller [baseline] (3.416 ms) : 0, 3416
Flare Poller [candidate] (3.467 ms) : 0, 3467
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065199
Total [baseline] (11.142 s) : 0, 11142228
Agent [candidate] (1.064 s) : 0, 1063504
Total [candidate] (11.034 s) : 0, 11034454
section appsec
Agent [baseline] (1.26 s) : 0, 1259898
Total [baseline] (10.964 s) : 0, 10963873
Agent [candidate] (1.267 s) : 0, 1267158
Total [candidate] (10.954 s) : 0, 10954278
section iast
Agent [baseline] (1.238 s) : 0, 1237894
Total [baseline] (11.337 s) : 0, 11336803
Agent [candidate] (1.231 s) : 0, 1231297
Total [candidate] (11.304 s) : 0, 11304003
section profiling
Agent [baseline] (1.186 s) : 0, 1185701
Total [baseline] (10.93 s) : 0, 10929985
Agent [candidate] (1.185 s) : 0, 1185024
Total [candidate] (11.065 s) : 0, 11064773
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.244 ms) : 0, 1244
crashtracking [candidate] (1.236 ms) : 0, 1236
BytebuddyAgent [baseline] (637.468 ms) : 0, 637468
BytebuddyAgent [candidate] (636.294 ms) : 0, 636294
AgentMeter [baseline] (29.753 ms) : 0, 29753
AgentMeter [candidate] (29.743 ms) : 0, 29743
GlobalTracer [baseline] (250.458 ms) : 0, 250458
GlobalTracer [candidate] (250.281 ms) : 0, 250281
AppSec [baseline] (32.567 ms) : 0, 32567
AppSec [candidate] (32.873 ms) : 0, 32873
Debugger [baseline] (60.52 ms) : 0, 60520
Debugger [candidate] (60.618 ms) : 0, 60618
Remote Config [baseline] (604.096 µs) : 0, 604
Remote Config [candidate] (597.52 µs) : 0, 598
Telemetry [baseline] (8.879 ms) : 0, 8879
Telemetry [candidate] (8.129 ms) : 0, 8129
Flare Poller [baseline] (7.428 ms) : 0, 7428
Flare Poller [candidate] (7.468 ms) : 0, 7468
section appsec
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (673.258 ms) : 0, 673258
BytebuddyAgent [candidate] (677.804 ms) : 0, 677804
AgentMeter [baseline] (12.159 ms) : 0, 12159
AgentMeter [candidate] (12.195 ms) : 0, 12195
GlobalTracer [baseline] (248.985 ms) : 0, 248985
GlobalTracer [candidate] (250.363 ms) : 0, 250363
AppSec [baseline] (184.921 ms) : 0, 184921
AppSec [candidate] (186.816 ms) : 0, 186816
Debugger [baseline] (66.737 ms) : 0, 66737
Debugger [candidate] (65.964 ms) : 0, 65964
Remote Config [baseline] (570.43 µs) : 0, 570
Remote Config [candidate] (574.795 µs) : 0, 575
Telemetry [baseline] (7.873 ms) : 0, 7873
Telemetry [candidate] (7.928 ms) : 0, 7928
Flare Poller [baseline] (3.445 ms) : 0, 3445
Flare Poller [candidate] (3.49 ms) : 0, 3490
IAST [baseline] (24.3 ms) : 0, 24300
IAST [candidate] (24.458 ms) : 0, 24458
section iast
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (814.927 ms) : 0, 814927
BytebuddyAgent [candidate] (809.615 ms) : 0, 809615
AgentMeter [baseline] (11.453 ms) : 0, 11453
AgentMeter [candidate] (11.444 ms) : 0, 11444
GlobalTracer [baseline] (238.932 ms) : 0, 238932
GlobalTracer [candidate] (238.825 ms) : 0, 238825
AppSec [baseline] (30.22 ms) : 0, 30220
AppSec [candidate] (25.406 ms) : 0, 25406
Debugger [baseline] (64.051 ms) : 0, 64051
Debugger [candidate] (64.662 ms) : 0, 64662
Remote Config [baseline] (535.613 µs) : 0, 536
Remote Config [candidate] (528.161 µs) : 0, 528
Telemetry [baseline] (7.797 ms) : 0, 7797
Telemetry [candidate] (7.718 ms) : 0, 7718
Flare Poller [baseline] (3.405 ms) : 0, 3405
Flare Poller [candidate] (3.356 ms) : 0, 3356
IAST [baseline] (29.104 ms) : 0, 29104
IAST [candidate] (31.606 ms) : 0, 31606
section profiling
ProfilingAgent [baseline] (94.13 ms) : 0, 94130
ProfilingAgent [candidate] (94.136 ms) : 0, 94136
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (691.172 ms) : 0, 691172
BytebuddyAgent [candidate] (691.464 ms) : 0, 691464
AgentMeter [baseline] (9.193 ms) : 0, 9193
AgentMeter [candidate] (9.209 ms) : 0, 9209
GlobalTracer [baseline] (207.213 ms) : 0, 207213
GlobalTracer [candidate] (207.07 ms) : 0, 207070
AppSec [baseline] (33.137 ms) : 0, 33137
AppSec [candidate] (32.882 ms) : 0, 32882
Debugger [baseline] (66.322 ms) : 0, 66322
Debugger [candidate] (65.914 ms) : 0, 65914
Remote Config [baseline] (597.957 µs) : 0, 598
Remote Config [candidate] (591.101 µs) : 0, 591
Telemetry [baseline] (7.835 ms) : 0, 7835
Telemetry [candidate] (7.797 ms) : 0, 7797
Flare Poller [baseline] (3.585 ms) : 0, 3585
Flare Poller [candidate] (3.58 ms) : 0, 3580
Profiling [baseline] (94.706 ms) : 0, 94706
Profiling [candidate] (94.713 ms) : 0, 94713
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section baseline
no_agent (1.249 ms) : 1236, 1261
. : milestone, 1249,
iast (3.223 ms) : 3180, 3266
. : milestone, 3223,
iast_FULL (5.889 ms) : 5830, 5948
. : milestone, 5889,
iast_GLOBAL (3.607 ms) : 3548, 3666
. : milestone, 3607,
profiling (2.243 ms) : 2221, 2264
. : milestone, 2243,
tracing (1.883 ms) : 1868, 1898
. : milestone, 1883,
section candidate
no_agent (1.279 ms) : 1266, 1291
. : milestone, 1279,
iast (3.348 ms) : 3300, 3396
. : milestone, 3348,
iast_FULL (6.06 ms) : 5998, 6123
. : milestone, 6060,
iast_GLOBAL (3.808 ms) : 3745, 3872
. : milestone, 3808,
profiling (2.194 ms) : 2174, 2214
. : milestone, 2194,
tracing (1.857 ms) : 1842, 1873
. : milestone, 1857,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section baseline
no_agent (17.57 ms) : 17393, 17747
. : milestone, 17570,
appsec (18.537 ms) : 18348, 18726
. : milestone, 18537,
code_origins (18.013 ms) : 17834, 18193
. : milestone, 18013,
iast (18.096 ms) : 17917, 18274
. : milestone, 18096,
profiling (18.245 ms) : 18071, 18420
. : milestone, 18245,
tracing (18.195 ms) : 18015, 18376
. : milestone, 18195,
section candidate
no_agent (18.177 ms) : 17992, 18362
. : milestone, 18177,
appsec (19.149 ms) : 18956, 19342
. : milestone, 19149,
code_origins (18.803 ms) : 18613, 18994
. : milestone, 18803,
iast (17.819 ms) : 17644, 17995
. : milestone, 17819,
profiling (19.327 ms) : 19131, 19522
. : milestone, 19327,
tracing (17.818 ms) : 17645, 17992
. : milestone, 17818,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section baseline
no_agent (15.516 s) : 15516000, 15516000
. : milestone, 15516000,
appsec (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
iast (18.567 s) : 18567000, 18567000
. : milestone, 18567000,
iast_GLOBAL (17.908 s) : 17908000, 17908000
. : milestone, 17908000,
profiling (14.913 s) : 14913000, 14913000
. : milestone, 14913000,
tracing (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
section candidate
no_agent (15.676 s) : 15676000, 15676000
. : milestone, 15676000,
appsec (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
iast (18.677 s) : 18677000, 18677000
. : milestone, 18677000,
iast_GLOBAL (18.091 s) : 18091000, 18091000
. : milestone, 18091000,
profiling (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
tracing (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~5d44654f6f, baseline=1.62.0-SNAPSHOT~534f75e4d6
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (2.547 ms) : 2492, 2601
. : milestone, 2547,
iast (2.294 ms) : 2224, 2364
. : milestone, 2294,
iast_GLOBAL (2.328 ms) : 2258, 2399
. : milestone, 2328,
profiling (2.114 ms) : 2059, 2170
. : milestone, 2114,
tracing (2.088 ms) : 2034, 2141
. : milestone, 2088,
section candidate
no_agent (1.495 ms) : 1484, 1507
. : milestone, 1495,
appsec (2.538 ms) : 2483, 2593
. : milestone, 2538,
iast (2.286 ms) : 2216, 2356
. : milestone, 2286,
iast_GLOBAL (2.329 ms) : 2259, 2399
. : milestone, 2329,
profiling (2.109 ms) : 2054, 2164
. : milestone, 2109,
tracing (2.099 ms) : 2045, 2153
. : milestone, 2099,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Restore original tracer during the cleanup after LambdaAppSecHandlerTest
Motivation
forceRegister(null) in LambdaAppSecHandlerTest cleanup was causing NPE in LambdaHandlerTest when the AppSec test was ran before the LambdaHandlerTest.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.