Bumps javaparser-symbol-solver-core from 3.24.4 to 3.28.2#11704
Conversation
| return SymbolReference.solved(ReflectionFactory.typeDeclarationFor(clazz, getRoot())); | ||
| } catch (final Throwable e) { | ||
| return SymbolReference.unsolved(ResolvedReferenceTypeDeclaration.class); | ||
| return SymbolReference.unsolved(); |
There was a problem hiding this comment.
SymbolReference.unsolved(ResolvedReferenceTypeDeclaration.class) declared as Deprecated and internally already calling unsolved().
| @Override | ||
| public SymbolReference<ResolvedReferenceTypeDeclaration> tryToSolveTypeInModule( | ||
| String qualifiedModuleName, String simpleTypeName) { | ||
| return tryToSolveType(simpleTypeName); |
There was a problem hiding this comment.
Implemented new method introduced in latest version of parser. Ignored module name since the main logic is using reflection and is not using module name.
|
|
||
| implementation("com.github.zafarkhaja:java-semver:0.10.2") | ||
| implementation("com.github.javaparser", "javaparser-symbol-solver-core", "3.24.4") | ||
| implementation(libs.javaparser.symbol.solver) |
There was a problem hiding this comment.
Fixed: use value from catalog (missed usage).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73334d117b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This comment has been minimized.
This comment has been minimized.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Bumps
javaparser-symbol-solver-corefrom3.24.4to3.28.2(released 3 week ago, so 48h cooldown compliant).Motivation
Keep the
buildSrcJavaParser dependency current with latest fixes.Additional Notes
Noteworthy changes:
UnsolvedSymbolExceptionwhen a package declaration contains a comment; bumped Javassist to3.29.1-GA; updated Maven site/javadoc plugin metadata.StaticJavaParserandSourceRootparser config APIs; fixed yield parsing,finalininstanceofpatterns, annotation reflection class names, and lexical-preservingindentation.
SymbolReferenceoptional helper; fixed generic constructor resolution and lexical-preserving variable type edits.TypeSolverBuilder; fixed many LexicalPreservingPrinter comment/modifier/indentation cases; fixedvartype resolution in enhancedfor; removed executable bits from sourcefiles.
CompilationUnit, Jigsawrequires static, and method descriptor API.\sescape parsing, and lambda return type resolution.sealed/permitsvariable parsing, variadic method parameter crashes, and enum/interface declaration handling.permits, orphan comments, and switch-entry lexicalpreservation.
isAssignableByrecursion.
grammar issues.
parseArrayInitializerExpr, and AST position lookup; fixed catch parameter resolution, nested varargs object creation, Java 18 yield support, and LUBrecursion.
ResolvedReferenceType#equals, and private interface method validation.case null, default; fixed switch expressions, contextualsealed/permits, enumvalues, inner-class resolution, andvarargs type calculation.
varcompatibility, object creation resolution, and multilineString.format.FieldAccessExprresolution for custom classes.DifferenceElementCalculator, duplicate XML attributes, and lambdabody based resolution.
valueOf, failed parse paths, andrecord reflection output.
module-info, and Java 25switch/yield parsing.
inference, text blocks, and switch pattern parsing.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]