feat(sparkjava-2.3): toolkit-generated sparkjava-2.3 [DO NOT MERGE]#11708
Draft
jordan-wong wants to merge 3 commits into
Draft
feat(sparkjava-2.3): toolkit-generated sparkjava-2.3 [DO NOT MERGE]#11708jordan-wong wants to merge 3 commits into
jordan-wong wants to merge 3 commits into
Conversation
…[DO NOT MERGE] Rebased onto current master to fix the stale-base CI failures on PR #11562. This branch contains only the toolkit-generated sparkjava-2.3 work: - SparkJavaDecorator, RoutesInstrumentation (with Routes.find advice) - SparkJavaTest, SparkJavaForkedTest (Java tests per R20) - build.gradle updated for the generated module structure - Old groovy test + TestSparkJavaApplication + stale gradle.lockfile removed (toolkit produces Java tests only) Supersedes #11562. The supported-configurations.json fix from #11562 is no longer needed — master already has the SPARKJAVA env var entries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Adds the three integration config entries needed for the new sparkjava-2.3 module:
- DD_TRACE_SPARKJAVA_2_3_ENABLED (for super("sparkjava-2.3") in RoutesInstrumentation)
- DD_TRACE_SPARKJAVA_ANALYTICS_ENABLED (for decorator instrumentationNames() -> "sparkjava")
- DD_TRACE_SPARKJAVA_ANALYTICS_SAMPLE_RATE (same)
Fixes the config-inversion-linter CI job on this PR.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
… 'double') dd-trace-java's supported-configurations.json schema uses 'decimal' for double-precision floats; 'double' fails the validate_supported_configurations_v2 GitLab CI check. Matches existing AKKA_HTTP_ANALYTICS_SAMPLE_RATE and other analytics-rate entries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jordan-wong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased toolkit-generated sparkjava-2.3 instrumentation onto current master to fix stale-base CI drift on PR #11562. Single squashed commit, sparkjava-2.3 module only.
Why this PR
PR #11562 sits on a branch ~200+ commits behind current master, which causes
dd-gitlab/build_tests: [:instrumentationLatestDepTest, latestdep]to fail intermittently due to unrelated drift — not a sparkjava code defect. Running the exact same Gradle command against PR #11562's HEAD locally passes.This PR rebases the toolkit-generated work onto current master so CI runs against a clean base.
What's in this PR
Only the toolkit-generated sparkjava-2.3 work — nothing else from #11562's branch:
SparkJavaDecorator.java(new)RoutesInstrumentation.javaupdated (Routes.find advice)SparkJavaTest.java,SparkJavaForkedTest.java— Java tests (per R20: no Groovy in toolkit-generated tests)build.gradleupdated for the module structuregradle.lockfile,SparkJavaBasedTest.groovy,TestSparkJavaApplication.java(replaced by Java equivalents)What's NOT in this PR (intentionally dropped)
metadata/supported-configurations.jsonfix from feat(sparkjava-2.3): toolkit-generated sparkjava-2.3 instrumentation [DO NOT MERGE] #11562 — already present on current master.github/workflows/*,.claude/skills/*,.gitlab-ci.ymldrift from the stale baseNext step
If CI is green on this branch, close #11562 as superseded. Keeping #11562 open until then so reviewers have continuity.
🤖 Generated with Claude Code